From: ishaanbhimwal <ishaanbhimwal@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: networkmanager-dmenu-2.1.0
Date: Sat, 02 Jul 2022 09:55:19 +0200 [thread overview]
Message-ID: <20220702075519.cfcLZtC8hh21GlnUZVMRU7-NVQAhp4l1HYZoyk1F358@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37793@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
New review comment by ishaanbhimwal on void-packages repository
https://github.com/void-linux/void-packages/pull/37793#discussion_r912335119
Comment:
your idea seems right considering the fact that arch doesn't even have a `/usr/share/examples` directory. can you confirm these changes so I can commit them:
```
--- a/srcpkgs/networkmanager-dmenu/template
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -14,6 +14,6 @@ do_install() {
vbin networkmanager_dmenu
vlicense LICENSE.txt
vdoc README.md
- vdoc config.ini.example
+ vconf config.ini.example
vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
}
```
next prev parent reply other threads:[~2022-07-02 7:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 19:25 [PR PATCH] " ishaanbhimwal
2022-07-01 19:28 ` [PR REVIEW] " classabbyamp
2022-07-01 19:34 ` [PR PATCH] [Updated] " ishaanbhimwal
2022-07-01 20:28 ` ishaanbhimwal
2022-07-01 23:01 ` classabbyamp
2022-07-01 23:18 ` [PR PATCH] [Updated] " ishaanbhimwal
2022-07-01 23:22 ` ishaanbhimwal
2022-07-01 23:23 ` classabbyamp
2022-07-01 23:27 ` [PR PATCH] [Updated] " ishaanbhimwal
2022-07-01 23:28 ` ishaanbhimwal
2022-07-01 23:49 ` archbtw24
2022-07-01 23:49 ` archbtw24
2022-07-01 23:49 ` ishaanbhimwal
2022-07-01 23:49 ` ishaanbhimwal
2022-07-02 0:03 ` [PR REVIEW] " classabbyamp
2022-07-02 5:09 ` ishaanbhimwal
2022-07-02 5:44 ` ishaanbhimwal
2022-07-02 5:44 ` ishaanbhimwal
2022-07-02 7:21 ` classabbyamp
2022-07-02 7:55 ` ishaanbhimwal [this message]
2022-07-02 7:56 ` ishaanbhimwal
2022-07-02 7:56 ` ishaanbhimwal
2022-07-02 8:03 ` ishaanbhimwal
2022-07-02 12:54 ` [PR PATCH] [Updated] " ishaanbhimwal
2022-07-02 13:00 ` ishaanbhimwal
2022-07-02 13:05 ` ishaanbhimwal
2022-07-02 13:07 ` ishaanbhimwal
2022-07-02 13:08 ` ishaanbhimwal
2022-07-02 15:49 ` [PR REVIEW] " classabbyamp
2022-07-04 7:31 ` ishaanbhimwal
2022-07-04 8:42 ` ishaanbhimwal
2022-10-03 2:13 ` github-actions
2022-10-17 2:15 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220702075519.cfcLZtC8hh21GlnUZVMRU7-NVQAhp4l1HYZoyk1F358@z \
--to=ishaanbhimwal@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).