[PR PATCH] New package: networkmanager-dmenu-2.1.0

[PR PATCH] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

There is a new pull request by ishaanbhimwal against master on the void-packages repository

https://github.com/ishaanbhimwal/void-packages networkmanager-dmenu
https://github.com/void-linux/void-packages/pull/37793

New package: networkmanager-dmenu-2.1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37793.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-networkmanager-dmenu-37793.patch --]
[-- Type: text/x-diff, Size: 1282 bytes --]

From 82e5d8a6fc6244d539466c38ab1827fa04867a30 Mon Sep 17 00:00:00 2001
From: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date: Sat, 2 Jul 2022 00:51:31 +0530
Subject: [PATCH] New package: networkmanager-dmenu-2.1.0

---
 srcpkgs/networkmanager-dmenu/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/networkmanager-dmenu/template

diff --git a/srcpkgs/networkmanager-dmenu/template b/srcpkgs/networkmanager-dmenu/template
new file mode 100644
index 000000000000..1b2231814f46
--- /dev/null
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -0,0 +1,19 @@
+# Template file for 'networkmanager-dmenu'
+pkgname=networkmanager-dmenu
+version=2.1.0
+revision=1
+depends="python3 NetworkManager python3-gobject"
+short_desc="Control NetworkManager via dmenu"
+maintainer="Ishaan Bhimwal <ishaanbhimwal@protonmail.com>"
+license="MIT"
+homepage="https://github.com/firecat53/networkmanager-dmenu"
+distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+checksum=f39090bb924969dd5e76e8b07dd57ba89f146f444f225106383345d458de0729
+
+do_install() {
+	vbin networkmanager_dmenu
+	vlicense LICENSE.txt
+	vdoc README.md
+	vdoc config.ini.example
+	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
+}
\ No newline at end of file

Re: [PR REVIEW] New package: networkmanager-dmenu-2.1.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#discussion_r912208716

Comment:
expand $homepage here

Re: [PR PATCH] [Updated] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

There is an updated pull request by ishaanbhimwal against master on the void-packages repository

https://github.com/ishaanbhimwal/void-packages networkmanager-dmenu
https://github.com/void-linux/void-packages/pull/37793

New package: networkmanager-dmenu-2.1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37793.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-networkmanager-dmenu-37793.patch --]
[-- Type: text/x-diff, Size: 2438 bytes --]

From 82e5d8a6fc6244d539466c38ab1827fa04867a30 Mon Sep 17 00:00:00 2001
From: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date: Sat, 2 Jul 2022 00:51:31 +0530
Subject: [PATCH 1/2] New package: networkmanager-dmenu-2.1.0

---
 srcpkgs/networkmanager-dmenu/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/networkmanager-dmenu/template

diff --git a/srcpkgs/networkmanager-dmenu/template b/srcpkgs/networkmanager-dmenu/template
new file mode 100644
index 000000000000..1b2231814f46
--- /dev/null
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -0,0 +1,19 @@
+# Template file for 'networkmanager-dmenu'
+pkgname=networkmanager-dmenu
+version=2.1.0
+revision=1
+depends="python3 NetworkManager python3-gobject"
+short_desc="Control NetworkManager via dmenu"
+maintainer="Ishaan Bhimwal <ishaanbhimwal@protonmail.com>"
+license="MIT"
+homepage="https://github.com/firecat53/networkmanager-dmenu"
+distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+checksum=f39090bb924969dd5e76e8b07dd57ba89f146f444f225106383345d458de0729
+
+do_install() {
+	vbin networkmanager_dmenu
+	vlicense LICENSE.txt
+	vdoc README.md
+	vdoc config.ini.example
+	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
+}
\ No newline at end of file

From b508b64b1632ff51580c8c4d00a4c65eea456c3e Mon Sep 17 00:00:00 2001
From: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date: Sat, 2 Jul 2022 01:03:03 +0530
Subject: [PATCH 2/2] expand homepage

---
 srcpkgs/networkmanager-dmenu/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/networkmanager-dmenu/template b/srcpkgs/networkmanager-dmenu/template
index 1b2231814f46..4172e8f15ec5 100644
--- a/srcpkgs/networkmanager-dmenu/template
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -7,7 +7,7 @@ short_desc="Control NetworkManager via dmenu"
 maintainer="Ishaan Bhimwal <ishaanbhimwal@protonmail.com>"
 license="MIT"
 homepage="https://github.com/firecat53/networkmanager-dmenu"
-distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+distfiles="https://github.com/firecat53/networkmanager-dmenu/archive/refs/tags/v${version}.tar.gz"
 checksum=f39090bb924969dd5e76e8b07dd57ba89f146f444f225106383345d458de0729
 
 do_install() {
@@ -16,4 +16,4 @@ do_install() {
 	vdoc README.md
 	vdoc config.ini.example
 	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
-}
\ No newline at end of file
+}

Re: [PR PATCH] [Updated] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

There is an updated pull request by ishaanbhimwal against master on the void-packages repository

https://github.com/ishaanbhimwal/void-packages networkmanager-dmenu
https://github.com/void-linux/void-packages/pull/37793

New package: networkmanager-dmenu-2.1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37793.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-networkmanager-dmenu-37793.patch --]
[-- Type: text/x-diff, Size: 1633 bytes --]

From 769c05da4655460009a6062ac85d1655c029d468 Mon Sep 17 00:00:00 2001
From: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date: Sat, 2 Jul 2022 01:55:40 +0530
Subject: [PATCH] Squashed commit of the following:

commit b508b64b1632ff51580c8c4d00a4c65eea456c3e
Author: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date:   Sat Jul 2 01:03:03 2022 +0530

    expand homepage

commit 82e5d8a6fc6244d539466c38ab1827fa04867a30
Author: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date:   Sat Jul 2 00:51:31 2022 +0530

    New package: networkmanager-dmenu-2.1.0
---
 srcpkgs/networkmanager-dmenu/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/networkmanager-dmenu/template

diff --git a/srcpkgs/networkmanager-dmenu/template b/srcpkgs/networkmanager-dmenu/template
new file mode 100644
index 000000000000..4172e8f15ec5
--- /dev/null
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -0,0 +1,19 @@
+# Template file for 'networkmanager-dmenu'
+pkgname=networkmanager-dmenu
+version=2.1.0
+revision=1
+depends="python3 NetworkManager python3-gobject"
+short_desc="Control NetworkManager via dmenu"
+maintainer="Ishaan Bhimwal <ishaanbhimwal@protonmail.com>"
+license="MIT"
+homepage="https://github.com/firecat53/networkmanager-dmenu"
+distfiles="https://github.com/firecat53/networkmanager-dmenu/archive/refs/tags/v${version}.tar.gz"
+checksum=f39090bb924969dd5e76e8b07dd57ba89f146f444f225106383345d458de0729
+
+do_install() {
+	vbin networkmanager_dmenu
+	vlicense LICENSE.txt
+	vdoc README.md
+	vdoc config.ini.example
+	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
+}

Re: New package: networkmanager-dmenu-2.1.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#issuecomment-1172772724

Comment:
the commit message should be just `New package: networkmanager-dmenu-2.1.0`

Re: [PR PATCH] [Updated] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

There is an updated pull request by ishaanbhimwal against master on the void-packages repository

https://github.com/ishaanbhimwal/void-packages networkmanager-dmenu
https://github.com/void-linux/void-packages/pull/37793

New package: networkmanager-dmenu-2.1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37793.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-networkmanager-dmenu-37793.patch --]
[-- Type: text/x-diff, Size: 1639 bytes --]

From 5606d0d22a0e6b5c36eed651c2d6aebca8f06d17 Mon Sep 17 00:00:00 2001
From: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date: Sat, 2 Jul 2022 01:55:40 +0530
Subject: [PATCH] New package: networkmanager-dmenu-2.1.0

commit b508b64b1632ff51580c8c4d00a4c65eea456c3e
Author: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date:   Sat Jul 2 01:03:03 2022 +0530

    expand homepage

commit 82e5d8a6fc6244d539466c38ab1827fa04867a30
Author: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date:   Sat Jul 2 00:51:31 2022 +0530

    New package: networkmanager-dmenu-2.1.0
---
 srcpkgs/networkmanager-dmenu/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/networkmanager-dmenu/template

diff --git a/srcpkgs/networkmanager-dmenu/template b/srcpkgs/networkmanager-dmenu/template
new file mode 100644
index 000000000000..4172e8f15ec5
--- /dev/null
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -0,0 +1,19 @@
+# Template file for 'networkmanager-dmenu'
+pkgname=networkmanager-dmenu
+version=2.1.0
+revision=1
+depends="python3 NetworkManager python3-gobject"
+short_desc="Control NetworkManager via dmenu"
+maintainer="Ishaan Bhimwal <ishaanbhimwal@protonmail.com>"
+license="MIT"
+homepage="https://github.com/firecat53/networkmanager-dmenu"
+distfiles="https://github.com/firecat53/networkmanager-dmenu/archive/refs/tags/v${version}.tar.gz"
+checksum=f39090bb924969dd5e76e8b07dd57ba89f146f444f225106383345d458de0729
+
+do_install() {
+	vbin networkmanager_dmenu
+	vlicense LICENSE.txt
+	vdoc README.md
+	vdoc config.ini.example
+	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
+}

Re: New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New comment by ishaanbhimwal on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#issuecomment-1172781039

Comment:
> the commit message should be just `New package: networkmanager-dmenu-2.1.0`

done!

Re: New package: networkmanager-dmenu-2.1.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#issuecomment-1172781467

Comment:
the rest of the message (from squashing) isn't necessary; it doesn't really add anything

Re: [PR PATCH] [Updated] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

There is an updated pull request by ishaanbhimwal against master on the void-packages repository

https://github.com/ishaanbhimwal/void-packages networkmanager-dmenu
https://github.com/void-linux/void-packages/pull/37793

New package: networkmanager-dmenu-2.1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37793.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-networkmanager-dmenu-37793.patch --]
[-- Type: text/x-diff, Size: 1292 bytes --]

From 00a80a5c156a85bf23746fead0210fb8601a9cb4 Mon Sep 17 00:00:00 2001
From: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date: Sat, 2 Jul 2022 01:55:40 +0530
Subject: [PATCH] New package: networkmanager-dmenu-2.1.0

---
 srcpkgs/networkmanager-dmenu/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/networkmanager-dmenu/template

diff --git a/srcpkgs/networkmanager-dmenu/template b/srcpkgs/networkmanager-dmenu/template
new file mode 100644
index 000000000000..4172e8f15ec5
--- /dev/null
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -0,0 +1,19 @@
+# Template file for 'networkmanager-dmenu'
+pkgname=networkmanager-dmenu
+version=2.1.0
+revision=1
+depends="python3 NetworkManager python3-gobject"
+short_desc="Control NetworkManager via dmenu"
+maintainer="Ishaan Bhimwal <ishaanbhimwal@protonmail.com>"
+license="MIT"
+homepage="https://github.com/firecat53/networkmanager-dmenu"
+distfiles="https://github.com/firecat53/networkmanager-dmenu/archive/refs/tags/v${version}.tar.gz"
+checksum=f39090bb924969dd5e76e8b07dd57ba89f146f444f225106383345d458de0729
+
+do_install() {
+	vbin networkmanager_dmenu
+	vlicense LICENSE.txt
+	vdoc README.md
+	vdoc config.ini.example
+	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
+}

Re: New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by ishaanbhimwal on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#issuecomment-1172782578

Comment:
done! (2)

Re: New package: networkmanager-dmenu-2.1.0

[archbtw24]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New comment by archbtw24 on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#issuecomment-1172787729

Comment:
check

Re: New package: networkmanager-dmenu-2.1.0

[archbtw24]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New comment by archbtw24 on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#issuecomment-1172787729

Comment:
check

Re: New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by ishaanbhimwal on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#issuecomment-1172782578

Comment:
done! (2)

Re: New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New comment by ishaanbhimwal on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#issuecomment-1172781039

Comment:
> the commit message should be just `New package: networkmanager-dmenu-2.1.0`

done!

Re: [PR REVIEW] New package: networkmanager-dmenu-2.1.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#discussion_r912293579

Comment:
this should probably be `vsconf` (see manual.md)

Re: [PR REVIEW] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

New review comment by ishaanbhimwal on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#discussion_r912321363

Comment:
it makes sense to put those in `/usr/share/examples` but unfortunately the original package doesn't do that and doing so will ultimately confuse the user about where to find what.

* [example of a similar void linux template](https://github.com/void-linux/void-packages/blob/master/srcpkgs/clipmenu/template)
* [original package aur pkgbuild](https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=networkmanager-dmenu-git)

Re: [PR REVIEW] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

New review comment by ishaanbhimwal on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#discussion_r912321363

Comment:
it makes sense to put those in `/usr/share/examples` but unfortunately the original package doesn't do that and doing so will ultimately confuse the user about where to find what.

* [example of a similar void linux template](https://github.com/void-linux/void-packages/blob/master/srcpkgs/clipmenu/template)
* [original package aur pkgbuild](https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=networkmanager-dmenu-git)

Re: [PR REVIEW] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

New review comment by ishaanbhimwal on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#discussion_r912324124

Comment:
it makes sense to put those in `/usr/share/examples` but unfortunately the original package doesn't do that and doing so will ultimately confuse the user about where to find what.

* similar void linux template [[1]](https://github.com/void-linux/void-packages/blob/master/srcpkgs/clipmenu/template)
* original package aur pkgbuild [[2]](https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=networkmanager-dmenu-git)

Re: [PR REVIEW] New package: networkmanager-dmenu-2.1.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#discussion_r912332108

Comment:
[1] doesn't install any example configuration at all
 
[2] is not void, arch may have different standards for package file locations (and that's AUR, which is more of a free-for-all than void-packages)

i still think that example configuration files should go in the place designated for example configuration files

Re: [PR REVIEW] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

New review comment by ishaanbhimwal on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#discussion_r912335119

Comment:
your idea seems right considering the fact that arch doesn't even have a `/usr/share/examples` directory. can you confirm these changes so I can commit them:

```
--- a/srcpkgs/networkmanager-dmenu/template
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -14,6 +14,6 @@ do_install() {
 	vbin networkmanager_dmenu
 	vlicense LICENSE.txt
 	vdoc README.md
-	vdoc config.ini.example
+	vconf config.ini.example
 	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
 }
```

Re: [PR REVIEW] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

New review comment by ishaanbhimwal on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#discussion_r912335119

Comment:
your idea seems right considering the fact that arch doesn't even have a `/usr/share/examples` directory. can you confirm these changes so I can commit them:

```
--- a/srcpkgs/networkmanager-dmenu/template
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -14,6 +14,6 @@ do_install() {
 	vbin networkmanager_dmenu
 	vlicense LICENSE.txt
 	vdoc README.md
-	vdoc config.ini.example
+	vconf config.ini.example
 	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
 }
```

Re: [PR REVIEW] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

New review comment by ishaanbhimwal on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#discussion_r912335235

Comment:
your idea seems right considering the fact that arch doesn't even have a `/usr/share/examples` directory. can you confirm these changes so I can commit them:

```diff
--- a/srcpkgs/networkmanager-dmenu/template
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -14,6 +14,6 @@ do_install() {
 	vbin networkmanager_dmenu
 	vlicense LICENSE.txt
 	vdoc README.md
-	vdoc config.ini.example
+	vconf config.ini.example
 	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
 }
```

Re: [PR REVIEW] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

New review comment by ishaanbhimwal on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#discussion_r912335235

Comment:
your idea seems right considering the fact that arch doesn't even have a `/usr/share/examples` directory. can you confirm these changes so I can commit them:

```diff
--- a/srcpkgs/networkmanager-dmenu/template
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -14,6 +14,6 @@ do_install() {
 	vbin networkmanager_dmenu
 	vlicense LICENSE.txt
 	vdoc README.md
-	vdoc config.ini.example
+	vsconf config.ini.example
 	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
 }
```

Re: [PR PATCH] [Updated] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

There is an updated pull request by ishaanbhimwal against master on the void-packages repository

https://github.com/ishaanbhimwal/void-packages networkmanager-dmenu
https://github.com/void-linux/void-packages/pull/37793

New package: networkmanager-dmenu-2.1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37793.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-networkmanager-dmenu-37793.patch --]
[-- Type: text/x-diff, Size: 5531 bytes --]

From b5733d3b0e885f264707b56c0f4da0c0351db9dc Mon Sep 17 00:00:00 2001
From: q66 <daniel@octaforge.org>
Date: Fri, 1 Jul 2022 17:19:47 +0200
Subject: [PATCH] New package: networkmanager-dmenu-2.1.0

---
 srcpkgs/networkmanager-dmenu/template         |  19 +++
 .../qemu/patches/fix-linux-user-ppc32.patch   | 117 ++++++++++++++++++
 2 files changed, 136 insertions(+)
 create mode 100644 srcpkgs/networkmanager-dmenu/template
 create mode 100644 srcpkgs/qemu/patches/fix-linux-user-ppc32.patch

diff --git a/srcpkgs/networkmanager-dmenu/template b/srcpkgs/networkmanager-dmenu/template
new file mode 100644
index 000000000000..ed8510b65e32
--- /dev/null
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -0,0 +1,19 @@
+# Template file for 'networkmanager-dmenu'
+pkgname=networkmanager-dmenu
+version=2.1.0
+revision=1
+depends="python3 NetworkManager python3-gobject"
+short_desc="Control NetworkManager via dmenu"
+maintainer="Ishaan Bhimwal <ishaanbhimwal@protonmail.com>"
+license="MIT"
+homepage="https://github.com/firecat53/networkmanager-dmenu"
+distfiles="https://github.com/firecat53/networkmanager-dmenu/archive/refs/tags/v${version}.tar.gz"
+checksum=f39090bb924969dd5e76e8b07dd57ba89f146f444f225106383345d458de0729
+
+do_install() {
+	vbin networkmanager_dmenu
+	vlicense LICENSE.txt
+	vdoc README.md
+	vsconf config.ini.example
+	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
+}
diff --git a/srcpkgs/qemu/patches/fix-linux-user-ppc32.patch b/srcpkgs/qemu/patches/fix-linux-user-ppc32.patch
new file mode 100644
index 000000000000..cd47435d5aa9
--- /dev/null
+++ b/srcpkgs/qemu/patches/fix-linux-user-ppc32.patch
@@ -0,0 +1,117 @@
+commit 37814f62c2cc7aba2eea073014d6c53dcd5bf42c
+Author: q66 <daniel@octaforge.org>
+Date:   Fri Jul 1 16:53:55 2022 +0200
+
+    fix linux-user build on 32-bit ppc
+    
+    Partial revert https://gitlab.com/qemu-project/qemu/-/commit/9d1401b79463e74adbfac69d836789d4e103fb61
+    and https://gitlab.com/qemu-project/qemu/-/commit/0a7e01904d407baa73c1baddbdfc9ccf2ace8356
+
+diff --git a/common-user/host/ppc/safe-syscall.inc.S b/common-user/host/ppc/safe-syscall.inc.S
+new file mode 100644
+index 0000000..e69de29
+diff --git a/common-user/safe-syscall-error.c b/common-user/safe-syscall-error.c
+index cf74b50..a36132c 100644
+--- a/common-user/safe-syscall-error.c
++++ b/common-user/safe-syscall-error.c
+@@ -12,6 +12,7 @@
+ #include "qemu/osdep.h"
+ #include "user/safe-syscall.h"
+ 
++#if !defined(__powerpc__) || defined(__powerpc64__)
+ /*
+  * This is intended to be invoked via tail-call on the error path
+  * from the assembly in host/arch/safe-syscall.inc.S.  This takes
+@@ -23,3 +24,4 @@ long safe_syscall_set_errno_tail(int value)
+     errno = value;
+     return -1;
+ }
++#endif
+diff --git a/include/user/safe-syscall.h b/include/user/safe-syscall.h
+index 61a04e2..793fe84 100644
+--- a/include/user/safe-syscall.h
++++ b/include/user/safe-syscall.h
+@@ -125,6 +125,8 @@
+  * kinds of restartability.
+  */
+ 
++#if !defined(__powerpc__) || defined(__powerpc64__)
++
+ /* The core part of this function is implemented in assembly */
+ extern long safe_syscall_base(int *pending, long number, ...);
+ extern long safe_syscall_set_errno_tail(int value);
+@@ -137,4 +139,10 @@ extern char safe_syscall_end[];
+     safe_syscall_base(&((TaskState *)thread_cpu->opaque)->signal_pending, \
+                       __VA_ARGS__)
+ 
++#else
++
++#define safe_syscall syscall
++
++#endif
++
+ #endif
+diff --git a/linux-user/include/host/ppc/host-signal.h b/linux-user/include/host/ppc/host-signal.h
+new file mode 100644
+index 0000000..b80384d
+--- /dev/null
++++ b/linux-user/include/host/ppc/host-signal.h
+@@ -0,0 +1,38 @@
++/*
++ * host-signal.h: signal info dependent on the host architecture
++ *
++ * Copyright (c) 2003-2005 Fabrice Bellard
++ * Copyright (c) 2021 Linaro Limited
++ *
++ * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
++ * See the COPYING file in the top-level directory.
++ */
++
++#ifndef PPC_HOST_SIGNAL_H
++#define PPC_HOST_SIGNAL_H
++
++/* The third argument to a SA_SIGINFO handler is ucontext_t. */
++typedef ucontext_t host_sigcontext;
++
++static inline uintptr_t host_signal_pc(host_sigcontext *uc)
++{
++    return uc->uc_mcontext.regs->nip;
++}
++
++static inline void host_signal_set_pc(host_sigcontext *uc, uintptr_t pc)
++{
++    uc->uc_mcontext.regs->nip = pc;
++}
++
++static inline void *host_signal_mask(host_sigcontext *uc)
++{
++    return &uc->uc_sigmask;
++}
++
++static inline bool host_signal_write(siginfo_t *info, host_sigcontext *uc)
++{
++    return uc->uc_mcontext.regs->trap != 0x400
++        && (uc->uc_mcontext.regs->dsisr & 0x02000000);
++}
++
++#endif
+diff --git a/linux-user/signal.c b/linux-user/signal.c
+index 092e70b..b8dfa8a 100644
+--- a/linux-user/signal.c
++++ b/linux-user/signal.c
+@@ -800,6 +800,7 @@ void queue_signal(CPUArchState *env, int sig, int si_type,
+ /* Adjust the signal context to rewind out of safe-syscall if we're in it */
+ static inline void rewind_if_in_safe_syscall(void *puc)
+ {
++#if !defined(__powerpc__) || defined(__powerpc64__)
+     host_sigcontext *uc = (host_sigcontext *)puc;
+     uintptr_t pcreg = host_signal_pc(uc);
+ 
+@@ -807,6 +808,7 @@ static inline void rewind_if_in_safe_syscall(void *puc)
+         && pcreg < (uintptr_t)safe_syscall_end) {
+         host_signal_set_pc(uc, (uintptr_t)safe_syscall_start);
+     }
++#endif
+ }
+ 
+ static void host_signal_handler(int host_sig, siginfo_t *info, void *puc)

Re: [PR PATCH] [Updated] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

There is an updated pull request by ishaanbhimwal against master on the void-packages repository

https://github.com/ishaanbhimwal/void-packages networkmanager-dmenu
https://github.com/void-linux/void-packages/pull/37793

New package: networkmanager-dmenu-2.1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37793.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-networkmanager-dmenu-37793.patch --]
[-- Type: text/x-diff, Size: 10056 bytes --]

From b5733d3b0e885f264707b56c0f4da0c0351db9dc Mon Sep 17 00:00:00 2001
From: q66 <daniel@octaforge.org>
Date: Fri, 1 Jul 2022 17:19:47 +0200
Subject: [PATCH 1/2] New package: networkmanager-dmenu-2.1.0

---
 srcpkgs/networkmanager-dmenu/template         |  19 +++
 .../qemu/patches/fix-linux-user-ppc32.patch   | 117 ++++++++++++++++++
 2 files changed, 136 insertions(+)
 create mode 100644 srcpkgs/networkmanager-dmenu/template
 create mode 100644 srcpkgs/qemu/patches/fix-linux-user-ppc32.patch

diff --git a/srcpkgs/networkmanager-dmenu/template b/srcpkgs/networkmanager-dmenu/template
new file mode 100644
index 000000000000..ed8510b65e32
--- /dev/null
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -0,0 +1,19 @@
+# Template file for 'networkmanager-dmenu'
+pkgname=networkmanager-dmenu
+version=2.1.0
+revision=1
+depends="python3 NetworkManager python3-gobject"
+short_desc="Control NetworkManager via dmenu"
+maintainer="Ishaan Bhimwal <ishaanbhimwal@protonmail.com>"
+license="MIT"
+homepage="https://github.com/firecat53/networkmanager-dmenu"
+distfiles="https://github.com/firecat53/networkmanager-dmenu/archive/refs/tags/v${version}.tar.gz"
+checksum=f39090bb924969dd5e76e8b07dd57ba89f146f444f225106383345d458de0729
+
+do_install() {
+	vbin networkmanager_dmenu
+	vlicense LICENSE.txt
+	vdoc README.md
+	vsconf config.ini.example
+	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
+}
diff --git a/srcpkgs/qemu/patches/fix-linux-user-ppc32.patch b/srcpkgs/qemu/patches/fix-linux-user-ppc32.patch
new file mode 100644
index 000000000000..cd47435d5aa9
--- /dev/null
+++ b/srcpkgs/qemu/patches/fix-linux-user-ppc32.patch
@@ -0,0 +1,117 @@
+commit 37814f62c2cc7aba2eea073014d6c53dcd5bf42c
+Author: q66 <daniel@octaforge.org>
+Date:   Fri Jul 1 16:53:55 2022 +0200
+
+    fix linux-user build on 32-bit ppc
+    
+    Partial revert https://gitlab.com/qemu-project/qemu/-/commit/9d1401b79463e74adbfac69d836789d4e103fb61
+    and https://gitlab.com/qemu-project/qemu/-/commit/0a7e01904d407baa73c1baddbdfc9ccf2ace8356
+
+diff --git a/common-user/host/ppc/safe-syscall.inc.S b/common-user/host/ppc/safe-syscall.inc.S
+new file mode 100644
+index 0000000..e69de29
+diff --git a/common-user/safe-syscall-error.c b/common-user/safe-syscall-error.c
+index cf74b50..a36132c 100644
+--- a/common-user/safe-syscall-error.c
++++ b/common-user/safe-syscall-error.c
+@@ -12,6 +12,7 @@
+ #include "qemu/osdep.h"
+ #include "user/safe-syscall.h"
+ 
++#if !defined(__powerpc__) || defined(__powerpc64__)
+ /*
+  * This is intended to be invoked via tail-call on the error path
+  * from the assembly in host/arch/safe-syscall.inc.S.  This takes
+@@ -23,3 +24,4 @@ long safe_syscall_set_errno_tail(int value)
+     errno = value;
+     return -1;
+ }
++#endif
+diff --git a/include/user/safe-syscall.h b/include/user/safe-syscall.h
+index 61a04e2..793fe84 100644
+--- a/include/user/safe-syscall.h
++++ b/include/user/safe-syscall.h
+@@ -125,6 +125,8 @@
+  * kinds of restartability.
+  */
+ 
++#if !defined(__powerpc__) || defined(__powerpc64__)
++
+ /* The core part of this function is implemented in assembly */
+ extern long safe_syscall_base(int *pending, long number, ...);
+ extern long safe_syscall_set_errno_tail(int value);
+@@ -137,4 +139,10 @@ extern char safe_syscall_end[];
+     safe_syscall_base(&((TaskState *)thread_cpu->opaque)->signal_pending, \
+                       __VA_ARGS__)
+ 
++#else
++
++#define safe_syscall syscall
++
++#endif
++
+ #endif
+diff --git a/linux-user/include/host/ppc/host-signal.h b/linux-user/include/host/ppc/host-signal.h
+new file mode 100644
+index 0000000..b80384d
+--- /dev/null
++++ b/linux-user/include/host/ppc/host-signal.h
+@@ -0,0 +1,38 @@
++/*
++ * host-signal.h: signal info dependent on the host architecture
++ *
++ * Copyright (c) 2003-2005 Fabrice Bellard
++ * Copyright (c) 2021 Linaro Limited
++ *
++ * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
++ * See the COPYING file in the top-level directory.
++ */
++
++#ifndef PPC_HOST_SIGNAL_H
++#define PPC_HOST_SIGNAL_H
++
++/* The third argument to a SA_SIGINFO handler is ucontext_t. */
++typedef ucontext_t host_sigcontext;
++
++static inline uintptr_t host_signal_pc(host_sigcontext *uc)
++{
++    return uc->uc_mcontext.regs->nip;
++}
++
++static inline void host_signal_set_pc(host_sigcontext *uc, uintptr_t pc)
++{
++    uc->uc_mcontext.regs->nip = pc;
++}
++
++static inline void *host_signal_mask(host_sigcontext *uc)
++{
++    return &uc->uc_sigmask;
++}
++
++static inline bool host_signal_write(siginfo_t *info, host_sigcontext *uc)
++{
++    return uc->uc_mcontext.regs->trap != 0x400
++        && (uc->uc_mcontext.regs->dsisr & 0x02000000);
++}
++
++#endif
+diff --git a/linux-user/signal.c b/linux-user/signal.c
+index 092e70b..b8dfa8a 100644
+--- a/linux-user/signal.c
++++ b/linux-user/signal.c
+@@ -800,6 +800,7 @@ void queue_signal(CPUArchState *env, int sig, int si_type,
+ /* Adjust the signal context to rewind out of safe-syscall if we're in it */
+ static inline void rewind_if_in_safe_syscall(void *puc)
+ {
++#if !defined(__powerpc__) || defined(__powerpc64__)
+     host_sigcontext *uc = (host_sigcontext *)puc;
+     uintptr_t pcreg = host_signal_pc(uc);
+ 
+@@ -807,6 +808,7 @@ static inline void rewind_if_in_safe_syscall(void *puc)
+         && pcreg < (uintptr_t)safe_syscall_end) {
+         host_signal_set_pc(uc, (uintptr_t)safe_syscall_start);
+     }
++#endif
+ }
+ 
+ static void host_signal_handler(int host_sig, siginfo_t *info, void *puc)

From 864859358f11106cd289e998f4dffb29737c5b08 Mon Sep 17 00:00:00 2001
From: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date: Sat, 2 Jul 2022 18:30:12 +0530
Subject: [PATCH 2/2] Delete fix-linux-user-ppc32.patch

---
 .../qemu/patches/fix-linux-user-ppc32.patch   | 117 ------------------
 1 file changed, 117 deletions(-)
 delete mode 100644 srcpkgs/qemu/patches/fix-linux-user-ppc32.patch

diff --git a/srcpkgs/qemu/patches/fix-linux-user-ppc32.patch b/srcpkgs/qemu/patches/fix-linux-user-ppc32.patch
deleted file mode 100644
index cd47435d5aa9..000000000000
--- a/srcpkgs/qemu/patches/fix-linux-user-ppc32.patch
+++ /dev/null
@@ -1,117 +0,0 @@
-commit 37814f62c2cc7aba2eea073014d6c53dcd5bf42c
-Author: q66 <daniel@octaforge.org>
-Date:   Fri Jul 1 16:53:55 2022 +0200
-
-    fix linux-user build on 32-bit ppc
-    
-    Partial revert https://gitlab.com/qemu-project/qemu/-/commit/9d1401b79463e74adbfac69d836789d4e103fb61
-    and https://gitlab.com/qemu-project/qemu/-/commit/0a7e01904d407baa73c1baddbdfc9ccf2ace8356
-
-diff --git a/common-user/host/ppc/safe-syscall.inc.S b/common-user/host/ppc/safe-syscall.inc.S
-new file mode 100644
-index 0000000..e69de29
-diff --git a/common-user/safe-syscall-error.c b/common-user/safe-syscall-error.c
-index cf74b50..a36132c 100644
---- a/common-user/safe-syscall-error.c
-+++ b/common-user/safe-syscall-error.c
-@@ -12,6 +12,7 @@
- #include "qemu/osdep.h"
- #include "user/safe-syscall.h"
- 
-+#if !defined(__powerpc__) || defined(__powerpc64__)
- /*
-  * This is intended to be invoked via tail-call on the error path
-  * from the assembly in host/arch/safe-syscall.inc.S.  This takes
-@@ -23,3 +24,4 @@ long safe_syscall_set_errno_tail(int value)
-     errno = value;
-     return -1;
- }
-+#endif
-diff --git a/include/user/safe-syscall.h b/include/user/safe-syscall.h
-index 61a04e2..793fe84 100644
---- a/include/user/safe-syscall.h
-+++ b/include/user/safe-syscall.h
-@@ -125,6 +125,8 @@
-  * kinds of restartability.
-  */
- 
-+#if !defined(__powerpc__) || defined(__powerpc64__)
-+
- /* The core part of this function is implemented in assembly */
- extern long safe_syscall_base(int *pending, long number, ...);
- extern long safe_syscall_set_errno_tail(int value);
-@@ -137,4 +139,10 @@ extern char safe_syscall_end[];
-     safe_syscall_base(&((TaskState *)thread_cpu->opaque)->signal_pending, \
-                       __VA_ARGS__)
- 
-+#else
-+
-+#define safe_syscall syscall
-+
-+#endif
-+
- #endif
-diff --git a/linux-user/include/host/ppc/host-signal.h b/linux-user/include/host/ppc/host-signal.h
-new file mode 100644
-index 0000000..b80384d
---- /dev/null
-+++ b/linux-user/include/host/ppc/host-signal.h
-@@ -0,0 +1,38 @@
-+/*
-+ * host-signal.h: signal info dependent on the host architecture
-+ *
-+ * Copyright (c) 2003-2005 Fabrice Bellard
-+ * Copyright (c) 2021 Linaro Limited
-+ *
-+ * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
-+ * See the COPYING file in the top-level directory.
-+ */
-+
-+#ifndef PPC_HOST_SIGNAL_H
-+#define PPC_HOST_SIGNAL_H
-+
-+/* The third argument to a SA_SIGINFO handler is ucontext_t. */
-+typedef ucontext_t host_sigcontext;
-+
-+static inline uintptr_t host_signal_pc(host_sigcontext *uc)
-+{
-+    return uc->uc_mcontext.regs->nip;
-+}
-+
-+static inline void host_signal_set_pc(host_sigcontext *uc, uintptr_t pc)
-+{
-+    uc->uc_mcontext.regs->nip = pc;
-+}
-+
-+static inline void *host_signal_mask(host_sigcontext *uc)
-+{
-+    return &uc->uc_sigmask;
-+}
-+
-+static inline bool host_signal_write(siginfo_t *info, host_sigcontext *uc)
-+{
-+    return uc->uc_mcontext.regs->trap != 0x400
-+        && (uc->uc_mcontext.regs->dsisr & 0x02000000);
-+}
-+
-+#endif
-diff --git a/linux-user/signal.c b/linux-user/signal.c
-index 092e70b..b8dfa8a 100644
---- a/linux-user/signal.c
-+++ b/linux-user/signal.c
-@@ -800,6 +800,7 @@ void queue_signal(CPUArchState *env, int sig, int si_type,
- /* Adjust the signal context to rewind out of safe-syscall if we're in it */
- static inline void rewind_if_in_safe_syscall(void *puc)
- {
-+#if !defined(__powerpc__) || defined(__powerpc64__)
-     host_sigcontext *uc = (host_sigcontext *)puc;
-     uintptr_t pcreg = host_signal_pc(uc);
- 
-@@ -807,6 +808,7 @@ static inline void rewind_if_in_safe_syscall(void *puc)
-         && pcreg < (uintptr_t)safe_syscall_end) {
-         host_signal_set_pc(uc, (uintptr_t)safe_syscall_start);
-     }
-+#endif
- }
- 
- static void host_signal_handler(int host_sig, siginfo_t *info, void *puc)

Re: [PR PATCH] [Updated] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

There is an updated pull request by ishaanbhimwal against master on the void-packages repository

https://github.com/ishaanbhimwal/void-packages networkmanager-dmenu
https://github.com/void-linux/void-packages/pull/37793

New package: networkmanager-dmenu-2.1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37793.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-networkmanager-dmenu-37793.patch --]
[-- Type: text/x-diff, Size: 2438 bytes --]

From 82e5d8a6fc6244d539466c38ab1827fa04867a30 Mon Sep 17 00:00:00 2001
From: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date: Sat, 2 Jul 2022 00:51:31 +0530
Subject: [PATCH 1/2] New package: networkmanager-dmenu-2.1.0

---
 srcpkgs/networkmanager-dmenu/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/networkmanager-dmenu/template

diff --git a/srcpkgs/networkmanager-dmenu/template b/srcpkgs/networkmanager-dmenu/template
new file mode 100644
index 000000000000..1b2231814f46
--- /dev/null
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -0,0 +1,19 @@
+# Template file for 'networkmanager-dmenu'
+pkgname=networkmanager-dmenu
+version=2.1.0
+revision=1
+depends="python3 NetworkManager python3-gobject"
+short_desc="Control NetworkManager via dmenu"
+maintainer="Ishaan Bhimwal <ishaanbhimwal@protonmail.com>"
+license="MIT"
+homepage="https://github.com/firecat53/networkmanager-dmenu"
+distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+checksum=f39090bb924969dd5e76e8b07dd57ba89f146f444f225106383345d458de0729
+
+do_install() {
+	vbin networkmanager_dmenu
+	vlicense LICENSE.txt
+	vdoc README.md
+	vdoc config.ini.example
+	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
+}
\ No newline at end of file

From b508b64b1632ff51580c8c4d00a4c65eea456c3e Mon Sep 17 00:00:00 2001
From: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date: Sat, 2 Jul 2022 01:03:03 +0530
Subject: [PATCH 2/2] expand homepage

---
 srcpkgs/networkmanager-dmenu/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/networkmanager-dmenu/template b/srcpkgs/networkmanager-dmenu/template
index 1b2231814f46..4172e8f15ec5 100644
--- a/srcpkgs/networkmanager-dmenu/template
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -7,7 +7,7 @@ short_desc="Control NetworkManager via dmenu"
 maintainer="Ishaan Bhimwal <ishaanbhimwal@protonmail.com>"
 license="MIT"
 homepage="https://github.com/firecat53/networkmanager-dmenu"
-distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+distfiles="https://github.com/firecat53/networkmanager-dmenu/archive/refs/tags/v${version}.tar.gz"
 checksum=f39090bb924969dd5e76e8b07dd57ba89f146f444f225106383345d458de0729
 
 do_install() {
@@ -16,4 +16,4 @@ do_install() {
 	vdoc README.md
 	vdoc config.ini.example
 	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
-}
\ No newline at end of file
+}

Re: [PR PATCH] [Updated] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

There is an updated pull request by ishaanbhimwal against master on the void-packages repository

https://github.com/ishaanbhimwal/void-packages networkmanager-dmenu
https://github.com/void-linux/void-packages/pull/37793

New package: networkmanager-dmenu-2.1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37793.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-networkmanager-dmenu-37793.patch --]
[-- Type: text/x-diff, Size: 2488 bytes --]

From 82e5d8a6fc6244d539466c38ab1827fa04867a30 Mon Sep 17 00:00:00 2001
From: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date: Sat, 2 Jul 2022 00:51:31 +0530
Subject: [PATCH 1/2] New package: networkmanager-dmenu-2.1.0

---
 srcpkgs/networkmanager-dmenu/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/networkmanager-dmenu/template

diff --git a/srcpkgs/networkmanager-dmenu/template b/srcpkgs/networkmanager-dmenu/template
new file mode 100644
index 000000000000..1b2231814f46
--- /dev/null
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -0,0 +1,19 @@
+# Template file for 'networkmanager-dmenu'
+pkgname=networkmanager-dmenu
+version=2.1.0
+revision=1
+depends="python3 NetworkManager python3-gobject"
+short_desc="Control NetworkManager via dmenu"
+maintainer="Ishaan Bhimwal <ishaanbhimwal@protonmail.com>"
+license="MIT"
+homepage="https://github.com/firecat53/networkmanager-dmenu"
+distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+checksum=f39090bb924969dd5e76e8b07dd57ba89f146f444f225106383345d458de0729
+
+do_install() {
+	vbin networkmanager_dmenu
+	vlicense LICENSE.txt
+	vdoc README.md
+	vdoc config.ini.example
+	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
+}
\ No newline at end of file

From 8e2ca6aa9785430344d1dbf1e1d1020e2cb0b476 Mon Sep 17 00:00:00 2001
From: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date: Sat, 2 Jul 2022 01:03:03 +0530
Subject: [PATCH 2/2] expand homepage

---
 srcpkgs/networkmanager-dmenu/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/networkmanager-dmenu/template b/srcpkgs/networkmanager-dmenu/template
index 1b2231814f46..ed8510b65e32 100644
--- a/srcpkgs/networkmanager-dmenu/template
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -7,13 +7,13 @@ short_desc="Control NetworkManager via dmenu"
 maintainer="Ishaan Bhimwal <ishaanbhimwal@protonmail.com>"
 license="MIT"
 homepage="https://github.com/firecat53/networkmanager-dmenu"
-distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+distfiles="https://github.com/firecat53/networkmanager-dmenu/archive/refs/tags/v${version}.tar.gz"
 checksum=f39090bb924969dd5e76e8b07dd57ba89f146f444f225106383345d458de0729
 
 do_install() {
 	vbin networkmanager_dmenu
 	vlicense LICENSE.txt
 	vdoc README.md
-	vdoc config.ini.example
+	vsconf config.ini.example
 	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
-}
\ No newline at end of file
+}

Re: [PR PATCH] [Updated] New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

There is an updated pull request by ishaanbhimwal against master on the void-packages repository

https://github.com/ishaanbhimwal/void-packages networkmanager-dmenu
https://github.com/void-linux/void-packages/pull/37793

New package: networkmanager-dmenu-2.1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37793.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-networkmanager-dmenu-37793.patch --]
[-- Type: text/x-diff, Size: 1294 bytes --]

From 161e5d92f2fa43f9d89891871d8082eab5d375d6 Mon Sep 17 00:00:00 2001
From: Ishaan Bhimwal <ishaanbhimwal@protonmail.com>
Date: Sat, 2 Jul 2022 00:51:31 +0530
Subject: [PATCH] New package: networkmanager-dmenu-2.1.0

---
 srcpkgs/networkmanager-dmenu/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/networkmanager-dmenu/template

diff --git a/srcpkgs/networkmanager-dmenu/template b/srcpkgs/networkmanager-dmenu/template
new file mode 100644
index 000000000000..ed8510b65e32
--- /dev/null
+++ b/srcpkgs/networkmanager-dmenu/template
@@ -0,0 +1,19 @@
+# Template file for 'networkmanager-dmenu'
+pkgname=networkmanager-dmenu
+version=2.1.0
+revision=1
+depends="python3 NetworkManager python3-gobject"
+short_desc="Control NetworkManager via dmenu"
+maintainer="Ishaan Bhimwal <ishaanbhimwal@protonmail.com>"
+license="MIT"
+homepage="https://github.com/firecat53/networkmanager-dmenu"
+distfiles="https://github.com/firecat53/networkmanager-dmenu/archive/refs/tags/v${version}.tar.gz"
+checksum=f39090bb924969dd5e76e8b07dd57ba89f146f444f225106383345d458de0729
+
+do_install() {
+	vbin networkmanager_dmenu
+	vlicense LICENSE.txt
+	vdoc README.md
+	vsconf config.ini.example
+	vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
+}

Re: [PR REVIEW] New package: networkmanager-dmenu-2.1.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#discussion_r912375260

Comment:
correct

Re: New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

New comment by ishaanbhimwal on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#issuecomment-1173455625

Comment:
@classabbyamp all these stuff should come under `do_install()` or `post_install()`?

```
vbin networkmanager_dmenu
vlicense LICENSE.txt
vdoc README.md
vsconf config.ini.example
vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
```

Re: New package: networkmanager-dmenu-2.1.0

[ishaanbhimwal]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

New comment by ishaanbhimwal on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#issuecomment-1173455625

Comment:
@classabbyamp all these stuff should come under `do_install()` or `post_install()`?

```
vbin networkmanager_dmenu
vlicense LICENSE.txt
vdoc README.md
vsconf config.ini.example
vinstall networkmanager_dmenu.desktop 644 /usr/share/applications
```

Re: New package: networkmanager-dmenu-2.1.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/37793#issuecomment-1264840673

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: networkmanager-dmenu-2.1.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

There's a closed pull request on the void-packages repository

New package: networkmanager-dmenu-2.1.0
https://github.com/void-linux/void-packages/pull/37793

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->