[PR PATCH] New package: stw-0.1

[PR PATCH] New package: stw-0.1

[wael444]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

There is a new pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages stw
https://github.com/void-linux/void-packages/pull/37834

New package: stw-0.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/37834.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-stw-37834.patch --]
[-- Type: text/x-diff, Size: 968 bytes --]

From b49d367580c837b3ec4ef8c9decfee993b471850 Mon Sep 17 00:00:00 2001
From: wael <40663@proton.me>
Date: Mon, 4 Jul 2022 14:28:58 +0300
Subject: [PATCH] New package: stw-0.1

---
 srcpkgs/stw/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/stw/template

diff --git a/srcpkgs/stw/template b/srcpkgs/stw/template
new file mode 100644
index 000000000000..11eabb7626a5
--- /dev/null
+++ b/srcpkgs/stw/template
@@ -0,0 +1,17 @@
+# Template file for 'stw'
+pkgname=stw
+version=0.1
+revision=1
+build_style=gnu-makefile
+make_use_env=yes
+makedepends="libXft-devel freetype-devel base-devel"
+short_desc="Simple text widget for X"
+maintainer="wael <40663@proton.me>"
+license="MIT"
+homepage="https://github.com/sineemore/stw"
+distfiles="https://github.com/sineemore/stw/archive/refs/tags/${version}.tar.gz"
+checksum=cc2d60066a1c70ac8323b942f0d9182aa71d5a16a153a8505d12e683144e5b05
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: stw-0.1

[wael444]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#issuecomment-1173720781

Comment:
i find it quite confusing building is failing ( missing libXft ) for other architectures despite being `libXft-devel` being specified in `makedepends`

Re: [PR REVIEW] New package: stw-0.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#discussion_r913175203

Comment:
adding pkg-config to hostmakedepends could fix cross
```suggestion
hostmakedepends="pkg-config"
makedepends="libXft-devel freetype-devel"
```

Re: [PR REVIEW] New package: stw-0.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#discussion_r913175203

Comment:
```suggestion
makedepends="libXft-devel freetype-devel"
```

Re: [PR REVIEW] New package: stw-0.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#discussion_r913175203

Comment:
```suggestion
makedepends="libXft-devel freetype-devel"
```

Re: New package: stw-0.1

[sineemore]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

New comment by sineemore on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#issuecomment-1174944291

Comment:
```
[user@lemur void-packages]$ find masterdir/ -name Xft.h
masterdir/usr/aarch64-linux-musl/usr/include/X11/Xft/Xft.h
```

Wrong include path I guess.

Re: New package: stw-0.1

[wael444]

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

New comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#issuecomment-1174973319

Comment:
i have set `make_use_env=yes` in the template to force using the provided `Makefile` in stw so i can avoid errors like these:
```make
In file included from stw.c:14:
/usr/aarch64-linux-gnu/usr/include/X11/Xft/Xft.h:39:10: fatal error: ft2build.h: No such file or directory
   39 | #include <ft2build.h>
      |          ^~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:22: stw.o] Error 1
```
but removing the downside is having the builder add its own flags which also add `-I/usr/aarch64-linux-gnu/usr/include` to the make flags when building, hmm...

Re: New package: stw-0.1

[sineemore]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New comment by sineemore on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#issuecomment-1174976584

Comment:
In case you feel to patch upstream Makefile we can continue discussion in https://github.com/sineemore/stw/issues/13

Makefile should probably be rewritten I guess.

Re: [PR PATCH] [Updated] New package: stw-0.1

[wael444]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

There is an updated pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages stw
https://github.com/void-linux/void-packages/pull/37834

New package: stw-0.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/37834.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-stw-37834.patch --]
[-- Type: text/x-diff, Size: 1100 bytes --]

From 30e2378e22fbc2a35a85430494d5826b06a970b9 Mon Sep 17 00:00:00 2001
From: wael <40663@proton.me>
Date: Mon, 4 Jul 2022 14:28:58 +0300
Subject: [PATCH] New package: stw-0.2

---
 srcpkgs/stw/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/stw/template

diff --git a/srcpkgs/stw/template b/srcpkgs/stw/template
new file mode 100644
index 000000000000..d3fd17e7d357
--- /dev/null
+++ b/srcpkgs/stw/template
@@ -0,0 +1,24 @@
+# Template file for 'stw'
+pkgname=stw
+version=0.2
+revision=1
+build_style=gnu-makefile
+make_use_env=compliant
+hostmakedepends="pkg-config"
+makedepends="libXft-devel freetype-devel"
+short_desc="Simple text widget for X"
+maintainer="wael <40663@proton.me>"
+license="MIT"
+homepage="https://github.com/sineemore/stw"
+distfiles="https://github.com/sineemore/stw/archive/refs/tags/${version}.tar.gz"
+checksum=0a08cd619bc5fea55f58fb3d683a66b6e3fcb5c837bf6c349f2b852c74f8030c
+
+pre_build() {
+	if [ -e ${FILESDIR}/config.h ]; then
+		cp ${FILESDIR}/config.h config.h
+	fi
+}
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: stw-0.2

[sineemore]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New comment by sineemore on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#issuecomment-1175076769

Comment:
I think you can try testing the build locally with `./xbps-src pkg -a ...`

Re: New package: stw-0.2

[wael444]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

New comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#issuecomment-1175078076

Comment:
i know but, this is just a more confusing error.
```
cc -std=c99 -pedantic -Wall -Werror -I/usr/aarch64-linux-gnu/usr/include/freetype2 -I/usr/aarch64-linux-gnu/usr/include/X11 -I/usr/aarch64-linux-gnu/usr/include/X11/Xft -I/usr/aarch64-linux-gnu/usr/include/X11/Xft -D_DEFAULT_SOURCE -D_BSD_SOURCE -D_POSIX_C_SOURCE=2 -c stw.c
stw.c:14:10: fatal error: X11/Xft/Xft.h: No such file or directory
   14 | #include <X11/Xft/Xft.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:8: stw.o] Error 1
```
`-I/usr/aarch64-linux-gnu/usr/include/X11 -I/usr/aarch64-linux-gnu/usr/include/X11/Xft -I/usr/aarch64-linux-gnu/usr/include/X11/Xft ` is literally in the build flags...?

Re: [PR REVIEW] New package: stw-0.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#discussion_r913846734

Comment:
```suggestion
make_use_env=yes
```

Re: [PR REVIEW] New package: stw-0.2

[wael444]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New review comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#discussion_r913852015

Comment:
this wont change anything but i guess i'll add it.

Re: [PR PATCH] [Updated] New package: stw-0.2

[wael444]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

There is an updated pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages stw
https://github.com/void-linux/void-packages/pull/37834

New package: stw-0.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/37834.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-stw-37834.patch --]
[-- Type: text/x-diff, Size: 1106 bytes --]

From a294198c67efc9be96de734848669e8772809a7b Mon Sep 17 00:00:00 2001
From: wael <40663@proton.me>
Date: Mon, 4 Jul 2022 14:28:58 +0300
Subject: [PATCH] New package: stw-0.2

---
 srcpkgs/stw/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/stw/template

diff --git a/srcpkgs/stw/template b/srcpkgs/stw/template
new file mode 100644
index 000000000000..a5cb448b066b
--- /dev/null
+++ b/srcpkgs/stw/template
@@ -0,0 +1,24 @@
+# Template file for 'stw'
+pkgname=stw
+version=0.2
+revision=1
+build_style=gnu-makefile
+make_use_env=yes
+hostmakedepends="pkg-config"
+makedepends="libX11-devel libXft-devel freetype-devel"
+short_desc="Simple text widget for X"
+maintainer="wael <40663@proton.me>"
+license="MIT"
+homepage="https://github.com/sineemore/stw"
+distfiles="https://github.com/sineemore/stw/archive/refs/tags/${version}.tar.gz"
+checksum=0a08cd619bc5fea55f58fb3d683a66b6e3fcb5c837bf6c349f2b852c74f8030c
+
+do_build() {
+	if [ -e ${FILESDIR}/config.h ]; then
+		cp ${FILESDIR}/config.h config.h
+	fi
+}
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: stw-0.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#discussion_r913856472

Comment:
We only check for existence of that variable, compliant is just an arbitrary word and we should just use yes. I know that also done this way in a few other packages, feel free to open a PR to use yes in them (one commit per package, no revbumps).

Re: [PR REVIEW] New package: stw-0.2

[wael444]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

New review comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#discussion_r913858214

Comment:
> feel free to open a PR to use yes in them (one commit per package, no revbumps).

i have no idea how to do that and git is scary, so..
also yeah thank you for pointing that out.

Re: New package: stw-0.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#issuecomment-1175123705

Comment:
You will need to add `-I/usr/aarch64-linux-gnu/usr/include/` to the command. `-I/usr/aarch64-linux-gnu/usr/include/X11` will try to search for `<X11/Xft/Xft.h>` in `/usr/aarch64-linux-gnu/usr/include/X11/X11/Xft/Xft.h` which obviously doesn't exist

Re: New package: stw-0.2

[sineemore]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New comment by sineemore on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#issuecomment-1175143658

Comment:
I guess the issue is `CFLAGS` overwriting in config.mk.

Re: New package: stw-0.2

[sineemore]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

New comment by sineemore on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#issuecomment-1175143658

Comment:
I guess the issue is `CFLAGS` overwriting in config.mk.

EDIT: Notice how st uses `STCFLAGS` and embeds `CFLAGS` inside.

https://git.suckless.org/st/file/config.mk.html#l25

Re: New package: stw-0.2

[wael444]

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

New comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#issuecomment-1175166754

Comment:
> You will need to add -I/usr/aarch64-linux-gnu/usr/include/ to the command. -I/usr/aarch64-linux-gnu/usr/include/X11 will try to search for <X11/Xft/Xft.h> in /usr/aarch64-linux-gnu/usr/include/X11/X11/Xft/Xft.h which obviously doesn't exist

```
cc -std=c99 -pedantic -Wall -Werror -I/usr/include/X11 `pkg-config --cflags fontconfig` -I/usr/aarch64-linux-gnu/usr/include -D_DEFAULT_SOURCE -D_BSD_SOURCE -D_POSIX_C_SOURCE=2 -c stw.c
In file included from stw.c:3:
/usr/aarch64-linux-gnu/usr/include/limits.h:124:3: error: #include_next is a GCC extension [-Werror]
  124 | # include_next <limits.h>
      |   ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [Makefile:8: stw.o] Error 1
```
note: `-Wall` in `CFLAGS`

Re: [PR PATCH] [Updated] New package: stw-0.2

[wael444]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

There is an updated pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages stw
https://github.com/void-linux/void-packages/pull/37834

New package: stw-0.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/37834.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-stw-37834.patch --]
[-- Type: text/x-diff, Size: 1093 bytes --]

From 77f7a084ed83c8828168c5f45c1d252a1769dbe0 Mon Sep 17 00:00:00 2001
From: wael <40663@proton.me>
Date: Mon, 4 Jul 2022 14:28:58 +0300
Subject: [PATCH] New package: stw-0.3

---
 srcpkgs/stw/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/stw/template

diff --git a/srcpkgs/stw/template b/srcpkgs/stw/template
new file mode 100644
index 000000000000..e9f93997743c
--- /dev/null
+++ b/srcpkgs/stw/template
@@ -0,0 +1,24 @@
+# Template file for 'stw'
+pkgname=stw
+version=0.3
+revision=1
+build_style=gnu-makefile
+make_use_env=yes
+hostmakedepends="pkg-config"
+makedepends="libXft-devel freetype-devel"
+short_desc="Simple text widget for X"
+maintainer="wael <40663@proton.me>"
+license="MIT"
+homepage="https://github.com/sineemore/stw"
+distfiles="https://github.com/sineemore/stw/archive/refs/tags/${version}.tar.gz"
+checksum=c93f092976f97bb14f52e2996f27b2d4bef66d0c9569eda8d11fad4a15f5f2fe
+
+do_build() {
+	if [ -e ${FILESDIR}/config.h ]; then
+		cp ${FILESDIR}/config.h config.h
+	fi
+}
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: stw-0.3

[sineemore]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by sineemore on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#issuecomment-1175197576

Comment:
@paper42 @wael444 thanks for investigation and packaging ^.^

Re: New package: stw-0.3

[sineemore]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New comment by sineemore on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#issuecomment-1175197576

Comment:
@paper42 @wael444 thanks for investigation and packaging ^.^

Not the most optimal way to learn how to properly write Makefiles but still)

Re: New package: stw-0.3

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/37834#issuecomment-1266305895

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: stw-0.3

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

There's a closed pull request on the void-packages repository

New package: stw-0.3
https://github.com/void-linux/void-packages/pull/37834

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)