From: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: hooks: do-extract: extract to tempdir and rename
Date: Wed, 06 Jul 2022 04:13:56 +0200 [thread overview]
Message-ID: <20220706021356.DpDslAFSZ1H84Q47_CFxxrRhGfZ_VblU_4B_oLHnd8Q@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33013@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1123 bytes --]
There's a closed pull request on the void-packages repository
hooks: do-extract: extract to tempdir and rename
https://github.com/void-linux/void-packages/pull/33013
Description:
Extracting to temporary directory then renaming to real $wrksrc,
will make the do-extract steps works atomicity. Either $wrksrc is there
and complete, or it's not there.
Accidentally, this change has a side effect, we can no longer care about
the name of top-level components of a tarball, since we will rename the
top level directory in question to $wrksrc. IOW, we don't need to set
$wrksrc any longer. The side effect of above side effect: we can starting
to build multiple packages that have same top-level's name without clean
from now on.
In another hand, we only rename the inner directory if the extracted
file hierarchy has single top-level directory, we will use the
renamed-temporary directory as the $wrksrc, $create_wrksrc variable is
no longer relevant, and do-clean will always work probably instead of
leaving some trash behind like before.
---
Competing with #33006, the idea is his, anyway.
[ci skip]
prev parent reply other threads:[~2022-07-06 2:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 14:49 [PR PATCH] " sgn
2021-09-18 14:50 ` [PR PATCH] [Updated] " sgn
2021-09-18 15:06 ` q66
2021-09-18 19:36 ` Chocimier
2021-09-19 10:07 ` [PR PATCH] [Updated] " sgn
2021-09-19 10:13 ` sgn
2021-09-19 10:17 ` sgn
2021-09-19 10:37 ` [PR PATCH] [Updated] " sgn
2021-09-19 11:01 ` sgn
2021-09-19 11:13 ` sgn
2021-09-19 11:17 ` sgn
2021-09-19 11:26 ` [PR PATCH] [Updated] " sgn
2021-09-19 11:29 ` sgn
2021-09-19 11:37 ` sgn
2021-09-19 16:27 ` [PR PATCH] [Updated] " sgn
2021-09-19 16:38 ` sgn
2022-06-22 2:13 ` github-actions
2022-07-06 2:13 ` github-actions [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706021356.DpDslAFSZ1H84Q47_CFxxrRhGfZ_VblU_4B_oLHnd8Q@z \
--to=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).