Github messages for voidlinux
 help / color / mirror / Atom feed
From: mitinarseny <mitinarseny@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: fix(fzf): make neovim plugin optional
Date: Thu, 07 Jul 2022 11:36:29 +0200	[thread overview]
Message-ID: <20220707093629.4ZsT78iFjg53X4-3h6m4MgBQD7OQT0t1vP-sXGNhHEA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37795@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]

New comment by mitinarseny on void-packages repository

https://github.com/void-linux/void-packages/pull/37795#issuecomment-1177317189

Comment:
> Does anything bad happen when the plugin is loaded by default? 

It just should not be loaded unless the user explicitly say that... Imagine installing a bunch of other command-line utilities which has [neo]vim plugin support. But I just want to use them as command-line utilities and not inside neovim. Even if this plugin does not create any mappings, I don't want it to be sourced by default becasue:
* it increases startup time of neovim
* it can contain deprecated or even removed functionality which would cause an error while loading neovim

You can think of it as the same as if packages with `sv` services would be shipped with already symlinked service directories to `/var/service` with `down` file present. I don't want this functionality to be enabled by default

> But it'd be a breaking change for some users and probably confusing if no other distro does this

With this approach we can end up using systemd and other ugly things from distos where end users do not have an opportunity to decide what they want and what they do not.  

  parent reply	other threads:[~2022-07-07  9:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01 20:13 [PR PATCH] " mitinarseny
2022-07-02  0:51 ` sgn
2022-07-02  0:53 ` sgn
2022-07-05 14:15 ` ericonr
2022-07-06  0:00 ` sgn
2022-07-06 22:39 ` atweiden
2022-07-07  9:36 ` mitinarseny [this message]
2022-07-09 22:55 ` atweiden
2022-07-17 20:20 ` ericonr
2022-08-02 21:47 ` atweiden
2022-11-01  2:14 ` github-actions
2022-11-16  2:11 ` [PR PATCH] [Closed]: " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220707093629.4ZsT78iFjg53X4-3h6m4MgBQD7OQT0t1vP-sXGNhHEA@z \
    --to=mitinarseny@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).