[PR PATCH] New package: noise-suppression-for-voice-0.91

[PR PATCH] New package: noise-suppression-for-voice-0.91

[mustaqimM]

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]

There is a new pull request by mustaqimM against master on the void-packages repository

https://github.com/mustaqimM/void-packages new_package_noise-suppression-for-voice
https://github.com/void-linux/void-packages/pull/36491

New package: noise-suppression-for-voice-0.91
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, `(x86_64-glibc)`
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36491.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_package_noise-suppression-for-voice-36491.patch --]
[-- Type: text/x-diff, Size: 1186 bytes --]

From f99b0294e5f8bf5a723ddf95c00c06acf051cf7f Mon Sep 17 00:00:00 2001
From: mustaqim <git@mustaqim.ml>
Date: Sun, 3 Apr 2022 08:09:37 +0200
Subject: [PATCH] New package: noise-suppression-for-voice-0.91

---
 srcpkgs/noise-suppression-for-voice/template | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 srcpkgs/noise-suppression-for-voice/template

diff --git a/srcpkgs/noise-suppression-for-voice/template b/srcpkgs/noise-suppression-for-voice/template
new file mode 100644
index 000000000000..de9cc7ac50de
--- /dev/null
+++ b/srcpkgs/noise-suppression-for-voice/template
@@ -0,0 +1,12 @@
+# Template file for 'noise-suppression-for-voice'
+pkgname=noise-suppression-for-voice
+version=0.91
+revision=1
+build_style=cmake
+configure_args="-DBUILD_LV2_PLUGIN=OFF -DBUILD_VST_PLUGIN=OFF -DBUILD_LADSPA_PLUGIN=ON"
+short_desc="Noise suppression plugin based on Xiph's RNNoise"
+maintainer="mustaqim <git@mustaqim.ml>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/werman/noise-suppression-for-voice"
+distfiles="https://github.com/werman/${pkgname}/archive/v${version}.tar.gz"
+checksum=4f3a112534d4abb5ee2b6c328cde89193dbdb2146cffc98505972c3b5397a35e

Re: New package: noise-suppression-for-voice-0.91

[prez]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by prez on void-packages repository

https://github.com/void-linux/void-packages/pull/36491#issuecomment-1090853320

Comment:
>`DBUILD_LV2_PLUGIN=OFF`

very questionable decision. I'd argue LV2 is what you want to have, the others are optional.

Re: New package: noise-suppression-for-voice-0.91

[mustaqimM]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by mustaqimM on void-packages repository

https://github.com/void-linux/void-packages/pull/36491#issuecomment-1091856157

Comment:
Well, that's up for discussion. I only kept LADSPA enabled since it can be used system-wide through a pipewire/pulse sink

Re: New package: noise-suppression-for-voice-0.91

[prez]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

New comment by prez on void-packages repository

https://github.com/void-linux/void-packages/pull/36491#issuecomment-1091998384

Comment:
> Well, that's up for discussion. I only kept LADSPA enabled since it can be used system-wide through a pipewire/pulse sink

The same goes for LV2. I suggest building LV2 only for now. 

Re: New package: noise-suppression-for-voice-0.91

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/36491#issuecomment-1176964689

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: New package: noise-suppression-for-voice-0.91

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/36491#issuecomment-1178436678

Comment:
I think this one is worth keeping open.

Re: New package: noise-suppression-for-voice-0.91

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]

New comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/36491#issuecomment-1236708557

Comment:
@mustaqimM Could this be bumped to [v1.03](https://github.com/werman/noise-suppression-for-voice/releases/tag/v1.03)?

> The same goes for LV2. I suggest building LV2 only for now.

@prez Why not both? I'm using this as a PipeWire LADSPA plugin as [documented on the README](https://github.com/werman/noise-suppression-for-voice#pipewire) and just tried to make it use the LV2 plugin but was unsuccessful.

I checked `lv2ls` (from `lilv`) and this could be problematic:
```
$ lv2ls
lilv_world_add_plugin(): warning: Duplicate plugin <https://github.com/werman/noise-suppression-for-voice>
lilv_world_add_plugin(): warning: ... found in file:///usr/lib64/lv2/rnnoise_stereo.lv2/
lilv_world_add_plugin(): warning: ... and      file:///usr/lib64/lv2/rnnoise_mono.lv2/ (ignored)
...
https://github.com/werman/noise-suppression-for-voice
```
Considering the README itself mentions `It also would consume 2x resources` with regards to using the `stereo` plugin as compared to the `mono` one (which I know my microphone only is mono channel).

https://docs.pipewire.org/page_module_filter_chain.html mentions `For LV2, this is the plugin URI obtained with lv2ls` but I couldn't get it working. I'm very much a newbie when it comes to PipeWire configuration so if someone has a working LV2 `mono` plugin config I wouldn't mind LADSPA wasn't present in this package; I just want a working configuration with the `mono` plugin that's all.

Re: New package: noise-suppression-for-voice-0.91

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/36491#issuecomment-1336624338

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: New package: noise-suppression-for-voice-0.91

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

New comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/36491#issuecomment-1336635479

Comment:
My last comment is still relevant, I'm also still using this daily for so it would be rather great to have this in the repos, other alternative voice suppression solutions that I could instead add to my PipeWire setup would also be welcome.

Re: New package: noise-suppression-for-voice-0.91

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

New comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/36491#issuecomment-1336635479

Comment:
My last comment is still relevant, I'm also still using this daily so it would be rather great to have this in the repos, other alternative voice suppression solutions that I could instead add to my PipeWire setup would also be welcome.

Re: [PR REVIEW] New package: noise-suppression-for-voice-0.91

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/36491#discussion_r1039087259

Comment:
https://github.com/werman/noise-suppression-for-voice/releases/tag/v1.03

Re: [PR PATCH] [Updated] New package: noise-suppression-for-voice-0.91

[mustaqimM]

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

There is an updated pull request by mustaqimM against master on the void-packages repository

https://github.com/mustaqimM/void-packages new_package_noise-suppression-for-voice
https://github.com/void-linux/void-packages/pull/36491

New package: noise-suppression-for-voice-0.91
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, `(x86_64-glibc)`
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36491.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_package_noise-suppression-for-voice-36491.patch --]
[-- Type: text/x-diff, Size: 1329 bytes --]

From 89b14c939afd69be8dbd709e5d07c8803a566b99 Mon Sep 17 00:00:00 2001
From: mustaqim <git@mustaqim.ml>
Date: Sun, 3 Apr 2022 08:09:37 +0200
Subject: [PATCH] New package: noise-suppression-for-voice-1.03

---
 srcpkgs/noise-suppression-for-voice/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/noise-suppression-for-voice/template

diff --git a/srcpkgs/noise-suppression-for-voice/template b/srcpkgs/noise-suppression-for-voice/template
new file mode 100644
index 000000000000..4710a9f40f56
--- /dev/null
+++ b/srcpkgs/noise-suppression-for-voice/template
@@ -0,0 +1,14 @@
+# Template file for 'noise-suppression-for-voice'
+pkgname=noise-suppression-for-voice
+version=1.03
+revision=1
+build_style=cmake
+configure_args="-DBUILD_LV2_PLUGIN=OFF -DBUILD_VST_PLUGIN=OFF -DBUILD_LADSPA_PLUGIN=ON"
+hostmakedepends="pkg-config"
+makedepends="alsa-lib-devel freetype-devel libcurl-devel webkit2gtk-devel libatomic-devel libsanitizer-devel"
+short_desc="Noise suppression plugin based on Xiph's RNNoise"
+maintainer="mustaqim <git@mustaqim.ml>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/werman/noise-suppression-for-voice"
+distfiles="https://github.com/werman/${pkgname}/archive/v${version}.tar.gz"
+checksum=8c85cae3ebbb3a18facc38930a3b67ca90e3ad609526a0018c71690de35baf04

Re: New package: noise-suppression-for-voice-0.91

[mustaqimM]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

New comment by mustaqimM on void-packages repository

https://github.com/void-linux/void-packages/pull/36491#issuecomment-1336708704

Comment:
@JamiKettunen I had to add `libsanitizer-devel` for it to build the new version, but now it's failing for other arches. I don't have time to see what's up, so if someone wants to take over, please do so. 
Also I set the flag `-DBUILD_VST_PLUGIN=OFF` but in the new version, it still builds it and adds it to `/usr/lib/vst3/rnnoise.vst3/Contents/x86_64-linux/rnnoise.so`

Re: [PR PATCH] [Closed]: New package: noise-suppression-for-voice-0.91

[mustaqimM]

[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]

There's a closed pull request on the void-packages repository

New package: noise-suppression-for-voice-0.91
https://github.com/void-linux/void-packages/pull/36491

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, `(x86_64-glibc)`
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Re: New package: noise-suppression-for-voice-0.91

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/37198#issuecomment-1236686064

Comment:
Duplicate of #36491.

Re: New package: noise-suppression-for-voice-0.91

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/37198#issuecomment-1234991104

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.