From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New Package: walld-1.4.1
Date: Mon, 11 Jul 2022 22:46:43 +0200 [thread overview]
Message-ID: <20220711204643.npFRkVryOQzRplh_36BgVqS9N2sukwBZE565XPCSWAE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37933@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/37933#discussion_r918335923
Comment:
Why did you just delete part of the program? Fix it properly and apply the fix upstream.
```
../src/main.c:163:8: error: assignment of read-only variable 'stdin'
163 | stdin = fopen("/dev/null", "r");
| ^
../src/main.c:164:9: error: assignment of read-only variable 'stdout'
164 | stdout = fopen(log_file, "w");
| ^
../src/main.c:185:9: error: assignment of read-only variable 'stderr'
185 | stderr = fopen(err_log_file, "w");
| ^
```
next prev parent reply other threads:[~2022-07-11 20:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 4:14 [PR PATCH] " Dotz0cat
2022-07-09 4:17 ` [PR REVIEW] " classabbyamp
2022-07-09 4:17 ` classabbyamp
2022-07-09 4:17 ` classabbyamp
2022-07-09 4:34 ` Dotz0cat
2022-07-09 4:37 ` [PR PATCH] [Updated] " Dotz0cat
2022-07-09 8:50 ` [PR REVIEW] " paper42
2022-07-10 0:30 ` [PR PATCH] [Updated] " Dotz0cat
2022-07-10 0:32 ` Dotz0cat
2022-07-10 0:36 ` [PR REVIEW] " Dotz0cat
2022-07-11 20:46 ` paper42
2022-07-11 20:46 ` paper42
2022-07-11 20:46 ` paper42 [this message]
2022-07-11 20:59 ` paper42
2022-08-13 17:28 ` [PR PATCH] [Updated] " Dotz0cat
2022-08-13 18:09 ` Dotz0cat
2022-11-12 2:11 ` github-actions
2022-11-27 2:08 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220711204643.npFRkVryOQzRplh_36BgVqS9N2sukwBZE565XPCSWAE@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).