From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Add gnupg-smartcard-udev-rules and add INSTALL.msg to gnupg2-scdaemon.
Date: Wed, 13 Jul 2022 17:28:05 +0200 [thread overview]
Message-ID: <20220713152805.0JlitWPvESR86cyAr2WNjtdaXHwUe4_lfyYlR6cowdg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38037@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/38037#issuecomment-1183368115
Comment:
Adding a second distfile shouldn't be terribly complicated, but since you're rewriting all of the lines anyway and `sed` (or even `vsed`) could potentially break the udev rule in subtle ways, maintaining our own known-good version seems reasonable and simplifies packaging. (If you don't maintain a copy in `$FILESDIR`, I'd advocate for a proper patch so that we can detect major structural changes in the file anyway, but the patch would be about twice as large as just carrying forward our own file.)
next prev parent reply other threads:[~2022-07-13 15:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 12:03 [PR PATCH] New package: gnupg-smartcard-udev-rules-0.0.20220713 jcgruenhage
2022-07-13 12:04 ` [PR PATCH] [Updated] " jcgruenhage
2022-07-13 12:09 ` jcgruenhage
2022-07-13 12:09 ` [PR REVIEW] " jcgruenhage
2022-07-13 14:30 ` [PR PATCH] [Updated] " jcgruenhage
2022-07-13 15:15 ` Add gnupg-smartcard-udev-rules and add INSTALL.msg to gnupg2-scdaemon jcgruenhage
2022-07-13 15:18 ` jcgruenhage
2022-07-13 15:28 ` ahesford [this message]
2022-07-13 15:45 ` 0x5c
2022-07-13 16:03 ` [PR PATCH] [Updated] " jcgruenhage
2022-07-13 16:09 ` [PR PATCH] [Updated] Add udev rules and " jcgruenhage
2022-07-13 16:38 ` [PR REVIEW] " classabbyamp
2022-07-13 16:39 ` classabbyamp
2022-07-13 16:58 ` jcgruenhage
2022-07-13 16:59 ` classabbyamp
2022-07-13 17:00 ` [PR PATCH] [Updated] " jcgruenhage
2022-07-13 17:05 ` jcgruenhage
2022-07-13 17:13 ` 0x5c
2022-07-13 17:15 ` [PR PATCH] [Merged]: " classabbyamp
2022-07-13 17:19 ` 0x5c
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713152805.0JlitWPvESR86cyAr2WNjtdaXHwUe4_lfyYlR6cowdg@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).