From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] python3-shodan: update to 1.28.0.
Date: Sun, 17 Jul 2022 22:36:11 +0200 [thread overview]
Message-ID: <20220717203611.DqTMAkUeMTlzId19jre_EK0SH4RDUj8-ev90QCEmg9I@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38112@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 422 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/38112#discussion_r922892610
Comment:
It probably expects the comment next to $make_check or above it. @ericonr do you think `no` or `extended` makes more sense here? afaik we usually use extended for tests that take too long, not for tests that can't run without manually modifying the template to include a key.
next prev parent reply other threads:[~2022-07-17 20:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-17 17:09 [PR PATCH] " HadetTheUndying
2022-07-17 17:12 ` [PR REVIEW] " paper42
2022-07-17 17:56 ` HadetTheUndying
2022-07-17 20:36 ` paper42 [this message]
2022-07-20 19:57 ` HadetTheUndying
2022-07-20 20:10 ` paper42
2022-07-20 20:10 ` paper42
2022-07-20 20:14 ` HadetTheUndying
2022-07-20 20:16 ` paper42
2022-07-20 20:34 ` [PR PATCH] [Updated] " HadetTheUndying
2022-07-21 3:24 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220717203611.DqTMAkUeMTlzId19jre_EK0SH4RDUj8-ev90QCEmg9I@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).