From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] python3-text-unidecode: update to 1.3
Date: Mon, 18 Jul 2022 20:15:47 +0200 [thread overview]
Message-ID: <20220718181547.6z_Oh3WA0FC29X8lJp-B_eEMvRIe4cpkPnJXWqlEi24@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38131@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/38131#discussion_r923682865
Comment:
I am not sure what you mean, $depends are often autodetected from the ELF header, but python packages are just scripts that obviously don't have ELF headers.
Python packages often include depends="python3-something" which depends on python3 transitively, so python3 doesn't need to be explicitly mentioned.
A few months ago I went over all python packages that were missing the python3 dependency and added it. You can check dependencies of the resulting package with xbps-query -x or a diff from the last version with xpkgdiff -x or in the CI (which runs xpkgdiff).
next prev parent reply other threads:[~2022-07-18 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 14:58 [PR PATCH] " tranzystorek-io
2022-07-18 18:06 ` [PR REVIEW] " paper42
2022-07-18 18:08 ` tranzystorek-io
2022-07-18 18:15 ` paper42 [this message]
2022-07-18 18:16 ` paper42
2022-07-18 18:16 ` paper42
2022-07-18 18:20 ` tranzystorek-io
2022-07-18 18:24 ` [PR PATCH] [Updated] " tranzystorek-io
2022-07-18 18:37 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718181547.6z_Oh3WA0FC29X8lJp-B_eEMvRIe4cpkPnJXWqlEi24@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).