New review comment by TinfoilSubmarine on void-packages repository https://github.com/void-linux/void-packages/pull/37949#discussion_r924478188 Comment: I would rather not have a regex running directly in the template because it is harder to understand what is happening (at least for me :/ )... Could we just include a patch with the result of this regex instead? You could include this shell-fu as a comment at the top so it's easy to update if there was ever a new manpage that needed to be fixed. ``` Fix .so links in man pages This is needed because of the configure option - --program-suffix=${_php_version} _regexp='^[[:space:]]*\.so[[:space:]]' _php_version=8.1 for file in $(grep -l -e "$_regexp" -R .); do sed --debug -i "$file" -e "/$_regexp/"'s=^[[:space:]]*\.[^.]*=&'${_php_version}= done diff --git a/ext/phar/phar.phar.1.in b/ext/phar/phar.phar.1.in index b5eecbfe..5852619e 100644 --- a/ext/phar/phar.phar.1.in +++ b/ext/phar/phar.phar.1.in @@ -1 +1 @@ -.so man1/phar.1 +.so man1/phar8.1.1 diff --git a/sapi/cgi/php-cgi.1.in b/sapi/cgi/php-cgi.1.in index 340e6c5d..8b39d023 100644 --- a/sapi/cgi/php-cgi.1.in +++ b/sapi/cgi/php-cgi.1.in @@ -1 +1 @@ -.so man1/php.1 +.so man1/php8.1.1 ```