Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: rustup: generate shell completions for cargo
Date: Wed, 20 Jul 2022 17:27:56 +0200	[thread overview]
Message-ID: <20220720152756.nLgKV7UuiQm9Dt9x2vLgFaGn7ith1-MdHCoJFcN-awk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35768@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/35768#issuecomment-1190429836

Comment:
Unless I'm misunderstanding things, I'm opposed to the subpackage or attempting to manage cargo completions in the rustup package. The whole point of rustup is to fetch one or more versions of the rust toolchain, including cargo, into a local (per-user) environment. We shouldn't be shipping completions for commands that aren't provided expliclty by the package. The completions aren't even guaranteed to be right if the cargo command syntax changes from one version of cargo to the next.

People using rustup can just as easily invoke `rustup completions <shell> cargo` in their shells. There's no reason to do that here.

  parent reply	other threads:[~2022-07-20 15:27 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 11:28 [PR PATCH] " tranzystorek-io
2022-02-22 17:00 ` Duncaen
2022-02-22 17:59 ` tranzystorek-io
2022-02-23  5:37 ` [PR PATCH] [Updated] " tranzystorek-io
2022-02-27 13:40 ` tranzystorek-io
2022-03-04 15:28 ` tranzystorek-io
2022-03-08 13:49 ` [PR PATCH] [Updated] " tranzystorek-io
2022-03-08 14:21 ` Duncaen
2022-03-08 15:26 ` tranzystorek-io
2022-03-08 16:15 ` Duncaen
2022-03-08 16:23 ` Duncaen
2022-03-08 16:47 ` tranzystorek-io
2022-06-28  2:15 ` [WIP] " github-actions
2022-06-28  5:06 ` [PR PATCH] [Updated] " tranzystorek-io
2022-06-28  5:22 ` tranzystorek-io
2022-07-15  6:00 ` [PR PATCH] [Updated] " tranzystorek-io
2022-07-15  6:31 ` tranzystorek-io
2022-07-15  6:46 ` tranzystorek-io
2022-07-15 10:40 ` jcgruenhage
2022-07-17 20:57 ` CameronNemo
2022-07-17 21:14 ` CameronNemo
2022-07-17 21:14 ` CameronNemo
2022-07-18  7:15 ` jcgruenhage
2022-07-18 22:29 ` [PR PATCH] [Updated] " tranzystorek-io
2022-07-20 15:27 ` ahesford [this message]
2022-07-20 15:34 ` Duncaen
2022-07-20 16:48 ` ahesford
2022-07-20 16:48 ` ahesford
2022-10-19  2:14 ` github-actions
2022-10-19 18:13 ` tranzystorek-io
2022-10-19 18:13 ` [PR PATCH] [Closed]: " tranzystorek-io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220720152756.nLgKV7UuiQm9Dt9x2vLgFaGn7ith1-MdHCoJFcN-awk@z \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).