Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] pipewire: add autostart .desktop files
@ 2022-07-03 21:53 paper42
  2022-07-04 13:21 ` paper42
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: paper42 @ 2022-07-03 21:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pipewire-autostart-desktop
https://github.com/void-linux/void-packages/pull/37822

pipewire: add autostart .desktop files
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO** (I have been using these files on my system, but not when symlinked from docs yet)

@st3r4g

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37822.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-autostart-desktop-37822.patch --]
[-- Type: text/x-diff, Size: 1893 bytes --]

From fb0157d07c099665441d9a0b9de5123cafa72a71 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 3 Jul 2022 23:41:12 +0200
Subject: [PATCH] pipewire: add autostart .desktop files

---
 srcpkgs/pipewire/files/pipewire-pulse.desktop | 8 ++++++++
 srcpkgs/pipewire/files/pipewire.desktop       | 8 ++++++++
 srcpkgs/pipewire/template                     | 4 +++-
 3 files changed, 19 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/pipewire/files/pipewire-pulse.desktop
 create mode 100644 srcpkgs/pipewire/files/pipewire.desktop

diff --git a/srcpkgs/pipewire/files/pipewire-pulse.desktop b/srcpkgs/pipewire/files/pipewire-pulse.desktop
new file mode 100644
index 000000000000..e869d5452b89
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire-pulse.desktop
@@ -0,0 +1,8 @@
+[Desktop Entry]
+Name=PipeWire pulse
+Comment=Start the PipeWire pulse server
+Icon=pipewire-pulse
+Exec=pipewire-pulse
+Terminal=false
+Type=Application
+NoDisplay=true
diff --git a/srcpkgs/pipewire/files/pipewire.desktop b/srcpkgs/pipewire/files/pipewire.desktop
new file mode 100644
index 000000000000..027bd5e4a7b4
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire.desktop
@@ -0,0 +1,8 @@
+[Desktop Entry]
+Name=PipeWire
+Comment=Start PipeWire
+Icon=pipewire
+Exec=pipewire
+Terminal=false
+Type=Application
+NoDisplay=true
diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 92d7b65434a9..d5391166f0f8 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,7 +1,7 @@
 # Template file for 'pipewire'
 pkgname=pipewire
 version=0.3.52
-revision=1
+revision=2
 _pms_version=0.4.1
 build_style=meson
 configure_args="
@@ -63,6 +63,8 @@ post_install() {
 	vdoc "${FILESDIR}/README.voidlinux"
 	vsv pipewire
 	vsv pipewire-pulse
+	vdoc "${FILESDIR}/pipewire.desktop"
+	vdoc "${FILESDIR}/pipewire-pulse.desktop"
 }
 
 libpipewire_package() {

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: pipewire: add autostart .desktop files
  2022-07-03 21:53 [PR PATCH] pipewire: add autostart .desktop files paper42
@ 2022-07-04 13:21 ` paper42
  2022-07-04 22:29 ` [PR REVIEW] " st3r4g
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-07-04 13:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37822#issuecomment-1173816292

Comment:
similar to #35171 by @felix, but this PR requires explicitly symlinking the .desktop files

cc @teldra

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] pipewire: add autostart .desktop files
  2022-07-03 21:53 [PR PATCH] pipewire: add autostart .desktop files paper42
  2022-07-04 13:21 ` paper42
@ 2022-07-04 22:29 ` st3r4g
  2022-07-17 21:59 ` [PR PATCH] [Updated] " paper42
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: st3r4g @ 2022-07-04 22:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/37822#discussion_r913283831

Comment:
why `vdoc` instead of `/usr/share/applications`?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] pipewire: add autostart .desktop files
  2022-07-03 21:53 [PR PATCH] pipewire: add autostart .desktop files paper42
  2022-07-04 13:21 ` paper42
  2022-07-04 22:29 ` [PR REVIEW] " st3r4g
@ 2022-07-17 21:59 ` paper42
  2022-07-17 21:59 ` [PR REVIEW] " paper42
  2022-07-20 21:35 ` [PR PATCH] [Merged]: " paper42
  4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-07-17 21:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pipewire-autostart-desktop
https://github.com/void-linux/void-packages/pull/37822

pipewire: add autostart .desktop files
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO** (I have been using these files on my system, but not when symlinked from docs yet)

@st3r4g

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37822.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-autostart-desktop-37822.patch --]
[-- Type: text/x-diff, Size: 2030 bytes --]

From bb77c9afa25a42a4c90f04d5d412843a44a4e6b4 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 3 Jul 2022 23:41:12 +0200
Subject: [PATCH] pipewire: add autostart .desktop files

---
 srcpkgs/pipewire/files/pipewire-pulse.desktop | 8 ++++++++
 srcpkgs/pipewire/files/pipewire.desktop       | 8 ++++++++
 srcpkgs/pipewire/template                     | 5 ++++-
 3 files changed, 20 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/pipewire/files/pipewire-pulse.desktop
 create mode 100644 srcpkgs/pipewire/files/pipewire.desktop

diff --git a/srcpkgs/pipewire/files/pipewire-pulse.desktop b/srcpkgs/pipewire/files/pipewire-pulse.desktop
new file mode 100644
index 000000000000..e869d5452b89
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire-pulse.desktop
@@ -0,0 +1,8 @@
+[Desktop Entry]
+Name=PipeWire pulse
+Comment=Start the PipeWire pulse server
+Icon=pipewire-pulse
+Exec=pipewire-pulse
+Terminal=false
+Type=Application
+NoDisplay=true
diff --git a/srcpkgs/pipewire/files/pipewire.desktop b/srcpkgs/pipewire/files/pipewire.desktop
new file mode 100644
index 000000000000..027bd5e4a7b4
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire.desktop
@@ -0,0 +1,8 @@
+[Desktop Entry]
+Name=PipeWire
+Comment=Start PipeWire
+Icon=pipewire
+Exec=pipewire
+Terminal=false
+Type=Application
+NoDisplay=true
diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index e9ff4af833ab..ab461f99111e 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,7 +1,7 @@
 # Template file for 'pipewire'
 pkgname=pipewire
 version=0.3.55
-revision=1
+revision=2
 _pms_version=0.4.1
 build_style=meson
 configure_args="
@@ -63,6 +63,9 @@ post_install() {
 	vdoc "${FILESDIR}/README.voidlinux"
 	vsv pipewire
 	vsv pipewire-pulse
+	vmkdir usr/share/applications
+	cp "${FILESDIR}/pipewire.desktop" ${DESTDIR}/usr/share/applications/pipewire.desktop
+	cp "${FILESDIR}/pipewire-pulse.desktop" ${DESTDIR}/usr/share/applications/pipewire-pulse.desktop
 }
 
 libpipewire_package() {

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] pipewire: add autostart .desktop files
  2022-07-03 21:53 [PR PATCH] pipewire: add autostart .desktop files paper42
                   ` (2 preceding siblings ...)
  2022-07-17 21:59 ` [PR PATCH] [Updated] " paper42
@ 2022-07-17 21:59 ` paper42
  2022-07-20 21:35 ` [PR PATCH] [Merged]: " paper42
  4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-07-17 21:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37822#discussion_r922900765

Comment:
I thought it would show up in menus, but NoDisplay prevents that. I moved it to /usr/share/applications now, thanks!

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: pipewire: add autostart .desktop files
  2022-07-03 21:53 [PR PATCH] pipewire: add autostart .desktop files paper42
                   ` (3 preceding siblings ...)
  2022-07-17 21:59 ` [PR REVIEW] " paper42
@ 2022-07-20 21:35 ` paper42
  4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-07-20 21:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

There's a merged pull request on the void-packages repository

pipewire: add autostart .desktop files
https://github.com/void-linux/void-packages/pull/37822

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO** (I have been using these files on my system, but not when symlinked from docs yet)

@st3r4g

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-07-20 21:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-03 21:53 [PR PATCH] pipewire: add autostart .desktop files paper42
2022-07-04 13:21 ` paper42
2022-07-04 22:29 ` [PR REVIEW] " st3r4g
2022-07-17 21:59 ` [PR PATCH] [Updated] " paper42
2022-07-17 21:59 ` [PR REVIEW] " paper42
2022-07-20 21:35 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).