[PR PATCH] python3-shodan: update to 1.28.0.

[PR PATCH] python3-shodan: update to 1.28.0.

[HadetTheUndying]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

There is a new pull request by HadetTheUndying against master on the void-packages repository

https://github.com/HadetTheUndying/void-packages shodan-update
https://github.com/void-linux/void-packages/pull/38112

python3-shodan: update to 1.28.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/38112.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-shodan-update-38112.patch --]
[-- Type: text/x-diff, Size: 1191 bytes --]

From bfbfb06c191113ff01f9d6d25cfebbf6c7f4744a Mon Sep 17 00:00:00 2001
From: HadetTheUndying <hadet@protonmail.com>
Date: Sun, 17 Jul 2022 12:08:00 -0500
Subject: [PATCH] python3-shodan: update to 1.28.0.

---
 srcpkgs/python3-shodan/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-shodan/template b/srcpkgs/python3-shodan/template
index 34dbb28be2be..034def311636 100644
--- a/srcpkgs/python3-shodan/template
+++ b/srcpkgs/python3-shodan/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-shodan'
 pkgname=python3-shodan
-version=1.25.0
-revision=2
+version=1.28.0
+revision=1
 wrksrc="shodan-python-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -13,7 +13,7 @@ maintainer="Alex Childs <misuchiru03+void@gmail.com>"
 license="MIT"
 homepage="https://developer.shodan.io"
 distfiles="https://github.com/achillean/shodan-python/archive/${version}.tar.gz"
-checksum=52932c6d508622877d0667e0290fee84e6cb749b6565b48ba359fbbf002f0845
+checksum=fc5f159f3edb6db0c2fff338b62f8a6c6eb63b12983bf729a4121fa30019753b
 make_check=extended
 # One must export the variable SHODAN-API-KEY in env before running tests
 

Re: [PR REVIEW] python3-shodan: update to 1.28.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38112#discussion_r922870991

Comment:
that should be =no I think

Re: [PR REVIEW] python3-shodan: update to 1.28.0.

[HadetTheUndying]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New review comment by HadetTheUndying on void-packages repository

https://github.com/void-linux/void-packages/pull/38112#discussion_r922875673

Comment:
On the `make_check`? Because GitHub highlighted the checksum line(16) for me.

Re: [PR REVIEW] python3-shodan: update to 1.28.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38112#discussion_r922892610

Comment:
It probably expects the comment next to $make_check or above it. @ericonr do you think `no` or `extended` makes more sense here? afaik we usually use extended for tests that take too long, not for tests that can't run without manually modifying the template to include a key.

Re: python3-shodan: update to 1.28.0.

[HadetTheUndying]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New comment by HadetTheUndying on void-packages repository

https://github.com/void-linux/void-packages/pull/38112#issuecomment-1190696346

Comment:
This is pretty much ready to go as soon as it's decided what to do with the `make_check` I've tested this pretty extensively this week

Re: python3-shodan: update to 1.28.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38112#issuecomment-1190708367

Comment:
> This is pretty much ready to go as soon as it's decided what to do with the `make_check` I've tested this pretty extensively this week

+ you need to fix lint

Re: python3-shodan: update to 1.28.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38112#issuecomment-1190708367

Comment:
> This is pretty much ready to go as soon as it's decided what to do with the `make_check` I've tested this pretty extensively this week

\+ you need to fix lint

Re: python3-shodan: update to 1.28.0.

[HadetTheUndying]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

New comment by HadetTheUndying on void-packages repository

https://github.com/void-linux/void-packages/pull/38112#issuecomment-1190711531

Comment:
> > This is pretty much ready to go as soon as it's decided what to do with the `make_check` I've tested this pretty extensively this week
> 
> + you need to fix lint

As far as I know all that needs to be done there is explaining what the make_check is required for correct?

Re: python3-shodan: update to 1.28.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38112#issuecomment-1190714126

Comment:
> > \+ you need to fix lint
> 
> As far as I know all that needs to be done there is explaining what the make_check is required for correct?

Just move the existing comment: https://github.com/void-linux/void-packages/pull/38112#discussion_r922892610

Re: [PR PATCH] [Updated] python3-shodan: update to 1.28.0.

[HadetTheUndying]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

There is an updated pull request by HadetTheUndying against master on the void-packages repository

https://github.com/HadetTheUndying/void-packages shodan-update
https://github.com/void-linux/void-packages/pull/38112

python3-shodan: update to 1.28.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/38112.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-shodan-update-38112.patch --]
[-- Type: text/x-diff, Size: 1354 bytes --]

From 3a1810c16dd2dedf30e6a8c7e7f00142ba52c7fc Mon Sep 17 00:00:00 2001
From: HadetTheUndying <hadet@protonmail.com>
Date: Sun, 17 Jul 2022 12:08:00 -0500
Subject: [PATCH] python3-shodan: update to 1.28.0.

move comment to be squashed
---
 srcpkgs/python3-shodan/template | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-shodan/template b/srcpkgs/python3-shodan/template
index 34dbb28be2be..ca8653d9b4d1 100644
--- a/srcpkgs/python3-shodan/template
+++ b/srcpkgs/python3-shodan/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-shodan'
 pkgname=python3-shodan
-version=1.25.0
-revision=2
+version=1.28.0
+revision=1
 wrksrc="shodan-python-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -13,9 +13,8 @@ maintainer="Alex Childs <misuchiru03+void@gmail.com>"
 license="MIT"
 homepage="https://developer.shodan.io"
 distfiles="https://github.com/achillean/shodan-python/archive/${version}.tar.gz"
-checksum=52932c6d508622877d0667e0290fee84e6cb749b6565b48ba359fbbf002f0845
-make_check=extended
-# One must export the variable SHODAN-API-KEY in env before running tests
+checksum=fc5f159f3edb6db0c2fff338b62f8a6c6eb63b12983bf729a4121fa30019753b
+make_check=extended # One must export the variable SHODAN-API-KEY in env before running tests
 
 post_install() {
 	vlicense LICENSE

Re: [PR PATCH] [Merged]: python3-shodan: update to 1.28.0.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

There's a merged pull request on the void-packages repository

python3-shodan: update to 1.28.0.
https://github.com/void-linux/void-packages/pull/38112

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)