Github messages for voidlinux
 help / color / mirror / Atom feed
From: jcgruenhage <jcgruenhage@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] python3-jsonschema: update to 4.7.2.
Date: Thu, 21 Jul 2022 12:13:52 +0200	[thread overview]
Message-ID: <20220721101352.cR8iJKuHdGa5qbeRGC3jHW2DQwMbthG4RHkcrel-HVs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38172@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/38172#discussion_r926503671

Comment:
I've seen it a few times, not sure if it's enough to call it common but I've definitely seen it a few times. Other distros handle this in a similar way, so if we could include it in the build style that'd be great, although I don't feel confident enough in quite a bit of this python stuff, so I'd appreciate it if someone else could look into the check/build-style stuff.

  parent reply	other threads:[~2022-07-21 10:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21  8:36 [PR PATCH] " jcgruenhage
2022-07-21  9:57 ` [PR REVIEW] " paper42
2022-07-21 10:13 ` jcgruenhage [this message]
2022-07-21 10:17 ` jcgruenhage
2022-07-21 10:19 ` jcgruenhage
2022-07-22  5:21 ` classabbyamp
2022-07-22 18:05 ` paper42
2022-07-22 18:05 ` paper42
2022-07-31 20:28 ` jcgruenhage
2022-07-31 21:11 ` [PR PATCH] [Updated] " classabbyamp
2022-07-31 21:11 ` jcgruenhage
2022-08-03 22:58 ` [PR REVIEW] python3-jsonschema: update to 4.9.0 paper42
2022-08-03 22:59 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220721101352.cR8iJKuHdGa5qbeRGC3jHW2DQwMbthG4RHkcrel-HVs@z \
    --to=jcgruenhage@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).