Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: snore-0.2
@ 2022-05-26  9:45 wael444
  2022-05-26  9:46 ` wael444
                   ` (26 more replies)
  0 siblings, 27 replies; 28+ messages in thread
From: wael444 @ 2022-05-26  9:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

There is a new pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages snore
https://github.com/void-linux/void-packages/pull/37299

New package: snore-0.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **NO**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - x86_64-musl
  - aarch64
  - aarch64-musl
  - i686
  - i686-musl
  - armv7l


A patch file from https://github.com/void-linux/void-packages/pull/37299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snore-37299.patch --]
[-- Type: text/x-diff, Size: 985 bytes --]

From a417bb55bbdbbfcbc26f5d06cf8b3c5d52d6080c Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Thu, 26 May 2022 12:39:21 +0300
Subject: [PATCH] New package: snore-0.2

 New package: snore-0.2
---
 srcpkgs/snore/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/snore/template

diff --git a/srcpkgs/snore/template b/srcpkgs/snore/template
new file mode 100644
index 000000000000..435e4537121e
--- /dev/null
+++ b/srcpkgs/snore/template
@@ -0,0 +1,16 @@
+# Template file for 'snore'
+pkgname=snore
+version=0.2
+revision=1
+build_style=gnu-makefile
+short_desc="Sleep with feedback"
+maintainer="wael <40663@protonmail.com>"
+license="MIT"
+homepage="https://github.com/clamiax/snore"
+distfiles="https://github.com/clamiax/${pkgname}/archive/refs/tags/${version}.tar.gz"
+checksum=2b160061589e54b6a88b2995028491b38f9695393bf48af5ad61835fb6fd771a
+CFLAGS="-DVERSION=\\\"${version}\\\""
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
@ 2022-05-26  9:46 ` wael444
  2022-05-26 16:17 ` [PR REVIEW] " Chocimier
                   ` (25 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-05-26  9:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#issuecomment-1138355152

Comment:
Note: i have opened a PR for this package before, i had closed it due to bad commit history which i did not know how to fix back then.

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR REVIEW] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
  2022-05-26  9:46 ` wael444
  2022-05-26 16:17 ` [PR REVIEW] " Chocimier
@ 2022-05-26 16:17 ` Chocimier
  2022-05-26 17:21 ` wael444
                   ` (23 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: Chocimier @ 2022-05-26 16:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#discussion_r882847866

Comment:
install readme too

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR REVIEW] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
  2022-05-26  9:46 ` wael444
@ 2022-05-26 16:17 ` Chocimier
  2022-05-26 16:17 ` Chocimier
                   ` (24 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: Chocimier @ 2022-05-26 16:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#discussion_r882847673

Comment:
please expand pkgname

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR REVIEW] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (2 preceding siblings ...)
  2022-05-26 16:17 ` Chocimier
@ 2022-05-26 17:21 ` wael444
  2022-05-26 17:27 ` [PR PATCH] [Updated] " wael444
                   ` (22 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-05-26 17:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New review comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#discussion_r882903305

Comment:
someone has told me to do this before with an package before, but why does this exactly need to be happened?

expanding pkg name sure, but what about version?

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR PATCH] [Updated] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (3 preceding siblings ...)
  2022-05-26 17:21 ` wael444
@ 2022-05-26 17:27 ` wael444
  2022-05-26 17:41 ` [PR REVIEW] " paper42
                   ` (21 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-05-26 17:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

There is an updated pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages snore
https://github.com/void-linux/void-packages/pull/37299

New package: snore-0.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **NO**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - x86_64-musl
  - aarch64
  - aarch64-musl
  - i686
  - i686-musl
  - armv7l


A patch file from https://github.com/void-linux/void-packages/pull/37299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snore-37299.patch --]
[-- Type: text/x-diff, Size: 977 bytes --]

From 0bf233a18027ca6cbc7ba0078efdbb8f151ca04c Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Thu, 26 May 2022 12:39:21 +0300
Subject: [PATCH] New package: snore-0.2

---
 srcpkgs/snore/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/snore/template

diff --git a/srcpkgs/snore/template b/srcpkgs/snore/template
new file mode 100644
index 000000000000..c7821b70fc11
--- /dev/null
+++ b/srcpkgs/snore/template
@@ -0,0 +1,17 @@
+# Template file for 'snore'
+pkgname=snore
+version=0.2
+revision=1
+build_style=gnu-makefile
+short_desc="Sleep with feedback"
+maintainer="wael <40663@protonmail.com>"
+license="MIT"
+homepage="https://github.com/clamiax/snore"
+distfiles="https://github.com/clamiax/$pkgname/archive/refs/tags/${version}.tar.gz"
+checksum=2b160061589e54b6a88b2995028491b38f9695393bf48af5ad61835fb6fd771a
+CFLAGS="-DVERSION=\\\"${version}\\\""
+
+post_install() {
+	vlicense LICENSE
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR REVIEW] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (4 preceding siblings ...)
  2022-05-26 17:27 ` [PR PATCH] [Updated] " wael444
@ 2022-05-26 17:41 ` paper42
  2022-05-26 17:43 ` wael444
                   ` (20 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: paper42 @ 2022-05-26 17:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#discussion_r882919793

Comment:
$version should still be a variable because it changes with every update. Many maintainers prefer not to have `$pkgname` and other variables in `$distfiles` for various reasons - one is to make grep easier. $pkgname doesn't usually even save many characters and it doesn't change. It's also annoying to replace all $pkgname references in $distfiles when renaming the package for my own purposes.

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR REVIEW] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (5 preceding siblings ...)
  2022-05-26 17:41 ` [PR REVIEW] " paper42
@ 2022-05-26 17:43 ` wael444
  2022-05-26 17:50 ` Chocimier
                   ` (19 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-05-26 17:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New review comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#discussion_r882921374

Comment:
> $pkgname doesn't usually even save many characters and it doesn't change.

so really, `$pkgname` should be used in the distfiles when the actual package name is bigger than `$pkgname`

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR REVIEW] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (6 preceding siblings ...)
  2022-05-26 17:43 ` wael444
@ 2022-05-26 17:50 ` Chocimier
  2022-06-07 11:38 ` [PR PATCH] [Updated] " wael444
                   ` (18 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: Chocimier @ 2022-05-26 17:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#discussion_r882926766

Comment:
> so really, $pkgname should be used in the distfiles when the actual package name is bigger than $pkgname

No, others part of that comment are more important.

The thing is: assume there is already pkgname called `snore` in tree, and you want to add https://github.com/clamiax/snore as a second one. Then you need to use other name, e.g. `snore-a-chaty-sleep`. You wouldn't still set `distfiles="https://github.com/clamiax/${pkgname}/archive/refs/tags/${version}.tar.gz"`, right?

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR PATCH] [Updated] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (7 preceding siblings ...)
  2022-05-26 17:50 ` Chocimier
@ 2022-06-07 11:38 ` wael444
  2022-06-07 11:41 ` wael444
                   ` (17 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-06-07 11:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

There is an updated pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages snore
https://github.com/void-linux/void-packages/pull/37299

New package: snore-0.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **NO**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - x86_64-musl
  - aarch64
  - aarch64-musl
  - i686
  - i686-musl
  - armv7l


A patch file from https://github.com/void-linux/void-packages/pull/37299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snore-37299.patch --]
[-- Type: text/x-diff, Size: 977 bytes --]

From b5ec4d6d5264b0d31c9a3d0a74fd33ff30512926 Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Thu, 26 May 2022 12:39:21 +0300
Subject: [PATCH] New package: snore-0.2

---
 srcpkgs/snore/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/snore/template

diff --git a/srcpkgs/snore/template b/srcpkgs/snore/template
new file mode 100644
index 000000000000..c7821b70fc11
--- /dev/null
+++ b/srcpkgs/snore/template
@@ -0,0 +1,17 @@
+# Template file for 'snore'
+pkgname=snore
+version=0.2
+revision=1
+build_style=gnu-makefile
+short_desc="Sleep with feedback"
+maintainer="wael <40663@protonmail.com>"
+license="MIT"
+homepage="https://github.com/clamiax/snore"
+distfiles="https://github.com/clamiax/$pkgname/archive/refs/tags/${version}.tar.gz"
+checksum=2b160061589e54b6a88b2995028491b38f9695393bf48af5ad61835fb6fd771a
+CFLAGS="-DVERSION=\\\"${version}\\\""
+
+post_install() {
+	vlicense LICENSE
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (8 preceding siblings ...)
  2022-06-07 11:38 ` [PR PATCH] [Updated] " wael444
@ 2022-06-07 11:41 ` wael444
  2022-06-11 22:21 ` classabbyamp
                   ` (16 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-06-07 11:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

New comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#issuecomment-1148552948

Comment:
```
SSL_connect returned 5
ERROR: [reposync] failed to fetch file `https://repo-default.voidlinux.org/current/x86_64-repodata': Operation not permitted
[*] Updating repository `https://repo-default.voidlinux.org/current/x86_64-repodata' ...
Package 'xbps' not found in repository pool.
Error: Process completed with exit code 2.
```
what

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (9 preceding siblings ...)
  2022-06-07 11:41 ` wael444
@ 2022-06-11 22:21 ` classabbyamp
  2022-06-14 16:04 ` [PR PATCH] [Updated] " wael444
                   ` (15 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: classabbyamp @ 2022-06-11 22:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#issuecomment-1153007531

Comment:
just a transient error, next time it can be fixed by force-pushing to trigger CI again

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR PATCH] [Updated] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (10 preceding siblings ...)
  2022-06-11 22:21 ` classabbyamp
@ 2022-06-14 16:04 ` wael444
  2022-06-25  3:08 ` wael444
                   ` (14 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-06-14 16:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

There is an updated pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages snore
https://github.com/void-linux/void-packages/pull/37299

New package: snore-0.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **NO**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - x86_64-musl
  - aarch64
  - aarch64-musl
  - i686
  - i686-musl
  - armv7l


A patch file from https://github.com/void-linux/void-packages/pull/37299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snore-37299.patch --]
[-- Type: text/x-diff, Size: 977 bytes --]

From e051a791f3d23412d0e246085c554e526d9a70e4 Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Thu, 26 May 2022 12:39:21 +0300
Subject: [PATCH] New package: snore-0.2

---
 srcpkgs/snore/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/snore/template

diff --git a/srcpkgs/snore/template b/srcpkgs/snore/template
new file mode 100644
index 000000000000..c7821b70fc11
--- /dev/null
+++ b/srcpkgs/snore/template
@@ -0,0 +1,17 @@
+# Template file for 'snore'
+pkgname=snore
+version=0.2
+revision=1
+build_style=gnu-makefile
+short_desc="Sleep with feedback"
+maintainer="wael <40663@protonmail.com>"
+license="MIT"
+homepage="https://github.com/clamiax/snore"
+distfiles="https://github.com/clamiax/$pkgname/archive/refs/tags/${version}.tar.gz"
+checksum=2b160061589e54b6a88b2995028491b38f9695393bf48af5ad61835fb6fd771a
+CFLAGS="-DVERSION=\\\"${version}\\\""
+
+post_install() {
+	vlicense LICENSE
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR PATCH] [Updated] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (11 preceding siblings ...)
  2022-06-14 16:04 ` [PR PATCH] [Updated] " wael444
@ 2022-06-25  3:08 ` wael444
  2022-06-25  3:21 ` [PR REVIEW] " classabbyamp
                   ` (13 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-06-25  3:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

There is an updated pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages snore
https://github.com/void-linux/void-packages/pull/37299

New package: snore-0.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **NO**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - x86_64-musl
  - aarch64
  - aarch64-musl
  - i686
  - i686-musl
  - armv7l


A patch file from https://github.com/void-linux/void-packages/pull/37299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snore-37299.patch --]
[-- Type: text/x-diff, Size: 977 bytes --]

From b21a850263bb84b4aadd478236b01d37bb9e807b Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Thu, 26 May 2022 12:39:21 +0300
Subject: [PATCH] New package: snore-0.2

---
 srcpkgs/snore/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/snore/template

diff --git a/srcpkgs/snore/template b/srcpkgs/snore/template
new file mode 100644
index 000000000000..c7821b70fc11
--- /dev/null
+++ b/srcpkgs/snore/template
@@ -0,0 +1,17 @@
+# Template file for 'snore'
+pkgname=snore
+version=0.2
+revision=1
+build_style=gnu-makefile
+short_desc="Sleep with feedback"
+maintainer="wael <40663@protonmail.com>"
+license="MIT"
+homepage="https://github.com/clamiax/snore"
+distfiles="https://github.com/clamiax/$pkgname/archive/refs/tags/${version}.tar.gz"
+checksum=2b160061589e54b6a88b2995028491b38f9695393bf48af5ad61835fb6fd771a
+CFLAGS="-DVERSION=\\\"${version}\\\""
+
+post_install() {
+	vlicense LICENSE
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR REVIEW] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (12 preceding siblings ...)
  2022-06-25  3:08 ` wael444
@ 2022-06-25  3:21 ` classabbyamp
  2022-06-25  3:22 ` classabbyamp
                   ` (12 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: classabbyamp @ 2022-06-25  3:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#discussion_r906626354

Comment:
are the quotes really needed here? i'd expect `-DVERSION=0.2` to work fine

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR REVIEW] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (13 preceding siblings ...)
  2022-06-25  3:21 ` [PR REVIEW] " classabbyamp
@ 2022-06-25  3:22 ` classabbyamp
  2022-06-25  3:29 ` wael444
                   ` (11 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: classabbyamp @ 2022-06-25  3:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#discussion_r906626354

Comment:
are the quotes really needed here? i'd expect `-DVERSION=0.2` (the expanded form) to work fine

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR REVIEW] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (14 preceding siblings ...)
  2022-06-25  3:22 ` classabbyamp
@ 2022-06-25  3:29 ` wael444
  2022-06-29 20:30 ` [PR PATCH] [Updated] " wael444
                   ` (10 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-06-25  3:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]

New review comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#discussion_r906626974

Comment:
`CFLAGS="-DVERSION=${version}"` and `CFLAGS="-DVERSION=${version}"` will produce:
```
snore.c: In function 'main':
snore.c:112:15: error: expected ')' before numeric constant
  112 |   die("snore-"VERSION"\n");
      |               ^
      |               )
make: *** [Makefile:20: snore.o] Error 1
=> ERROR: snore-0.2_1: do_build: '${make_cmd} CC="$CC" CXX="$CXX" LD="$LD" AR="$AR" RANLIB="$RANLIB" CPP="$CPP" AS="$AS" OBJCOPY="$OBJCOPY" OBJDUMP="$OBJDUMP" CFLAGS="$CFLAGS" CXXFLAGS="$CXXFLAGS" LDFLAGS="$LDFLAGS" ${makejobs} ${make_build_args} ${make_build_target}' exited with 2
=> ERROR:   in do_build() at common/build-style/gnu-makefile.sh:9
```
i also took this from other templates.

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR PATCH] [Updated] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (15 preceding siblings ...)
  2022-06-25  3:29 ` wael444
@ 2022-06-29 20:30 ` wael444
  2022-07-22 12:47 ` wael444
                   ` (9 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-06-29 20:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

There is an updated pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages snore
https://github.com/void-linux/void-packages/pull/37299

New package: snore-0.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **NO**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - x86_64-musl
  - aarch64
  - aarch64-musl
  - i686
  - i686-musl
  - armv7l


A patch file from https://github.com/void-linux/void-packages/pull/37299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snore-37299.patch --]
[-- Type: text/x-diff, Size: 972 bytes --]

From 296dd921ea4b270cf979d4b7d98f520c9e997bde Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Thu, 26 May 2022 12:39:21 +0300
Subject: [PATCH] New package: snore-0.2

---
 srcpkgs/snore/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/snore/template

diff --git a/srcpkgs/snore/template b/srcpkgs/snore/template
new file mode 100644
index 000000000000..2f59a0b20b74
--- /dev/null
+++ b/srcpkgs/snore/template
@@ -0,0 +1,17 @@
+# Template file for 'snore'
+pkgname=snore
+version=0.2
+revision=1
+build_style=gnu-makefile
+short_desc="Sleep with feedback"
+maintainer="wael <40663@proton.me>"
+license="MIT"
+homepage="https://github.com/clamiax/snore"
+distfiles="https://github.com/clamiax/$pkgname/archive/refs/tags/${version}.tar.gz"
+checksum=2b160061589e54b6a88b2995028491b38f9695393bf48af5ad61835fb6fd771a
+CFLAGS="-DVERSION=\\\"${version}\\\""
+
+post_install() {
+	vlicense LICENSE
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (16 preceding siblings ...)
  2022-06-29 20:30 ` [PR PATCH] [Updated] " wael444
@ 2022-07-22 12:47 ` wael444
  2022-07-22 13:46 ` paper42
                   ` (8 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-07-22 12:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 143 bytes --]

New comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#issuecomment-1192538078

Comment:
?

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (17 preceding siblings ...)
  2022-07-22 12:47 ` wael444
@ 2022-07-22 13:46 ` paper42
  2022-07-22 20:28 ` [PR REVIEW] " wael444
                   ` (7 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: paper42 @ 2022-07-22 13:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 143 bytes --]

New comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#issuecomment-1192538078

Comment:
?

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR REVIEW] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (18 preceding siblings ...)
  2022-07-22 13:46 ` paper42
@ 2022-07-22 20:28 ` wael444
  2022-07-22 21:19 ` classabbyamp
                   ` (6 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-07-22 20:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#discussion_r927968799

Comment:
@Chocimier  ??? i have added it?

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR REVIEW] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (19 preceding siblings ...)
  2022-07-22 20:28 ` [PR REVIEW] " wael444
@ 2022-07-22 21:19 ` classabbyamp
  2022-07-23  9:49 ` wael444
                   ` (5 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: classabbyamp @ 2022-07-22 21:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#discussion_r927994749

Comment:
https://github.com/void-linux/void-packages/pull/37299#discussion_r882847673

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR REVIEW] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (20 preceding siblings ...)
  2022-07-22 21:19 ` classabbyamp
@ 2022-07-23  9:49 ` wael444
  2022-07-23  9:50 ` [PR PATCH] [Updated] " wael444
                   ` (4 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-07-23  9:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New review comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#discussion_r928103910

Comment:
i had the changes there but i forgot to push...

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR PATCH] [Updated] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (21 preceding siblings ...)
  2022-07-23  9:49 ` wael444
@ 2022-07-23  9:50 ` wael444
  2022-07-23  9:51 ` wael444
                   ` (3 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-07-23  9:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

There is an updated pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages snore
https://github.com/void-linux/void-packages/pull/37299

New package: snore-0.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **NO**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - x86_64-musl
  - aarch64
  - aarch64-musl
  - i686
  - i686-musl
  - armv7l


A patch file from https://github.com/void-linux/void-packages/pull/37299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snore-37299.patch --]
[-- Type: text/x-diff, Size: 969 bytes --]

From 42a349e12305408238f4e81bf7ead088b033992b Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Thu, 26 May 2022 12:39:21 +0300
Subject: [PATCH] New package: snore-0.2

---
 srcpkgs/snore/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/snore/template

diff --git a/srcpkgs/snore/template b/srcpkgs/snore/template
new file mode 100644
index 000000000000..2dcf8cc98dba
--- /dev/null
+++ b/srcpkgs/snore/template
@@ -0,0 +1,17 @@
+# Template file for 'snore'
+pkgname=snore
+version=0.2
+revision=1
+build_style=gnu-makefile
+short_desc="Sleep with feedback"
+maintainer="wael <40663@proton.me>"
+license="MIT"
+homepage="https://github.com/clamiax/snore"
+distfiles="https://github.com/clamiax/snore/archive/refs/tags/${version}.tar.gz"
+checksum=2b160061589e54b6a88b2995028491b38f9695393bf48af5ad61835fb6fd771a
+CFLAGS="-DVERSION=\\\"${version}\\\""
+
+post_install() {
+	vlicense LICENSE
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR PATCH] [Updated] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (22 preceding siblings ...)
  2022-07-23  9:50 ` [PR PATCH] [Updated] " wael444
@ 2022-07-23  9:51 ` wael444
  2022-07-23  9:56 ` wael444
                   ` (2 subsequent siblings)
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-07-23  9:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

There is an updated pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages snore
https://github.com/void-linux/void-packages/pull/37299

New package: snore-0.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **NO**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - x86_64-musl
  - aarch64
  - aarch64-musl
  - i686
  - i686-musl
  - armv7l


A patch file from https://github.com/void-linux/void-packages/pull/37299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snore-37299.patch --]
[-- Type: text/x-diff, Size: 969 bytes --]

From 32e82d353f813faeb038f52e409942e844f97d7b Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Thu, 26 May 2022 12:39:21 +0300
Subject: [PATCH] New package: snore-0.2

---
 srcpkgs/snore/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/snore/template

diff --git a/srcpkgs/snore/template b/srcpkgs/snore/template
new file mode 100644
index 000000000000..2dcf8cc98dba
--- /dev/null
+++ b/srcpkgs/snore/template
@@ -0,0 +1,17 @@
+# Template file for 'snore'
+pkgname=snore
+version=0.2
+revision=1
+build_style=gnu-makefile
+short_desc="Sleep with feedback"
+maintainer="wael <40663@proton.me>"
+license="MIT"
+homepage="https://github.com/clamiax/snore"
+distfiles="https://github.com/clamiax/snore/archive/refs/tags/${version}.tar.gz"
+checksum=2b160061589e54b6a88b2995028491b38f9695393bf48af5ad61835fb6fd771a
+CFLAGS="-DVERSION=\\\"${version}\\\""
+
+post_install() {
+	vlicense LICENSE
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR PATCH] [Updated] New package: snore-0.2
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (23 preceding siblings ...)
  2022-07-23  9:51 ` wael444
@ 2022-07-23  9:56 ` wael444
  2022-10-24  2:14 ` New package: snore-0.3.1 github-actions
  2022-11-08  2:13 ` [PR PATCH] [Closed]: " github-actions
  26 siblings, 0 replies; 28+ messages in thread
From: wael444 @ 2022-07-23  9:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

There is an updated pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages snore
https://github.com/void-linux/void-packages/pull/37299

New package: snore-0.2
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **NO**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - x86_64-musl
  - aarch64
  - aarch64-musl
  - i686
  - i686-musl
  - armv7l


A patch file from https://github.com/void-linux/void-packages/pull/37299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snore-37299.patch --]
[-- Type: text/x-diff, Size: 973 bytes --]

From 3c2227f195a8fc0297216661da61dc61c381e940 Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Thu, 26 May 2022 12:39:21 +0300
Subject: [PATCH] New package: snore-0.3.1

---
 srcpkgs/snore/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/snore/template

diff --git a/srcpkgs/snore/template b/srcpkgs/snore/template
new file mode 100644
index 000000000000..6d4a68f9a1e5
--- /dev/null
+++ b/srcpkgs/snore/template
@@ -0,0 +1,17 @@
+# Template file for 'snore'
+pkgname=snore
+version=0.3.1
+revision=1
+build_style=gnu-makefile
+short_desc="Sleep with feedback"
+maintainer="wael <40663@proton.me>"
+license="MIT"
+homepage="https://github.com/clamiax/snore"
+distfiles="https://github.com/clamiax/snore/archive/refs/tags/${version}.tar.gz"
+checksum=a9fbe77e2db3123dbdcc27694944ee73cbbc53cb0652401db03b01087dc69892
+CFLAGS="-DVERSION=\\\"${version}\\\""
+
+post_install() {
+	vlicense LICENSE
+	vdoc README.md
+}

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: New package: snore-0.3.1
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (24 preceding siblings ...)
  2022-07-23  9:56 ` wael444
@ 2022-10-24  2:14 ` github-actions
  2022-11-08  2:13 ` [PR PATCH] [Closed]: " github-actions
  26 siblings, 0 replies; 28+ messages in thread
From: github-actions @ 2022-10-24  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/37299#issuecomment-1288314532

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PR PATCH] [Closed]: New package: snore-0.3.1
  2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
                   ` (25 preceding siblings ...)
  2022-10-24  2:14 ` New package: snore-0.3.1 github-actions
@ 2022-11-08  2:13 ` github-actions
  26 siblings, 0 replies; 28+ messages in thread
From: github-actions @ 2022-11-08  2:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

There's a closed pull request on the void-packages repository

New package: snore-0.3.1
https://github.com/void-linux/void-packages/pull/37299

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **NO**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - x86_64-musl
  - aarch64
  - aarch64-musl
  - i686
  - i686-musl
  - armv7l


^ permalink raw reply	[flat|nested] 28+ messages in thread

end of thread, other threads:[~2022-11-08  2:13 UTC | newest]

Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-26  9:45 [PR PATCH] New package: snore-0.2 wael444
2022-05-26  9:46 ` wael444
2022-05-26 16:17 ` [PR REVIEW] " Chocimier
2022-05-26 16:17 ` Chocimier
2022-05-26 17:21 ` wael444
2022-05-26 17:27 ` [PR PATCH] [Updated] " wael444
2022-05-26 17:41 ` [PR REVIEW] " paper42
2022-05-26 17:43 ` wael444
2022-05-26 17:50 ` Chocimier
2022-06-07 11:38 ` [PR PATCH] [Updated] " wael444
2022-06-07 11:41 ` wael444
2022-06-11 22:21 ` classabbyamp
2022-06-14 16:04 ` [PR PATCH] [Updated] " wael444
2022-06-25  3:08 ` wael444
2022-06-25  3:21 ` [PR REVIEW] " classabbyamp
2022-06-25  3:22 ` classabbyamp
2022-06-25  3:29 ` wael444
2022-06-29 20:30 ` [PR PATCH] [Updated] " wael444
2022-07-22 12:47 ` wael444
2022-07-22 13:46 ` paper42
2022-07-22 20:28 ` [PR REVIEW] " wael444
2022-07-22 21:19 ` classabbyamp
2022-07-23  9:49 ` wael444
2022-07-23  9:50 ` [PR PATCH] [Updated] " wael444
2022-07-23  9:51 ` wael444
2022-07-23  9:56 ` wael444
2022-10-24  2:14 ` New package: snore-0.3.1 github-actions
2022-11-08  2:13 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).