Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] bootchart2: remove systemd service
@ 2022-07-21  2:00 hervyqa
  2022-07-22 16:15 ` Chocimier
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: hervyqa @ 2022-07-21  2:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

There is a new pull request by hervyqa against master on the void-packages repository

https://github.com/hervyqa/void-packages bootchart2
https://github.com/void-linux/void-packages/pull/38162

bootchart2: remove systemd service
`bootchartd` only needs to run once at boot. no need to create a service file.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

A patch file from https://github.com/void-linux/void-packages/pull/38162.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bootchart2-38162.patch --]
[-- Type: text/x-diff, Size: 910 bytes --]

From dee243c0ddcd7b1d7d84347b721a195257241f8b Mon Sep 17 00:00:00 2001
From: Hervy Qurrotul Ainur Rozi <hervyqa@proton.me>
Date: Thu, 21 Jul 2022 08:54:51 +0700
Subject: [PATCH] bootchart2: remove systemd service

---
 srcpkgs/bootchart2/template | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/bootchart2/template b/srcpkgs/bootchart2/template
index 8e8281a9e9f1..e1bff08f2328 100644
--- a/srcpkgs/bootchart2/template
+++ b/srcpkgs/bootchart2/template
@@ -1,7 +1,7 @@
 # Template file for 'bootchart2'
 pkgname=bootchart2
 version=0.14.9
-revision=2
+revision=3
 wrksrc="bootchart-${version}"
 build_style=gnu-makefile
 make_install_args="EARLY_PREFIX=/usr DOCDIR=/usr/share/doc/bootchart2"
@@ -20,3 +20,7 @@ conflicts="bootchart>=0"
 post_patch() {
 	vsed -i -e 's,\$(EARLY_PREFIX)/sbin/,/usr/bin/,' Makefile
 }
+
+post_install() {
+	rm -r $DESTDIR/usr/lib/systemd/system
+}

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: bootchart2: remove systemd service
  2022-07-21  2:00 [PR PATCH] bootchart2: remove systemd service hervyqa
@ 2022-07-22 16:15 ` Chocimier
  2022-07-23  0:33 ` hervyqa
  2022-07-23  0:33 ` [PR PATCH] [Closed]: " hervyqa
  2 siblings, 0 replies; 4+ messages in thread
From: Chocimier @ 2022-07-22 16:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/38162#issuecomment-1192733458

Comment:
The installed service is a oneshot.

This is a nice example of when we do want keep it as reference, see #32481.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: bootchart2: remove systemd service
  2022-07-21  2:00 [PR PATCH] bootchart2: remove systemd service hervyqa
  2022-07-22 16:15 ` Chocimier
@ 2022-07-23  0:33 ` hervyqa
  2022-07-23  0:33 ` [PR PATCH] [Closed]: " hervyqa
  2 siblings, 0 replies; 4+ messages in thread
From: hervyqa @ 2022-07-23  0:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/38162#issuecomment-1193021609

Comment:
oooh.. i see.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Closed]: bootchart2: remove systemd service
  2022-07-21  2:00 [PR PATCH] bootchart2: remove systemd service hervyqa
  2022-07-22 16:15 ` Chocimier
  2022-07-23  0:33 ` hervyqa
@ 2022-07-23  0:33 ` hervyqa
  2 siblings, 0 replies; 4+ messages in thread
From: hervyqa @ 2022-07-23  0:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

There's a closed pull request on the void-packages repository

bootchart2: remove systemd service
https://github.com/void-linux/void-packages/pull/38162

Description:
`bootchartd` only needs to run once at boot. no need to create a service file.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-07-23  0:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-21  2:00 [PR PATCH] bootchart2: remove systemd service hervyqa
2022-07-22 16:15 ` Chocimier
2022-07-23  0:33 ` hervyqa
2022-07-23  0:33 ` [PR PATCH] [Closed]: " hervyqa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).