From: ZyxerZyxani <ZyxerZyxani@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package EncryptPad-0.5.0.1
Date: Sun, 24 Jul 2022 20:23:41 +0200 [thread overview]
Message-ID: <20220724182341.tScDNwPeAy94aq-r945bL7uVcaWtbZr-wIuFVT97gVM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38249@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
New review comment by ZyxerZyxani on void-packages repository
https://github.com/void-linux/void-packages/pull/38249#discussion_r928295574
Comment:
The EncryptPad make install points to scripts/install.sh which ignores PREFIX and installs files as root unconditionally. It makes more sense to just do the build step and then install relevant files manually.
next prev parent reply other threads:[~2022-07-24 18:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-24 17:20 [PR PATCH] " ZyxerZyxani
2022-07-24 17:38 ` [PR REVIEW] " classabbyamp
2022-07-24 17:40 ` ZyxerZyxani
2022-07-24 17:41 ` ZyxerZyxani
2022-07-24 17:47 ` [PR PATCH] [Updated] " ZyxerZyxani
2022-07-24 17:55 ` ZyxerZyxani
2022-07-24 17:56 ` [PR REVIEW] " ZyxerZyxani
2022-07-24 18:00 ` classabbyamp
2022-07-24 18:23 ` ZyxerZyxani [this message]
2022-07-24 18:25 ` classabbyamp
2022-07-24 18:36 ` [PR PATCH] [Updated] " ZyxerZyxani
2022-07-24 18:51 ` ZyxerZyxani
2022-07-24 18:57 ` ZyxerZyxani
2022-07-25 7:40 ` tranzystorek-io
2022-08-05 1:00 ` abenson
2022-08-05 1:01 ` abenson
2022-09-05 14:12 ` [PR PATCH] [Updated] " ZyxerZyxani
2022-09-05 14:21 ` ZyxerZyxani
2022-09-06 13:01 ` ZyxerZyxani
2022-09-06 13:27 ` ZyxerZyxani
2022-09-06 13:49 ` ZyxerZyxani
2022-12-06 2:29 ` github-actions
2022-12-14 7:00 ` ZyxerZyxani
2023-03-16 1:57 ` github-actions
2023-03-31 1:55 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220724182341.tScDNwPeAy94aq-r945bL7uVcaWtbZr-wIuFVT97gVM@z \
--to=zyxerzyxani@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).