Re: [PR PATCH] [Closed]: New packages: rockpro64-base and rockpro64-uboot

[github-actions[bot] <github-actions[bot]@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 2434 bytes --]

There's a closed pull request on the void-packages repository

New packages: rockpro64-base and rockpro64-uboot
https://github.com/void-linux/void-packages/pull/33556

Description:
#### General
- [X] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

I have not built the package native on aarch64, only crossbuilds on x86_64 with aarch64 and aarch64-musl. Both built successfully with xbps-src -K.
Most of the work is copied from the pinebook-pro packages, as both are very similar using the RK3399 soc. I did not create a rockpro64 specific kernel as it did not seem necessary. I have tested using kernels 5.10, 5.13 and 5.14. The latter two versions produce fewer errors when booting (loglevel=4).
I don't know if this is relevant but I have also created images with the zfs dkms module. It only succeeded building on kernel version 5.10, however not without errors, zfs does work though.
I have not updated U-Boot to the latest version (2021-10 as of now) because it fails to build. Earlier this week it was fine so I don't yet know what happened. The second to last version (2021-07) is still very recent and does work fine.
The pinebook-pro template creates a boot.scr to boot the image, the rock64 template uses extlinux to boot, after a bit of research I opted to go with extlinux because that is what everyone else is doing (manjaro, ayufan, armbian) and this simplifies the patch for void-mklive to create an image, it does require u-boot-menu as an extra dependency.
Most of the patches come straight from the pinebookpro-uboot package with a few features taken from [Sigmaris's U-Boot](https://github.com/sigmaris/u-boot/). A description of the details can be found in the patch files.