From: meator <meator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: json-table-2.0.0
Date: Mon, 25 Jul 2022 21:12:35 +0200 [thread overview]
Message-ID: <20220725191235.KH4eY-tqVjkoCc5HAfagbLr4ThtD5Oh-9vn4YtaVQAQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38264@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
New review comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/38264#discussion_r929213738
Comment:
If it would utilize `$DESTDIR`, than you wouldn't have to specify `do_install()` at all because it would be handled automatically by the `gnu-makefile` build style. Specifying a non-default install directory via `$DESTDIR` is essential for package managers because they install the important files to a "fake" Linux system which contains just the package and then process this "fake" system to make it usable with XBPS.
The page I linked (https://www.gnu.org/software/make/manual/html_node/DESTDIR.html) and [the Manual](https://github.com/void-linux/void-packages/blob/master/Manual.md) contains more information.
next prev parent reply other threads:[~2022-07-25 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 7:22 [PR PATCH] " akhiljalagam
2022-07-25 8:51 ` [PR REVIEW] " meator
2022-07-25 17:49 ` akhiljalagam
2022-07-25 19:12 ` meator [this message]
2022-10-24 2:14 ` github-actions
2022-11-08 2:13 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725191235.KH4eY-tqVjkoCc5HAfagbLr4ThtD5Oh-9vn4YtaVQAQ@z \
--to=meator@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).