Github messages for voidlinux
 help / color / mirror / Atom feed
From: CameronNemo <CameronNemo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] Manual.md: recommend keeping systemd units
Date: Tue, 26 Jul 2022 02:11:53 +0200	[thread overview]
Message-ID: <20220726001153.6UfNfwzDc0scWbq9fsAabHGmQ7OgxPDxj5kUTtK6ahI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37395@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

There is an updated pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages systemd
https://github.com/void-linux/void-packages/pull/37395

Manual.md: recommend keeping systemd units
Closes #32481

[ci skip]

#### Testing the changes
- I tested the changes in this PR: **N/A**


A patch file from https://github.com/void-linux/void-packages/pull/37395.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-systemd-37395.patch --]
[-- Type: text/x-diff, Size: 1054 bytes --]

From d486316769de6eaa9863724f50d17682c8b69825 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Thu, 2 Jun 2022 11:58:53 -0700
Subject: [PATCH] Manual.md: recommend keeping systemd units

Ref #32154
Closes #32481
---
 Manual.md | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Manual.md b/Manual.md
index 0f16aeb3875c..2f17549d52bf 100644
--- a/Manual.md
+++ b/Manual.md
@@ -1415,6 +1415,14 @@ If the service requires directories in parts of the system that are not generall
 temporary filesystems. Then use the `make_dirs` variable in the template to create
 those directories when the package is installed.
 
+If the package installs a systemd service file or other unit, leave it in place as a
+reference point so long as including it has no negative side effects.
+
+Examples of when *not* to install systemd units:
+
+1. When doing so changes runtime behavior of the packaged software.
+2. When it is done via a compile time flag that also changes build dependencies.
+
 <a id="32bit_pkgs"></a>
 ### 32bit packages
 

  parent reply	other threads:[~2022-07-26  0:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02 19:02 [PR PATCH] " CameronNemo
2022-06-03 18:02 ` Chocimier
2022-06-06 19:12 ` Anachron
2022-06-06 19:19 ` CameronNemo
2022-06-06 19:19 ` CameronNemo
2022-07-22 16:09 ` Chocimier
2022-07-26  0:11 ` CameronNemo [this message]
2022-07-26  0:12 ` CameronNemo
2022-08-01 20:35 ` [PR PATCH] [Merged]: " Chocimier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220726001153.6UfNfwzDc0scWbq9fsAabHGmQ7OgxPDxj5kUTtK6ahI@z \
    --to=cameronnemo@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).