Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: ibus-anthy: update to 1.5.14.
Date: Wed, 27 Jul 2022 11:53:41 +0200	[thread overview]
Message-ID: <20220727095341.wZRGkiMykZ5fuTHq7qoABcqPyuYic9wnMwpG9XxK5Yk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38256@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1818 bytes --]

There's a merged pull request on the void-packages repository

ibus-anthy: update to 1.5.14.
https://github.com/void-linux/void-packages/pull/38256

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

+ This enables tests, although I can disable it again if you want.
+ swig is only needed when building with pygtk.
+ intltool is not needed by ibus-anthy.
+ This removes `--libexec=/usr/lib/ibus`. I'm not sure what it was needed for but most distros used to use it and have since removed it and the preferences popup doesn't work with it.
+ This uses `--with-layout=default` which is used by debian and fedora to tell ibus-anthy to use the default keyboard layout (otherwise it will always use JP).
+ This also moves ibus-anthy from Debian Anthy to anthy-unicode, this is what is also used by fcitx5-anthy.

In the basic testing I did, I didn't notice any issues, but please let me know if I missed something.

cc: @7185 

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


      parent reply	other threads:[~2022-07-27  9:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-24 22:26 [PR PATCH] " oreo639
2022-07-25  7:31 ` [PR PATCH] [Updated] " oreo639
2022-07-25  7:47 ` oreo639
2022-07-26 16:05 ` [PR REVIEW] " sgn
2022-07-26 19:27 ` [PR PATCH] [Updated] " oreo639
2022-07-26 19:28 ` [PR REVIEW] " oreo639
2022-07-27  9:53 ` sgn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220727095341.wZRGkiMykZ5fuTHq7qoABcqPyuYic9wnMwpG9XxK5Yk@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).