Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] xbps-src: make changes suggested by shellharden
Date: Thu, 28 Jul 2022 20:10:00 +0200	[thread overview]
Message-ID: <20220728181000.nCdgGfT7mDLMT1WMeBAUGp9soJgYbvRN_Djo_XbfZ18@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38340@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38340#discussion_r932537190

Comment:
this, for example, will run the loop only once with the entire value of REQHOST_UTILS, not once per whitespace-separated item in the value

  parent reply	other threads:[~2022-07-28 18:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 18:04 [PR PATCH] " ishaanbhimwal
2022-07-28 18:05 ` xbps-src: " classabbyamp
2022-07-28 18:08 ` ishaanbhimwal
2022-07-28 18:10 ` classabbyamp [this message]
2022-07-28 18:10 ` ishaanbhimwal
2022-07-28 18:10 ` classabbyamp
2022-07-28 18:13 ` [PR REVIEW] " Duncaen
2022-07-28 18:17 ` [PR PATCH] [Closed]: " ishaanbhimwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220728181000.nCdgGfT7mDLMT1WMeBAUGp9soJgYbvRN_Djo_XbfZ18@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).