Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] python3-BeautifulSoup4: update to 4.11.1 and adopt
Date: Fri, 29 Jul 2022 09:25:07 +0200	[thread overview]
Message-ID: <20220729072507.HQnBENo7akM4F2pA9jVem_TBPqD-lvV_7R3rxlnRvyg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38331@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38331#discussion_r932945194

Comment:
```suggestion
	vlicense LICENSE
	rm -r ${DESTDIR}/${py3_sitelib}/bs4/tests
```
we don't need to include the tests in the installed package

  reply	other threads:[~2022-07-29  7:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28  9:31 [PR PATCH] " ishaanbhimwal
2022-07-29  7:25 ` classabbyamp [this message]
2022-07-30 11:14 ` [PR PATCH] [Updated] " ishaanbhimwal
2022-07-30 15:10 ` [PR REVIEW] " paper42
2022-07-30 16:01 ` [PR PATCH] [Updated] " ishaanbhimwal
2022-08-01 17:00 ` [PR PATCH] [Merged]: python3-BeautifulSoup4: update to 4.11.1 classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220729072507.HQnBENo7akM4F2pA9jVem_TBPqD-lvV_7R3rxlnRvyg@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).