Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] ImageMagick: update to 7.1.0.44.
@ 2022-07-28  1:15 motorto
  2022-07-29  6:57 ` [PR REVIEW] " classabbyamp
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: motorto @ 2022-07-28  1:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

There is a new pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages ImageMagick-7.1.0-44
https://github.com/void-linux/void-packages/pull/38326

ImageMagick: update to 7.1.0.44.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l


A patch file from https://github.com/void-linux/void-packages/pull/38326.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ImageMagick-7.1.0-44-38326.patch --]
[-- Type: text/x-diff, Size: 1472 bytes --]

From 1028b087fec39adaed58377395037d16d6c88dc6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Thu, 28 Jul 2022 02:07:46 +0100
Subject: [PATCH] ImageMagick: update to 7.1.0.44.

---
 srcpkgs/ImageMagick/template | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ImageMagick/template b/srcpkgs/ImageMagick/template
index 3f987cbcfa60..b40756e1b0ab 100644
--- a/srcpkgs/ImageMagick/template
+++ b/srcpkgs/ImageMagick/template
@@ -1,7 +1,9 @@
 # Template file for 'ImageMagick'
+_release_prefix=44
 pkgname=ImageMagick
-version=7.1.0.43
+version=7.1.0.44
 revision=1
+wrksrc=${pkgname}-${version%.${_release_prefix}}-${_release_prefix}
 build_style=gnu-configure
 configure_args="--disable-static --enable-opencl --with-modules --with-gslib
  --with-rsvg --with-wmf --with-dejavu-font-dir=/usr/share/fonts/TTF
@@ -16,8 +18,8 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="ImageMagick"
 homepage="https://www.imagemagick.org"
 changelog="https://imagemagick.org/script/changelog.php"
-distfiles="https://github.com/ImageMagick/ImageMagick/archive/${version}.tar.gz"
-checksum=62eccb3e8c89acc66c2b10a2bea843b6659a2ddce275c7d2ffee8c34af6114fd
+distfiles="https://github.com/ImageMagick/ImageMagick/archive/${version%.${_release_prefix}}-${_release_prefix}.tar.gz"
+checksum=1532c08c4f047aaf04e2717aac23c6d866d7e17d60a5d2c320ae29874285d49f
 
 subpackages="libmagick libmagick-devel"
 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] ImageMagick: update to 7.1.0.44.
  2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
@ 2022-07-29  6:57 ` classabbyamp
  2022-07-29  7:48 ` [PR PATCH] [Updated] " motorto
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: classabbyamp @ 2022-07-29  6:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38326#discussion_r932926328

Comment:
```suggestion
version=7.1.0.44
_upstream_version="${version%.${_release_prefix}}-${_release_prefix}"
```
and then replace it where it's used, perhaps

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] ImageMagick: update to 7.1.0.44.
  2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
  2022-07-29  6:57 ` [PR REVIEW] " classabbyamp
@ 2022-07-29  7:48 ` motorto
  2022-07-29  7:48 ` [PR REVIEW] " motorto
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: motorto @ 2022-07-29  7:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages ImageMagick-7.1.0-44
https://github.com/void-linux/void-packages/pull/38326

ImageMagick: update to 7.1.0.44.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

It seems that upstream changed the way they pack the tarballs to 7.1.0-44, for version 7.1.0.44, so I created the var _release-prefix don't know if this was the best way.  

A patch file from https://github.com/void-linux/void-packages/pull/38326.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ImageMagick-7.1.0-44-38326.patch --]
[-- Type: text/x-diff, Size: 1487 bytes --]

From ea60db349ced8137c2d396d482cfb77d0bee968e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Thu, 28 Jul 2022 02:07:46 +0100
Subject: [PATCH] ImageMagick: update to 7.1.0.44.

---
 srcpkgs/ImageMagick/template | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ImageMagick/template b/srcpkgs/ImageMagick/template
index 3f987cbcfa60..5ef925f226e2 100644
--- a/srcpkgs/ImageMagick/template
+++ b/srcpkgs/ImageMagick/template
@@ -1,7 +1,10 @@
 # Template file for 'ImageMagick'
 pkgname=ImageMagick
-version=7.1.0.43
+version=7.1.0.44
 revision=1
+_release_prefix=44
+_upstream_version="${version%.${_release_prefix}}-${_release_prefix}"
+wrksrc=${pkgname}-${_upstream_version}
 build_style=gnu-configure
 configure_args="--disable-static --enable-opencl --with-modules --with-gslib
  --with-rsvg --with-wmf --with-dejavu-font-dir=/usr/share/fonts/TTF
@@ -16,8 +19,8 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="ImageMagick"
 homepage="https://www.imagemagick.org"
 changelog="https://imagemagick.org/script/changelog.php"
-distfiles="https://github.com/ImageMagick/ImageMagick/archive/${version}.tar.gz"
-checksum=62eccb3e8c89acc66c2b10a2bea843b6659a2ddce275c7d2ffee8c34af6114fd
+distfiles="https://github.com/ImageMagick/ImageMagick/archive/${_upstream_version}.tar.gz"
+checksum=1532c08c4f047aaf04e2717aac23c6d866d7e17d60a5d2c320ae29874285d49f
 
 subpackages="libmagick libmagick-devel"
 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] ImageMagick: update to 7.1.0.44.
  2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
  2022-07-29  6:57 ` [PR REVIEW] " classabbyamp
  2022-07-29  7:48 ` [PR PATCH] [Updated] " motorto
@ 2022-07-29  7:48 ` motorto
  2022-07-29  8:00 ` paper42
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: motorto @ 2022-07-29  7:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New review comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/38326#discussion_r932963194

Comment:
Done

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] ImageMagick: update to 7.1.0.44.
  2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
                   ` (2 preceding siblings ...)
  2022-07-29  7:48 ` [PR REVIEW] " motorto
@ 2022-07-29  8:00 ` paper42
  2022-07-29  8:10 ` [PR PATCH] [Updated] " motorto
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: paper42 @ 2022-07-29  8:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38326#discussion_r932972526

Comment:
get this from $version

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] ImageMagick: update to 7.1.0.44.
  2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
                   ` (3 preceding siblings ...)
  2022-07-29  8:00 ` paper42
@ 2022-07-29  8:10 ` motorto
  2022-07-29  8:10 ` [PR REVIEW] " motorto
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: motorto @ 2022-07-29  8:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages ImageMagick-7.1.0-44
https://github.com/void-linux/void-packages/pull/38326

ImageMagick: update to 7.1.0.44.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

It seems that upstream changed the way they pack the tarballs to 7.1.0-44, for version 7.1.0.44, so I created the var _release-prefix don't know if this was the best way.  

A patch file from https://github.com/void-linux/void-packages/pull/38326.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ImageMagick-7.1.0-44-38326.patch --]
[-- Type: text/x-diff, Size: 1499 bytes --]

From 3f33c0d777666160b5081248e68bcd0724ac07b3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Thu, 28 Jul 2022 02:07:46 +0100
Subject: [PATCH] ImageMagick: update to 7.1.0.44.

---
 srcpkgs/ImageMagick/template | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ImageMagick/template b/srcpkgs/ImageMagick/template
index 3f987cbcfa60..2ab0dd406eaf 100644
--- a/srcpkgs/ImageMagick/template
+++ b/srcpkgs/ImageMagick/template
@@ -1,7 +1,10 @@
 # Template file for 'ImageMagick'
 pkgname=ImageMagick
-version=7.1.0.43
+version=7.1.0.44
 revision=1
+_release_prefix=${version##*.}
+_upstream_version="${version%.${_release_prefix}}-${_release_prefix}"
+wrksrc=${pkgname}-${_upstream_version}
 build_style=gnu-configure
 configure_args="--disable-static --enable-opencl --with-modules --with-gslib
  --with-rsvg --with-wmf --with-dejavu-font-dir=/usr/share/fonts/TTF
@@ -16,8 +19,8 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="ImageMagick"
 homepage="https://www.imagemagick.org"
 changelog="https://imagemagick.org/script/changelog.php"
-distfiles="https://github.com/ImageMagick/ImageMagick/archive/${version}.tar.gz"
-checksum=62eccb3e8c89acc66c2b10a2bea843b6659a2ddce275c7d2ffee8c34af6114fd
+distfiles="https://github.com/ImageMagick/ImageMagick/archive/${_upstream_version}.tar.gz"
+checksum=1532c08c4f047aaf04e2717aac23c6d866d7e17d60a5d2c320ae29874285d49f
 
 subpackages="libmagick libmagick-devel"
 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] ImageMagick: update to 7.1.0.44.
  2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
                   ` (4 preceding siblings ...)
  2022-07-29  8:10 ` [PR PATCH] [Updated] " motorto
@ 2022-07-29  8:10 ` motorto
  2022-07-29  8:18 ` paper42
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: motorto @ 2022-07-29  8:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New review comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/38326#discussion_r932980515

Comment:
done

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] ImageMagick: update to 7.1.0.44.
  2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
                   ` (5 preceding siblings ...)
  2022-07-29  8:10 ` [PR REVIEW] " motorto
@ 2022-07-29  8:18 ` paper42
  2022-07-29  8:18 ` paper42
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: paper42 @ 2022-07-29  8:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38326#discussion_r932986958

Comment:
> Access denied. 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] ImageMagick: update to 7.1.0.44.
  2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
                   ` (6 preceding siblings ...)
  2022-07-29  8:18 ` paper42
@ 2022-07-29  8:18 ` paper42
  2022-07-29  8:21 ` [PR PATCH] [Updated] " motorto
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: paper42 @ 2022-07-29  8:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38326#discussion_r932987331

Comment:
Is there a reason why we are calling this prefix? It seems more like a suffix to me.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] ImageMagick: update to 7.1.0.44.
  2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
                   ` (7 preceding siblings ...)
  2022-07-29  8:18 ` paper42
@ 2022-07-29  8:21 ` motorto
  2022-07-29  8:22 ` motorto
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: motorto @ 2022-07-29  8:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages ImageMagick-7.1.0-44
https://github.com/void-linux/void-packages/pull/38326

ImageMagick: update to 7.1.0.44.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

It seems that upstream changed the way they pack the tarballs to 7.1.0-44, for version 7.1.0.44, so I created the var _release-prefix don't know if this was the best way.  

A patch file from https://github.com/void-linux/void-packages/pull/38326.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ImageMagick-7.1.0-44-38326.patch --]
[-- Type: text/x-diff, Size: 1499 bytes --]

From c224b8a78ff900c70e417fc2b3a0d12c1118b1a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Thu, 28 Jul 2022 02:07:46 +0100
Subject: [PATCH] ImageMagick: update to 7.1.0.44.

---
 srcpkgs/ImageMagick/template | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ImageMagick/template b/srcpkgs/ImageMagick/template
index 3f987cbcfa60..e860578ac1cf 100644
--- a/srcpkgs/ImageMagick/template
+++ b/srcpkgs/ImageMagick/template
@@ -1,7 +1,10 @@
 # Template file for 'ImageMagick'
 pkgname=ImageMagick
-version=7.1.0.43
+version=7.1.0.44
 revision=1
+_release_suffix=${version##*.}
+_upstream_version="${version%.${_release_suffix}}-${_release_suffix}"
+wrksrc=${pkgname}-${_upstream_version}
 build_style=gnu-configure
 configure_args="--disable-static --enable-opencl --with-modules --with-gslib
  --with-rsvg --with-wmf --with-dejavu-font-dir=/usr/share/fonts/TTF
@@ -16,8 +19,8 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="ImageMagick"
 homepage="https://www.imagemagick.org"
 changelog="https://imagemagick.org/script/changelog.php"
-distfiles="https://github.com/ImageMagick/ImageMagick/archive/${version}.tar.gz"
-checksum=62eccb3e8c89acc66c2b10a2bea843b6659a2ddce275c7d2ffee8c34af6114fd
+distfiles="https://github.com/ImageMagick/ImageMagick/archive/${_upstream_version}.tar.gz"
+checksum=1532c08c4f047aaf04e2717aac23c6d866d7e17d60a5d2c320ae29874285d49f
 
 subpackages="libmagick libmagick-devel"
 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: ImageMagick: update to 7.1.0.44.
  2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
                   ` (8 preceding siblings ...)
  2022-07-29  8:21 ` [PR PATCH] [Updated] " motorto
@ 2022-07-29  8:22 ` motorto
  2022-07-29  8:24 ` [PR PATCH] [Updated] " motorto
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: motorto @ 2022-07-29  8:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/38326#issuecomment-1199009811

Comment:
You are right! Let's say that linguistics is not my strength ...
Thanks for bringing that up.



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] ImageMagick: update to 7.1.0.44.
  2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
                   ` (9 preceding siblings ...)
  2022-07-29  8:22 ` motorto
@ 2022-07-29  8:24 ` motorto
  2022-07-29 21:24 ` [PR REVIEW] " classabbyamp
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: motorto @ 2022-07-29  8:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages ImageMagick-7.1.0-44
https://github.com/void-linux/void-packages/pull/38326

ImageMagick: update to 7.1.0.44.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

It seems that upstream changed the way they pack the tarballs to 7.1.0-44, for version 7.1.0.44, so I created the var _release-prefix don't know if this was the best way.  

A patch file from https://github.com/void-linux/void-packages/pull/38326.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ImageMagick-7.1.0-44-38326.patch --]
[-- Type: text/x-diff, Size: 1649 bytes --]

From 5f72c57c6309a0afb42e54055ef227963ce1a755 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Thu, 28 Jul 2022 02:07:46 +0100
Subject: [PATCH] ImageMagick: update to 7.1.0.44.

---
 srcpkgs/ImageMagick/template | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/ImageMagick/template b/srcpkgs/ImageMagick/template
index 3f987cbcfa60..a089ad1c9131 100644
--- a/srcpkgs/ImageMagick/template
+++ b/srcpkgs/ImageMagick/template
@@ -1,7 +1,10 @@
 # Template file for 'ImageMagick'
 pkgname=ImageMagick
-version=7.1.0.43
+version=7.1.0.44
 revision=1
+_release_suffix=${version##*.}
+_upstream_version="${version%.${_release_suffix}}-${_release_suffix}"
+wrksrc=${pkgname}-${_upstream_version}
 build_style=gnu-configure
 configure_args="--disable-static --enable-opencl --with-modules --with-gslib
  --with-rsvg --with-wmf --with-dejavu-font-dir=/usr/share/fonts/TTF
@@ -15,9 +18,9 @@ short_desc="Create, edit, compose, or convert bitmap images"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="ImageMagick"
 homepage="https://www.imagemagick.org"
-changelog="https://imagemagick.org/script/changelog.php"
-distfiles="https://github.com/ImageMagick/ImageMagick/archive/${version}.tar.gz"
-checksum=62eccb3e8c89acc66c2b10a2bea843b6659a2ddce275c7d2ffee8c34af6114fd
+changelog="https://raw.githubusercontent.com/ImageMagick/Website/main/ChangeLog.md"
+distfiles="https://github.com/ImageMagick/ImageMagick/archive/${_upstream_version}.tar.gz"
+checksum=1532c08c4f047aaf04e2717aac23c6d866d7e17d60a5d2c320ae29874285d49f
 
 subpackages="libmagick libmagick-devel"
 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] ImageMagick: update to 7.1.0.44.
  2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
                   ` (10 preceding siblings ...)
  2022-07-29  8:24 ` [PR PATCH] [Updated] " motorto
@ 2022-07-29 21:24 ` classabbyamp
  2022-07-29 21:24 ` classabbyamp
  2022-07-31  6:30 ` [PR PATCH] [Merged]: " classabbyamp
  13 siblings, 0 replies; 15+ messages in thread
From: classabbyamp @ 2022-07-29 21:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38326#discussion_r933625816

Comment:
```suggestion
_release_suffix=${version##*.}
_upstream_version="${version%.${_release_suffix}}-${_release_suffix}"
_upstream_version="${version/.${version##*.}/-${version##*.}}"
```
should work fine as-is but here's an alternative solution :)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] ImageMagick: update to 7.1.0.44.
  2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
                   ` (11 preceding siblings ...)
  2022-07-29 21:24 ` [PR REVIEW] " classabbyamp
@ 2022-07-29 21:24 ` classabbyamp
  2022-07-31  6:30 ` [PR PATCH] [Merged]: " classabbyamp
  13 siblings, 0 replies; 15+ messages in thread
From: classabbyamp @ 2022-07-29 21:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38326#discussion_r933625816

Comment:
```suggestion
_upstream_version="${version/.${version##*.}/-${version##*.}}"
```
should work fine as-is but here's an alternative solution :)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Merged]: ImageMagick: update to 7.1.0.44.
  2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
                   ` (12 preceding siblings ...)
  2022-07-29 21:24 ` classabbyamp
@ 2022-07-31  6:30 ` classabbyamp
  13 siblings, 0 replies; 15+ messages in thread
From: classabbyamp @ 2022-07-31  6:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

There's a merged pull request on the void-packages repository

ImageMagick: update to 7.1.0.44.
https://github.com/void-linux/void-packages/pull/38326

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

It seems that upstream changed the way they pack the tarballs to 7.1.0-44, for version 7.1.0.44, so I created the var _release-prefix don't know if this was the best way.  

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2022-07-31  6:30 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-28  1:15 [PR PATCH] ImageMagick: update to 7.1.0.44 motorto
2022-07-29  6:57 ` [PR REVIEW] " classabbyamp
2022-07-29  7:48 ` [PR PATCH] [Updated] " motorto
2022-07-29  7:48 ` [PR REVIEW] " motorto
2022-07-29  8:00 ` paper42
2022-07-29  8:10 ` [PR PATCH] [Updated] " motorto
2022-07-29  8:10 ` [PR REVIEW] " motorto
2022-07-29  8:18 ` paper42
2022-07-29  8:18 ` paper42
2022-07-29  8:21 ` [PR PATCH] [Updated] " motorto
2022-07-29  8:22 ` motorto
2022-07-29  8:24 ` [PR PATCH] [Updated] " motorto
2022-07-29 21:24 ` [PR REVIEW] " classabbyamp
2022-07-29 21:24 ` classabbyamp
2022-07-31  6:30 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).