Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] pipewire: assure rw permissions in run directories in case its missing
@ 2022-07-30 17:40 avinashkrishna07
  2022-07-30 18:25 ` [PR REVIEW] " paper42
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: avinashkrishna07 @ 2022-07-30 17:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

There is a new pull request by avinashkrishna07 against master on the void-packages repository

https://github.com/avinashkrishna07/void-packages master
https://github.com/void-linux/void-packages/pull/38376

pipewire: assure rw permissions in run directories in case its missing
Sometimes `/run/pulse` has `rwx------` permission somehow due to old pulseaudio package if installed.

This was causing `pactl info` return

```
Connection failure: Connection refused
pa_context_connect() failed: Connection refused
```

and applets showing `No audio devices`...

Because users in group `_pipewire` were not able to read/open the directory.  This PR would ensure that it has 755 permissions if the directory already exists and not readable by `_pipewire` group.


#### Testing the changes
- I tested the changes in this PR: **YES**


A patch file from https://github.com/void-linux/void-packages/pull/38376.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-38376.patch --]
[-- Type: text/x-diff, Size: 966 bytes --]

From 494365db1b4243f689af9a273065155d45607e40 Mon Sep 17 00:00:00 2001
From: avinashkrishna07 <krishnaavinash98@gmail.com>
Date: Sat, 30 Jul 2022 22:59:54 +0530
Subject: [PATCH] pipewire: assure rw permissions in run directories in case
 its missing

---
 srcpkgs/pipewire/files/pipewire-pulse/run | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/pipewire/files/pipewire-pulse/run b/srcpkgs/pipewire/files/pipewire-pulse/run
index ea0520e44cd2..66d88e84aeb6 100644
--- a/srcpkgs/pipewire/files/pipewire-pulse/run
+++ b/srcpkgs/pipewire/files/pipewire-pulse/run
@@ -2,6 +2,7 @@
 # this service is experimental and most setups should start pipewire as a user,
 # for further information, please refer to the handbook
 ! [ -d /run/pulse ] && install -m 755 -g _pipewire -o _pipewire -d /run/pulse
+[ $(stat -c %a /run/pulse) -ne 755 ] && chmod 755 /run/pulse
 umask 002
 export PULSE_RUNTIME_PATH=/run/pulse
 exec chpst -u _pipewire:_pipewire pipewire-pulse

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] pipewire: assure rw permissions in run directories in case its missing
  2022-07-30 17:40 [PR PATCH] pipewire: assure rw permissions in run directories in case its missing avinashkrishna07
@ 2022-07-30 18:25 ` paper42
  2022-07-30 18:38 ` paper42
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-07-30 18:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38376#discussion_r933874462

Comment:
This can only happen if the directory is created manually, not by this service. In that case, I would say it's the user's responsibility and we shouldn't touch change it in the service.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] pipewire: assure rw permissions in run directories in case its missing
  2022-07-30 17:40 [PR PATCH] pipewire: assure rw permissions in run directories in case its missing avinashkrishna07
  2022-07-30 18:25 ` [PR REVIEW] " paper42
@ 2022-07-30 18:38 ` paper42
  2022-10-29  2:13 ` github-actions
  2022-10-30 17:30 ` [PR PATCH] [Closed]: " paper42
  3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-07-30 18:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38376#discussion_r933875543

Comment:
And the conditional is functionally useless - we could just run `chmod` unconditionally.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: pipewire: assure rw permissions in run directories in case its missing
  2022-07-30 17:40 [PR PATCH] pipewire: assure rw permissions in run directories in case its missing avinashkrishna07
  2022-07-30 18:25 ` [PR REVIEW] " paper42
  2022-07-30 18:38 ` paper42
@ 2022-10-29  2:13 ` github-actions
  2022-10-30 17:30 ` [PR PATCH] [Closed]: " paper42
  3 siblings, 0 replies; 5+ messages in thread
From: github-actions @ 2022-10-29  2:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/38376#issuecomment-1295690407

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: pipewire: assure rw permissions in run directories in case its missing
  2022-07-30 17:40 [PR PATCH] pipewire: assure rw permissions in run directories in case its missing avinashkrishna07
                   ` (2 preceding siblings ...)
  2022-10-29  2:13 ` github-actions
@ 2022-10-30 17:30 ` paper42
  3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-10-30 17:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

There's a closed pull request on the void-packages repository

pipewire: assure rw permissions in run directories in case its missing
https://github.com/void-linux/void-packages/pull/38376

Description:
Sometimes `/run/pulse` has `rwx------` permission somehow due to old pulseaudio package if installed.

This was causing `pactl info` return

```
Connection failure: Connection refused
pa_context_connect() failed: Connection refused
```

and applets showing `No audio devices`...

Because users in group `_pipewire` were not able to read/open the directory.  This PR would ensure that it has 755 permissions if the directory already exists and not readable by `_pipewire` group.


#### Testing the changes
- I tested the changes in this PR: **YES**


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-10-30 17:30 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-30 17:40 [PR PATCH] pipewire: assure rw permissions in run directories in case its missing avinashkrishna07
2022-07-30 18:25 ` [PR REVIEW] " paper42
2022-07-30 18:38 ` paper42
2022-10-29  2:13 ` github-actions
2022-10-30 17:30 ` [PR PATCH] [Closed]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).