From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: didder-1.1.0
Date: Sun, 31 Jul 2022 10:57:22 +0200 [thread overview]
Message-ID: <20220731085722.hJeLOQNn16AobfkYGu2_FAdTtoHVvcK29OVXAGhAIbk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38387@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/38387#discussion_r933952241
Comment:
```roff
.TH "DIDDER" "1" "$(DATE)" "didder $(VERSION)" "User Manual"
```
this isn't doing what you think it is. those are `make` variable substitutions.
```suggestion
sed -i "s/VERSION/${version}/g" didder.1
_date="$(date --utc --date "@$SOURCE_DATE_EPOCH" "+%B %d, %Y")"
sed -i "s/DATE/${_date}/g" didder.1
```
this should insert the actual date and version
next prev parent reply other threads:[~2022-07-31 8:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-31 8:21 [PR PATCH] " kotajacob
2022-07-31 8:57 ` [PR REVIEW] " classabbyamp
2022-07-31 8:57 ` classabbyamp
2022-07-31 8:57 ` classabbyamp [this message]
2022-07-31 8:57 ` classabbyamp
2022-07-31 9:10 ` [PR PATCH] [Updated] " kotajacob
2022-07-31 9:10 ` [PR REVIEW] " kotajacob
2022-07-31 9:12 ` kotajacob
2022-07-31 9:13 ` kotajacob
2022-07-31 9:13 ` kotajacob
2022-10-30 2:14 ` github-actions
2022-11-13 8:50 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220731085722.hJeLOQNn16AobfkYGu2_FAdTtoHVvcK29OVXAGhAIbk@z \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).