Github messages for voidlinux
 help / color / mirror / Atom feed
From: icp1994 <icp1994@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: hatch-1.3.1/hatchling-1.6.0
Date: Tue, 02 Aug 2022 08:03:05 +0200	[thread overview]
Message-ID: <20220802060305.4FNRywDj1ootDXmUainhCrYqstz4hza1y2Y4VjtnemU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37892@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/37892#issuecomment-1202054231

Comment:
After some tinkering around, I think I have figured out what's causing the new errors. I'll list the reasoning sequentially for easier reading.

1. The tests for `hatchling` comes bundled with the `hatch` source in `tests/backend` folder.
2. At the time of `hatch-1.3.1` release, the latest release of `hatchling` was `1.5.0`. The `tests/backend` inside `hatch-1.3.1.tar.gz` were therefore meant to run alongside `hatchling-1.5.0`.
3. But with the current template, building `hatch-1.3.1` pulls `hatchling-1.6.0` as dependency so some of the old tests which aren't compatible anymore with the newer `hatchling` version fails.

We should be able to merge `hatchling-1.5.0` and `hatch-1.3.1` first and then `hatchling-1.6.0` in a separate commit since the `hatchling` package runs no tests. Or we could decouple `hatchling` tests from `hatch` so this headache doesn't occur in the future whenever we skip a couple minor updates and the tests become incompatible.

  parent reply	other threads:[~2022-08-02  6:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06  9:45 [PR PATCH] hatchling 1.4.1 1 jcgruenhage
2022-07-06  9:54 ` [PR PATCH] [Updated] " jcgruenhage
2022-07-06 15:38 ` icp1994
2022-07-21  6:44 ` jcgruenhage
2022-07-21  6:45 ` jcgruenhage
2022-07-21  6:45 ` [PR PATCH] [Updated] " jcgruenhage
2022-07-21  7:04 ` hatch-1.3.1/hatchling-1.5.0 icp1994
2022-07-21  9:25 ` hatch-1.3.1/hatchling-1.5.0 jcgruenhage
2022-07-23  2:30 ` [PR REVIEW] hatch-1.3.1/hatchling-1.5.0 classabbyamp
2022-07-31 21:46 ` jcgruenhage
2022-07-31 21:46 ` [PR PATCH] [Updated] hatch-1.3.1/hatchling-1.5.0 jcgruenhage
2022-07-31 21:48 ` hatch-1.3.1/hatchling-1.5.0 jcgruenhage
2022-08-02  6:03 ` icp1994 [this message]
2022-08-02 16:13 ` hatch-1.3.1/hatchling-1.6.0 jcgruenhage
2022-08-02 16:17 ` [PR PATCH] [Updated] hatch-1.3.1/hatchling-1.6.0 jcgruenhage
2022-08-02 16:18 ` hatch-1.3.1/hatchling-1.6.0 jcgruenhage
2022-08-03 11:58 ` [PR PATCH] [Merged]: hatch-1.3.1/hatchling-1.6.0 sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220802060305.4FNRywDj1ootDXmUainhCrYqstz4hza1y2Y4VjtnemU@z \
    --to=icp1994@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).