Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] micro: fix broken resource bundling.
@ 2022-08-02  7:18 0x5c
  2022-08-02  8:07 ` [PR PATCH] [Merged]: " classabbyamp
  0 siblings, 1 reply; 2+ messages in thread
From: 0x5c @ 2022-08-02  7:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]

There is a new pull request by 0x5c against master on the void-packages repository

https://github.com/0x5c/void-packages fix-micro-syntax
https://github.com/void-linux/void-packages/pull/38421

micro: fix broken resource bundling.
The v2.0.11 update changed the way resources are bundled, now requiring an
additional step to 'generate' the bundle. Since I happened to only test the
original update on files that I have custom syntax for, I only realised the
presence of the regression after the update got merged (#38402).

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38421.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-micro-syntax-38421.patch --]
[-- Type: text/x-diff, Size: 1265 bytes --]

From ad8bcc5c857c9245bcbd52df13017f8de612ed08 Mon Sep 17 00:00:00 2001
From: 0x5c <dev@0x5c.io>
Date: Tue, 2 Aug 2022 02:27:39 -0400
Subject: [PATCH] micro: fix broken resource bundling.

The v2.0.11 update changed the way resources are bundled, now requiring an
additional step to 'generate' the bundle. Since I happened to only test the
original update on files that I have custom syntax for, I only realised the
presence of the regression after the update got merged (#38402).
---
 srcpkgs/micro/template | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/micro/template b/srcpkgs/micro/template
index 8c6032324fcf..669bc7d89232 100644
--- a/srcpkgs/micro/template
+++ b/srcpkgs/micro/template
@@ -1,7 +1,7 @@
 # Template file for 'micro'
 pkgname=micro
 version=2.0.11
-revision=1
+revision=2
 build_style=go
 go_import_path="github.com/zyedidia/micro/v2"
 go_package="${go_import_path}/cmd/micro"
@@ -15,6 +15,10 @@ homepage="https://micro-editor.github.io"
 distfiles="https://github.com/zyedidia/micro/archive/v${version}.tar.gz"
 checksum=1bb499edeaaadf1fe1791a49f96ab672c4e1add31ee125882ccd85a0fc8a4abe
 
+pre_build() {
+	GOARCH= go generate ./runtime
+}
+
 post_install() {
 	vlicense LICENSE
 	vman assets/packaging/micro.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: micro: fix broken resource bundling.
  2022-08-02  7:18 [PR PATCH] micro: fix broken resource bundling 0x5c
@ 2022-08-02  8:07 ` classabbyamp
  0 siblings, 0 replies; 2+ messages in thread
From: classabbyamp @ 2022-08-02  8:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]

There's a merged pull request on the void-packages repository

micro: fix broken resource bundling.
https://github.com/void-linux/void-packages/pull/38421

Description:
The v2.0.11 update changed the way resources are bundled, now requiring an
additional step to 'generate' the bundle. Since I happened to only test the
original update on files that I have custom syntax for, I only realised the
presence of the regression after the update got merged (#38402).

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-02  8:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-02  7:18 [PR PATCH] micro: fix broken resource bundling 0x5c
2022-08-02  8:07 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).