From: prez <prez@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: mixxx: update to 2.3.3.
Date: Tue, 02 Aug 2022 15:32:34 +0200 [thread overview]
Message-ID: <20220802133234.WWf3opAhL6RxnswubnhKCo_AcZjN-utCAAwHvR-CbnA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38416@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
New comment by prez on void-packages repository
https://github.com/void-linux/void-packages/pull/38416#issuecomment-1202557726
Comment:
I'm not sure why you chose to ignore https://github.com/void-linux/void-packages/pull/34808.
Have you checked whether those dependencies are correct? In my PR, there's
```
-libmp4v2-devel
-libshout-devel
+libflac-devel
+libmodplug-devel
+libogg-devel
+libsndfile-devel
+libvorbis-devel
+wavpack-devel
```
compared to yours.
It's been over half a year since I made that PR and I don't feel like re-checking all of it, but I must have had reasons.
Additionally, is the patch needed? It seems to build fine on musl CI without it.
I can say with confidence that with my PR, all features of mixxx work as expected, whereas I'm not so sure with yours - e.g. there could be breakage in streaming functionality, since non-bundled libshout is known to be broken very often.
next prev parent reply other threads:[~2022-08-02 13:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 0:34 [PR PATCH] " abenson
2022-08-02 2:12 ` [PR PATCH] [Updated] " abenson
2022-08-02 13:26 ` prez
2022-08-02 13:29 ` prez
2022-08-02 13:32 ` prez [this message]
2022-08-02 18:04 ` [PR PATCH] [Closed]: " abenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220802133234.WWf3opAhL6RxnswubnhKCo_AcZjN-utCAAwHvR-CbnA@z \
--to=prez@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).