Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: gum-0.2.0
Date: Tue, 02 Aug 2022 19:46:24 +0200	[thread overview]
Message-ID: <20220802174624.kk2xsoOqJkMq721UiOSGGtKnkyFax09msBRFS529ju8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38427@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38427#discussion_r935866262

Comment:
```suggestion
post_install() {
	vlicense LICENSE

	_cli=$(find $GOPATH/bin -name $pkgname)
	for shell in bash fish zsh; do
		vtargetrun $_cli completion $shell > ${pkgname}.${shell}
		vcompletion ${pkgname}.${shell} $shell
	done

	vtargetrun $_cli man > ${pkgname}.1
	vman ${pkgname}.1
}
```
this is a bit neater

  parent reply	other threads:[~2022-08-02 17:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02 13:48 [PR PATCH] " akhiljalagam
2022-08-02 13:53 ` akhiljalagam
2022-08-02 13:53 ` akhiljalagam
2022-08-02 14:01 ` tranzystorek-io
2022-08-02 14:07 ` [PR REVIEW] " tranzystorek-io
2022-08-02 14:08 ` [PR PATCH] [Updated] " akhiljalagam
2022-08-02 14:09 ` tranzystorek-io
2022-08-02 14:27 ` [PR PATCH] [Updated] " akhiljalagam
2022-08-02 17:46 ` classabbyamp [this message]
2022-08-02 17:47 ` akhiljalagam
2022-08-02 17:48 ` akhiljalagam
2022-08-05  8:45 ` dmarto
2022-08-05 18:44 ` [PR PATCH] [Updated] " akhiljalagam
2022-08-05 19:50 ` classabbyamp
2022-08-06  5:53 ` [PR PATCH] [Updated] New package: gum-0.4.0 akhiljalagam
2022-08-06  5:53 ` akhiljalagam
2022-09-15  7:05 ` akhiljalagam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220802174624.kk2xsoOqJkMq721UiOSGGtKnkyFax09msBRFS529ju8@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).