From: Duncaen <Duncaen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [Draft] xbps-src: clean up fetch hook and allow mirroring
Date: Sun, 07 Aug 2022 20:09:37 +0200 [thread overview]
Message-ID: <20220807180937.pJtKgjHlNIhEopE9SoWmEA6IFD0zkBzLYe59xvwXojg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38494@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/38494#issuecomment-1207458649
Comment:
The extra complexity isn't that big, I expect this change to reduce the number of lines, at the moment its like +11 lines.
Its basically just creating a per distfile target list of indexes into the `distfiles` and `checksum` variables and then tries to download the first matching one.
The looping already exists for `XBPS_DISTFILES_MIRROR` and the current implementation kinda already works by indexing into distfiles+checksums but in a weird way, which is why the rewrite will be more compact/simpler, by just using indexed arrays.
next prev parent reply other threads:[~2022-08-07 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 2:57 [PR PATCH] " Duncaen
2022-08-07 17:52 ` [Draft] " CameronNemo
2022-08-07 18:09 ` Duncaen [this message]
2022-08-07 18:10 ` Duncaen
2022-09-06 2:34 ` CameronNemo
2022-10-01 21:29 ` [PR PATCH] [Closed]: " Duncaen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220807180937.pJtKgjHlNIhEopE9SoWmEA6IFD0zkBzLYe59xvwXojg@z \
--to=duncaen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).