Re: New package: Orthanc-1.11.1

[bingulo <bingulo@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1680 bytes --]

New comment by bingulo on void-packages repository

https://github.com/void-linux/void-packages/pull/38537#issuecomment-1208558630

Comment:
@ahesford
>     * Are all of these shared libs really necessary for linking by other packages? If not, leave them out of `common/shlibs`.

Done.

>     * One commit per package, one package per commit. Split each of these into a separate commit in the same PR.

Done.

>     * Remove version restrictions in `hostmakedepends` and `makedepends`. Version enforcement makes no sense here because the repository specifies a single version of the package; whatever is current. It either builds with that version or it's broken.

Done.

>     * What is the purpose of the `Orthanc-{DicomWeb,PostgreSQL,Python}` packages? They aren't reference by any other templates.

These are some plugins i decided to package, it isn't requiered by the main package (Orthanc), but as these makedepends of Orthanc I added them into this PR.
      
>       * If `Orthanc-Python` really doesn't work with py3.11, that's a problem, because we'll be moving to py3.11 soon and I'd like to minimize potential breakage caused by the addition of new specialty packages in the meantime.

It works, you just need to pass a flag with the major python version. As I passed python 3.10, i decided to restrict it on the template, but I understand now that it doesn't make sense and I've removed it. Now I need to get the python version from the upstream repo and pass it to configure_args. I'll try some way to do it.

>       * If `Orthanc-Python` is a Python package, it should depend on `python3`.

It isn't, it's mostly like a binding instead.