From: 241m <241m@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: MangoHud: update to 0.6.8.
Date: Wed, 10 Aug 2022 17:18:42 +0200 [thread overview]
Message-ID: <20220810151842.npCAY26ZveitIEq9SDGs845G3QnKKLvyNwHEpma7dcE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38562@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
New comment by 241m on void-packages repository
https://github.com/void-linux/void-packages/pull/38562#issuecomment-1210847026
Comment:
> > * [Allow use of system nlohmann_json dependency](https://github.com/flightlessmango/MangoHud/commit/e1ffa0f85820abea44639438fca2152290c87ee8)
>
> add `json-c++` to makedepends
If I'm not mistaken, the nlohmann_json dependency is only used by mangoapp ([src/meson.build](https://github.com/flightlessmango/MangoHud/blob/efdcc6d2f54e37a3a32475453407f1eb33d1bef2/src/meson.build#L248)), and AFAICT, is not built, nor installed by default ([meson_options.txt](https://github.com/flightlessmango/MangoHud/blob/efdcc6d2f54e37a3a32475453407f1eb33d1bef2/meson_options.txt#L17)).
I could be wrong, as this is my first time working with meson. If not, maybe a mangoapp subpackage should be added instead? Ala its [AUR](https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=mangohud) counterpart?
Anyway, I'm marking this with WIP for now.
next prev parent reply other threads:[~2022-08-10 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 19:52 [PR PATCH] " 241m
2022-08-09 20:07 ` [PR REVIEW] " paper42
2022-08-09 20:16 ` [PR PATCH] [Updated] " 241m
2022-08-10 4:45 ` classabbyamp
2022-08-10 15:18 ` 241m [this message]
2022-08-11 7:46 ` [PR PATCH] [Updated] [WIP] " 241m
2022-08-11 7:51 ` 241m
2022-08-11 7:52 ` [PR PATCH] [Closed]: " 241m
2022-09-15 17:04 ` onli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220810151842.npCAY26ZveitIEq9SDGs845G3QnKKLvyNwHEpma7dcE@z \
--to=241m@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).