Github messages for voidlinux
 help / color / mirror / Atom feed
From: ketlrznt <ketlrznt@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: v2ray-domain-list-community-20220809072217
Date: Thu, 11 Aug 2022 04:21:43 +0200	[thread overview]
Message-ID: <20220811022143.X3kFts7O7F7xNWKO3Ap_yMogALoBebupCFk39ulqRIU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38582@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

New review comment by ketlrznt on void-packages repository

https://github.com/void-linux/void-packages/pull/38582#discussion_r943050330

Comment:
> 1. I think what's happening is you're trying to run a binary built for not-x86_64 on x86_64, which will only work in a few cases.
> 
>     2. yes, I think fetching the released dat file is better, and can probably be simply added as a distfile for v2ray (but I'm not sure, I don't know anything about this software)

Done. Thank you for your advice.

For list point 2, `v2ray-domain-list-community` gets updates very rapidly, as upstream releases new dat file every week. It's better to make a separated package for it, or v2ray may get revision very often, which doesn't mean too much.

  parent reply	other threads:[~2022-08-11  2:21 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10 14:21 [PR PATCH] New package: v2ray-domain-list-community ketlrznt
2022-08-10 14:21 ` ketlrznt
2022-08-10 14:22 ` ketlrznt
2022-08-10 14:23 ` ketlrznt
2022-08-10 14:26 ` [WIP] " ketlrznt
2022-08-10 14:27 ` ketlrznt
2022-08-10 14:42 ` [WIP] New package: v2ray-domain-list-community-20220809072217 ketlrznt
2022-08-10 14:45 ` ketlrznt
2022-08-10 14:46 ` ketlrznt
2022-08-10 14:52 ` ketlrznt
2022-08-10 19:54 ` classabbyamp
2022-08-10 23:37 ` [PR PATCH] [Updated] " ketlrznt
2022-08-10 23:38 ` ketlrznt
2022-08-10 23:39 ` ketlrznt
2022-08-11  0:41 ` [PR PATCH] [Updated] " ketlrznt
2022-08-11  0:46 ` [PR REVIEW] " ketlrznt
2022-08-11  0:50 ` ketlrznt
2022-08-11  1:13 ` classabbyamp
2022-08-11  2:15 ` [PR PATCH] [Updated] " ketlrznt
2022-08-11  2:21 ` [PR REVIEW] " ketlrznt
2022-08-11  2:21 ` ketlrznt [this message]
2022-08-11  2:24 ` classabbyamp
2022-08-11  2:30 ` ketlrznt
2022-08-11  2:30 ` ketlrznt
2022-08-11  2:31 ` classabbyamp
2022-08-11  2:38 ` ketlrznt
2022-08-11  2:38 ` ketlrznt
2022-08-11  2:39 ` ketlrznt
2022-08-11  2:44 ` ketlrznt
2022-08-11  2:51 ` [PR PATCH] [Updated] " ketlrznt
2022-08-11  2:57 ` ketlrznt
2022-08-11  3:07 ` classabbyamp
2022-08-11  3:14 ` ketlrznt
2022-08-11  3:17 ` [PR PATCH] [Updated] " ketlrznt
2022-08-11  3:21 ` ketlrznt
2022-08-11  4:34 ` ketlrznt
2022-10-19  8:53 ` [PR PATCH] [Closed]: " ketlrznt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220811022143.X3kFts7O7F7xNWKO3Ap_yMogALoBebupCFk39ulqRIU@z \
    --to=ketlrznt@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).