Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] font-spleen: include otb version
@ 2022-08-09 17:47 Barbaross93
  2022-08-11  7:15 ` [PR REVIEW] " classabbyamp
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Barbaross93 @ 2022-08-09 17:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

There is a new pull request by Barbaross93 against master on the void-packages repository

https://github.com/Barbaross93/void-packages spleen
https://github.com/void-linux/void-packages/pull/38557

font-spleen: include otb version
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


A patch file from https://github.com/void-linux/void-packages/pull/38557.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spleen-38557.patch --]
[-- Type: text/x-diff, Size: 1125 bytes --]

From ff409dbdfd05ef62d1c5066e92b96a6530c7aee5 Mon Sep 17 00:00:00 2001
From: Barbaross <cullen.ross@proton.me>
Date: Tue, 9 Aug 2022 13:44:58 -0400
Subject: [PATCH] font-spleen: include otb version

---
 srcpkgs/font-spleen/template | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/font-spleen/template b/srcpkgs/font-spleen/template
index 0a7873adaceb..36a48d96c314 100644
--- a/srcpkgs/font-spleen/template
+++ b/srcpkgs/font-spleen/template
@@ -1,12 +1,12 @@
 # Template file for 'font-spleen'
 pkgname=font-spleen
 version=1.9.1
-revision=1
+revision=2
 wrksrc="spleen-${version}"
 build_style=gnu-makefile
 make_cmd=bmake
-make_build_target="pcf psf"
-hostmakedepends="bmake bdftopcf bdf2psf"
+make_build_target="pcf psf otb"
+hostmakedepends="bmake bdftopcf bdf2psf fonttosfnt"
 depends="font-util"
 short_desc="Monospaced bitmap fonts"
 maintainer="Renato Aguiar <renato@renatoaguiar.net>"
@@ -42,5 +42,8 @@ do_install() {
 	done
 	vinstall fonts.alias 644 usr/share/fonts/X11/spleen
 
+	for f in *.otb; do
+		vinstall $f 644 usr/share/fonts/X11/spleen
+	done
 	vlicense LICENSE
 }

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] font-spleen: include otb version
  2022-08-09 17:47 [PR PATCH] font-spleen: include otb version Barbaross93
@ 2022-08-11  7:15 ` classabbyamp
  2022-08-11  7:15 ` classabbyamp
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-08-11  7:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38557#discussion_r943165095

Comment:
could the loop in line 40 be turned into `for f in *.pcf.gz *.otb; do`?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] font-spleen: include otb version
  2022-08-09 17:47 [PR PATCH] font-spleen: include otb version Barbaross93
  2022-08-11  7:15 ` [PR REVIEW] " classabbyamp
@ 2022-08-11  7:15 ` classabbyamp
  2022-08-11  8:47 ` paper42
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-08-11  7:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38557#discussion_r943165095

Comment:
could the loop in line 40 be turned into `for f in *.pcf.gz *.otb; do` instead of having two loops?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: font-spleen: include otb version
  2022-08-09 17:47 [PR PATCH] font-spleen: include otb version Barbaross93
  2022-08-11  7:15 ` [PR REVIEW] " classabbyamp
  2022-08-11  7:15 ` classabbyamp
@ 2022-08-11  8:47 ` paper42
  2022-08-11 11:01 ` [PR REVIEW] " Barbaross93
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-08-11  8:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38557#issuecomment-1211709684

Comment:
please add your commit email to your github profile

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] font-spleen: include otb version
  2022-08-09 17:47 [PR PATCH] font-spleen: include otb version Barbaross93
                   ` (2 preceding siblings ...)
  2022-08-11  8:47 ` paper42
@ 2022-08-11 11:01 ` Barbaross93
  2022-08-11 11:02 ` [PR PATCH] [Updated] " Barbaross93
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Barbaross93 @ 2022-08-11 11:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New review comment by Barbaross93 on void-packages repository

https://github.com/void-linux/void-packages/pull/38557#discussion_r943356586

Comment:
Sure! I wasn't sure if it made sense to put the otb versions in the same directory, but I haven't had any problems doing that so your suggestion sounds good to me.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] font-spleen: include otb version
  2022-08-09 17:47 [PR PATCH] font-spleen: include otb version Barbaross93
                   ` (3 preceding siblings ...)
  2022-08-11 11:01 ` [PR REVIEW] " Barbaross93
@ 2022-08-11 11:02 ` Barbaross93
  2022-08-11 11:06 ` Barbaross93
  2022-08-13 19:36 ` [PR PATCH] [Merged]: " classabbyamp
  6 siblings, 0 replies; 8+ messages in thread
From: Barbaross93 @ 2022-08-11 11:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

There is an updated pull request by Barbaross93 against master on the void-packages repository

https://github.com/Barbaross93/void-packages spleen
https://github.com/void-linux/void-packages/pull/38557

font-spleen: include otb version
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


A patch file from https://github.com/void-linux/void-packages/pull/38557.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spleen-38557.patch --]
[-- Type: text/x-diff, Size: 1171 bytes --]

From 9b122b2c5725b8597a025e10451c023ea9295d8e Mon Sep 17 00:00:00 2001
From: Barbaross <cullen.ross@proton.me>
Date: Tue, 9 Aug 2022 13:44:58 -0400
Subject: [PATCH] font-spleen: include otb version

---
 srcpkgs/font-spleen/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/font-spleen/template b/srcpkgs/font-spleen/template
index 0a7873adaceb..23e1407a75d4 100644
--- a/srcpkgs/font-spleen/template
+++ b/srcpkgs/font-spleen/template
@@ -1,12 +1,12 @@
 # Template file for 'font-spleen'
 pkgname=font-spleen
 version=1.9.1
-revision=1
+revision=2
 wrksrc="spleen-${version}"
 build_style=gnu-makefile
 make_cmd=bmake
-make_build_target="pcf psf"
-hostmakedepends="bmake bdftopcf bdf2psf"
+make_build_target="pcf psf otb"
+hostmakedepends="bmake bdftopcf bdf2psf fonttosfnt"
 depends="font-util"
 short_desc="Monospaced bitmap fonts"
 maintainer="Renato Aguiar <renato@renatoaguiar.net>"
@@ -37,7 +37,7 @@ do_install() {
 	done
 
 	vmkdir usr/share/fonts/X11/spleen
-	for f in *.pcf.gz; do
+	for f in *.pcf.gz *.otb; do
 		vinstall $f 644 usr/share/fonts/X11/spleen
 	done
 	vinstall fonts.alias 644 usr/share/fonts/X11/spleen

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: font-spleen: include otb version
  2022-08-09 17:47 [PR PATCH] font-spleen: include otb version Barbaross93
                   ` (4 preceding siblings ...)
  2022-08-11 11:02 ` [PR PATCH] [Updated] " Barbaross93
@ 2022-08-11 11:06 ` Barbaross93
  2022-08-13 19:36 ` [PR PATCH] [Merged]: " classabbyamp
  6 siblings, 0 replies; 8+ messages in thread
From: Barbaross93 @ 2022-08-11 11:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New comment by Barbaross93 on void-packages repository

https://github.com/void-linux/void-packages/pull/38557#issuecomment-1211842718

Comment:
@paper42 I think I did what you asked? I'm not sure though. I merely made my email public.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Merged]: font-spleen: include otb version
  2022-08-09 17:47 [PR PATCH] font-spleen: include otb version Barbaross93
                   ` (5 preceding siblings ...)
  2022-08-11 11:06 ` Barbaross93
@ 2022-08-13 19:36 ` classabbyamp
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-08-13 19:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

There's a merged pull request on the void-packages repository

font-spleen: include otb version
https://github.com/void-linux/void-packages/pull/38557

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-08-13 19:36 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-09 17:47 [PR PATCH] font-spleen: include otb version Barbaross93
2022-08-11  7:15 ` [PR REVIEW] " classabbyamp
2022-08-11  7:15 ` classabbyamp
2022-08-11  8:47 ` paper42
2022-08-11 11:01 ` [PR REVIEW] " Barbaross93
2022-08-11 11:02 ` [PR PATCH] [Updated] " Barbaross93
2022-08-11 11:06 ` Barbaross93
2022-08-13 19:36 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).