Github messages for voidlinux
 help / color / mirror / Atom feed
From: TinfoilSubmarine <TinfoilSubmarine@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] cegui: drop unused python-devel in makedepends.
Date: Thu, 11 Aug 2022 19:38:44 +0200	[thread overview]
Message-ID: <20220811173844.cNc-F2KmYK-ERiWQnY2E28DIi-MY7Jg-6P4VSfs9tuo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38614@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1578 bytes --]

There is an updated pull request by TinfoilSubmarine against master on the void-packages repository

https://github.com/TinfoilSubmarine/void-packages update/cegui
https://github.com/void-linux/void-packages/pull/38614

cegui: drop unused python-devel in makedepends.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES** (ran `TSC` with updated `gecui`)

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Another one not actually using `python-devel`. Configure output shows that it wasn't even building the python extension modules due to some issue with Boost-python. The only package depending on this is `TSC` and it doesn't seem to require the python extensions.

A patch file from https://github.com/void-linux/void-packages/pull/38614.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update/cegui-38614.patch --]
[-- Type: text/x-diff, Size: 3575 bytes --]

From 1c02076b7357c0b87c19923cf9a05a65754c1645 Mon Sep 17 00:00:00 2001
From: Joel Beckmeyer <joel@beckmeyer.us>
Date: Thu, 11 Aug 2022 12:16:35 -0400
Subject: [PATCH 1/2] cegui: drop unused python-devel in makedepends.

---
 srcpkgs/cegui/template | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/cegui/template b/srcpkgs/cegui/template
index 070fa66aff81..de507c8b0fd3 100644
--- a/srcpkgs/cegui/template
+++ b/srcpkgs/cegui/template
@@ -1,7 +1,7 @@
 # Template file for 'cegui'
 pkgname=cegui
 version=0.8.7.20190225
-revision=5
+revision=6
 _githash=bfc6a841de45b8e63040d33b9cccc67745337f4e
 wrksrc="${pkgname}-${_githash}"
 build_style=cmake
@@ -14,7 +14,6 @@ makedepends="libglvnd-devel SDL2-devel SDL2_image-devel libxml2-devel boost-deve
  devil-devel glfw-devel glm ois-devel silly-devel fribidi-devel lua53-devel minizip-devel
  $(vopt_if irrlicht irrlicht-devel)
  $(vopt_if ogre libogre-devel)
- $(vopt_if python python-devel)
  $(vopt_if gtk gtk+-devel)"
 short_desc="Crazy Eddie's Graphical User Interface"
 maintainer="Orphaned <orphan@voidlinux.org>"
@@ -24,10 +23,10 @@ distfiles="https://github.com/cegui/cegui/archive/${_githash}.tar.gz"
 checksum=70156257313b81d068d6592887157dd16b91d7bc0dfdcba02a96ed371d329e64
 replaces="cegui-data>=0 cegui-sample>=0"
 
-build_options="gtk irrlicht ogre python"
+build_options="gtk irrlicht ogre"
 desc_option_irrlicht="Enable support for Irrlicht"
 desc_option_ogre="Enable support for Ogre"
-build_options_default="gtk python"
+build_options_default="gtk"
 
 if [ -z "$CROSS_BUILD" ]; then
 	# irrlicht interface fails to cross compile

From 81aa1b6a66fa3c0f60518064fc2dcb58db9a69a1 Mon Sep 17 00:00:00 2001
From: Joel Beckmeyer <joel@beckmeyer.us>
Date: Thu, 11 Aug 2022 13:34:36 -0400
Subject: [PATCH 2/2] cegui07: drop unused python/python-devel in *depends.

---
 srcpkgs/cegui07/template | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/srcpkgs/cegui07/template b/srcpkgs/cegui07/template
index 3fa7f80a2ea7..c5cc5ca950e8 100644
--- a/srcpkgs/cegui07/template
+++ b/srcpkgs/cegui07/template
@@ -1,18 +1,17 @@
 # Template file for 'cegui07'
 pkgname=cegui07
 version=0.7.9
-revision=8
+revision=9
 wrksrc="CEGUI-${version}"
 build_style=gnu-configure
 configure_args="--disable-samples"
 make_build_args="all html"
 hostmakedepends="automake dejavu-fonts-ttf doxygen glm graphviz libtool
- pkg-config python"
+ pkg-config"
 makedepends="boost-devel devil-devel freeimage-devel freetype-devel
  fribidi-devel glfw-devel libxml2-devel lua51-devel minizip-devel ois-devel
  pcre-devel silly-devel tinyxml-devel toluapp-devel
- $(vopt_if irrlicht 'irrlicht-devel')
- $(vopt_if python 'python-devel')"
+ $(vopt_if irrlicht 'irrlicht-devel')"
 depends="cegui07-data"
 short_desc="Crazy Eddie's Graphical User Interface (0.7.x)"
 maintainer="Orphaned <orphan@voidlinux.org>"
@@ -21,18 +20,10 @@ homepage="http://cegui.org.uk/"
 distfiles="${SOURCEFORGE_SITE}/crayzedsgui/CEGUI%20Mk-2/${version}/CEGUI-${version}.tar.gz"
 checksum=7c3b264def08b46de749c2acaba363e907479d924612436f3bd09da2e474bb8c
 
-build_options="irrlicht python"
+build_options="irrlicht"
 desc_option_irrlicht="Enable support for Irrlicht"
 build_options_default="irrlicht"
 
-if [ -z "$CROSS_BUILD" ]; then
-	# XXX: boost-python is not available when cross building
-	build_options_default+=" python"
-fi
-
-# Make configure find python and freetype2
-CFLAGS="-I${XBPS_CROSS_BASE}/usr/include/python2.7"
-
 pre_configure() {
 	# Silence doxygen
 	sed -i doc/doxygen/Makefile.am \

  parent reply	other threads:[~2022-08-11 17:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11 16:29 [PR PATCH] " TinfoilSubmarine
2022-08-11 16:37 ` classabbyamp
2022-08-11 16:44 ` classabbyamp
2022-08-11 17:38 ` TinfoilSubmarine [this message]
2022-08-11 18:39 ` [PR REVIEW] cegui/cegui07: " paper42
2022-08-11 18:40 ` paper42
2022-08-11 18:59 ` classabbyamp
2022-08-11 19:09 ` [PR REVIEW] " TinfoilSubmarine
2022-08-11 21:13 ` paper42
2022-08-12 14:17 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-08-12 14:32 ` TinfoilSubmarine
2022-08-12 14:33 ` TinfoilSubmarine
2022-08-12 21:23 ` classabbyamp
2022-08-12 22:47 ` [PR REVIEW] " paper42
2022-08-15 12:39 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-08-15 12:42 ` [PR PATCH] [Updated] cegui: drop unused dependencies in makedepends; SMC/cegui07: remove TinfoilSubmarine
2022-08-17 15:41 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220811173844.cNc-F2KmYK-ERiWQnY2E28DIi-MY7Jg-6P4VSfs9tuo@z \
    --to=tinfoilsubmarine@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).