[PR PATCH] qView: update to 5.0

[PR PATCH] qView: update to 5.0

[mustaqimM]

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

There is a new pull request by mustaqimM against master on the void-packages repository

https://github.com/mustaqimM/void-packages update_qview
https://github.com/void-linux/void-packages/pull/36391

qView: update to 5.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36391.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update_qview-36391.patch --]
[-- Type: text/x-diff, Size: 949 bytes --]

From a915afa2bb2402d59ef67940c945ef6272e08331 Mon Sep 17 00:00:00 2001
From: mustaqim <git@mustaqim.ml>
Date: Mon, 28 Mar 2022 11:41:06 +0200
Subject: [PATCH] qView: update to 5.0

---
 srcpkgs/qView/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/qView/template b/srcpkgs/qView/template
index 1048d033ab57..6c014d9d3ad0 100644
--- a/srcpkgs/qView/template
+++ b/srcpkgs/qView/template
@@ -1,6 +1,6 @@
 # Template file for 'qView'
 pkgname=qView
-version=4.0
+version=5.0
 revision=1
 build_style=qmake
 hostmakedepends="qt5-host-tools qt5-qmake"
@@ -10,4 +10,4 @@ maintainer="newbluemoon <blaumolch@mailbox.org>"
 license="GPL-3.0-or-later"
 homepage="https://interversehq.com/qview/"
 distfiles="https://github.com/jurplel/qView/archive/${version}.tar.gz"
-checksum=04f986a03bff1b957ac72f266f58a8a7fd403e4606a5bc00ad4a3130d14f11c3
+checksum=c43a69f31c7b5011721c4509093044203fd81edb9046eafa32aa0a6e0846787a

Re: qView: update to 5.0

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/36391#issuecomment-1080981852

Comment:
I haven't updated qView, because I found a little bug which I didn't have the time to investigate, yet: when toggling through a list of pictures (just keep the right or left arrow key pressed) it crashes.
I guess this isn't a show stopper, but it's worth mentioning and not the case with 4.0.

Re: qView: update to 5.0

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/36391#issuecomment-1080981852

Comment:
I haven't updated qView, because I found a little bug which I didn't have the time to investigate, yet: when toggling through a list of pictures (just keep the right or left arrow key pressed) it crashes.
I guess this isn't a show stopper, but it's worth mentioning and not the case with 4.0.

Edit: issue upstream https://github.com/jurplel/qView/issues/490

Re: qView: update to 5.0

[mustaqimM]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

New comment by mustaqimM on void-packages repository

https://github.com/void-linux/void-packages/pull/36391#issuecomment-1082867806

Comment:
@newbluemoon Oh, I see. What do you mean by toggling though? Scrolling next through images? Because I can't reproduce that

Re: qView: update to 5.0

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/36391#issuecomment-1083184847

Comment:
I mean when I view a picture and there are more pictures in the directory in which the current picture resides I can move to the next or previous one with the arrow keys. When I keep changing to the next, to the next, etc. picture a crash occurs after a while (sooner when you keep the arrow key pressed).

Re: qView: update to 5.0

[notramo]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by notramo on void-packages repository

https://github.com/void-linux/void-packages/pull/36391#issuecomment-1111432149

Comment:
@newbluemoon 4.0 is segfaulting on `musl`. I think it should be updated to 5.0. It's better when crashing due to unusual usage than not being able to use it at all.

Re: qView: update to 5.0

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/36391#issuecomment-1111444393

Comment:
@notramo Did you test 5.0 on musl and verify that the segfault is gone?
I have no objections to updating qView to 5.0, just stated what I found. But it's not in my power to merge this PR ;)

Re: qView: update to 5.0

[notramo]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by notramo on void-packages repository

https://github.com/void-linux/void-packages/pull/36391#issuecomment-1111447767

Comment:
5.0 works on musl.

Re: qView: update to 5.0

[notramo]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New comment by notramo on void-packages repository

https://github.com/void-linux/void-packages/pull/36391#issuecomment-1111450303

Comment:
Also, I can't reproduce the quick navigating bug (keeping the arrow keys pressed) bug on musl with small and medium (15-20 megapixels) images.

Re: qView: update to 5.0

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/36391#issuecomment-1112608229

Comment:
Just tested 4.0 and 5.0 on musl. Both run fine without problems and I can confirm that the bug isn't present on musl -- seems to be a problem only on glibc.

Re: qView: update to 5.0

[notramo]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New comment by notramo on void-packages repository

https://github.com/void-linux/void-packages/pull/36391#issuecomment-1113973134

Comment:
I used 4.0 on musl with Wayland (Sway). But I can't test if 4.0 crashes on Xorg too as I have 5.0 installed now.

Re: qView: update to 5.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/36391#issuecomment-1200066490

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: qView: update to 5.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

There's a closed pull request on the void-packages repository

qView: update to 5.0
https://github.com/void-linux/void-packages/pull/36391

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->