Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] pigz: fix tests, add missing executable
@ 2022-08-15 15:35 subnut
  2022-08-15 15:41 ` [PR PATCH] [Updated] " subnut
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: subnut @ 2022-08-15 15:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]

There is a new pull request by subnut against master on the void-packages repository

https://github.com/subnut/void-packages pigz
https://github.com/void-linux/void-packages/pull/38688

pigz: fix tests, add missing executable
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38688.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pigz-38688.patch --]
[-- Type: text/x-diff, Size: 936 bytes --]

From 7aa76ab86219016d871a813f5fca6d971bedce18 Mon Sep 17 00:00:00 2001
From: Subhaditya Nath <sn03.general@gmail.com>
Date: Mon, 15 Aug 2022 21:00:05 +0530
Subject: [PATCH] pigz: fix tests, add missing executable

---
 srcpkgs/pigz/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/pigz/template b/srcpkgs/pigz/template
index eee271a39c2c..1c7dd1d50a94 100644
--- a/srcpkgs/pigz/template
+++ b/srcpkgs/pigz/template
@@ -1,10 +1,11 @@
 # Template file for 'pigz'
 pkgname=pigz
 version=2.7
-revision=1
+revision=2
 build_style=gnu-makefile
 make_check_target=test
 makedepends="zlib-devel"
+checkdepends="which"
 short_desc="Parallel implementation of gzip"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="Zlib"
@@ -15,4 +16,5 @@ checksum=b4c9e60344a08d5db37ca7ad00a5b2c76ccb9556354b722d56d55ca7e8b1c707
 do_install() {
 	vbin pigz
 	vman pigz.1
+	ln -sf pigz "${DESTDIR}/usr/bin/unpigz"
 }

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] pigz: fix tests, add missing executable
  2022-08-15 15:35 [PR PATCH] pigz: fix tests, add missing executable subnut
@ 2022-08-15 15:41 ` subnut
  2022-08-18  6:06 ` [PR REVIEW] " classabbyamp
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: subnut @ 2022-08-15 15:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

There is an updated pull request by subnut against master on the void-packages repository

https://github.com/subnut/void-packages pigz
https://github.com/void-linux/void-packages/pull/38688

pigz: fix tests, add missing executable
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38688.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pigz-38688.patch --]
[-- Type: text/x-diff, Size: 1689 bytes --]

From 3e630ff51496dfb907207bd4f5f72adaa4181956 Mon Sep 17 00:00:00 2001
From: Subhaditya Nath <sn03.general@gmail.com>
Date: Mon, 15 Aug 2022 21:00:05 +0530
Subject: [PATCH] pigz: fix tests, add missing executable

---
 srcpkgs/pigz/patches/fix-tests.patch | 13 +++++++++++++
 srcpkgs/pigz/template                |  3 ++-
 2 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/pigz/patches/fix-tests.patch

diff --git a/srcpkgs/pigz/patches/fix-tests.patch b/srcpkgs/pigz/patches/fix-tests.patch
new file mode 100644
index 000000000000..6e3fd90e3fda
--- /dev/null
+++ b/srcpkgs/pigz/patches/fix-tests.patch
@@ -0,0 +1,13 @@
+--- a/Makefile
++++ b/Makefile
+@@ -90,10 +90,6 @@ test: pigz
+ 	(printf "w" | gzip ; printf "x") | ./pigz -cdf | wc -c | test `cat` -eq 2
+ 	(printf "w" | gzip ; printf "xy") | ./pigz -cdf | wc -c | test `cat` -eq 3
+ 	(printf "w" | gzip ; printf "xyz") | ./pigz -cdf | wc -c | test `cat` -eq 4
+-	-@if test "`which compress | grep /`" != ""; then \
+-	  echo 'compress -f < pigz.c | ./unpigz | cmp - pigz.c' ;\
+-	  compress -f < pigz.c | ./unpigz | cmp - pigz.c ;\
+-	fi
+ 	@rm -f pigz.c.gz pigz.c.zz pigz.c.zip
+ 
+ tests: dev test
diff --git a/srcpkgs/pigz/template b/srcpkgs/pigz/template
index eee271a39c2c..ecd447e7ac92 100644
--- a/srcpkgs/pigz/template
+++ b/srcpkgs/pigz/template
@@ -1,7 +1,7 @@
 # Template file for 'pigz'
 pkgname=pigz
 version=2.7
-revision=1
+revision=2
 build_style=gnu-makefile
 make_check_target=test
 makedepends="zlib-devel"
@@ -15,4 +15,5 @@ checksum=b4c9e60344a08d5db37ca7ad00a5b2c76ccb9556354b722d56d55ca7e8b1c707
 do_install() {
 	vbin pigz
 	vman pigz.1
+	ln -sf pigz "${DESTDIR}/usr/bin/unpigz"
 }

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] pigz: fix tests, add missing executable
  2022-08-15 15:35 [PR PATCH] pigz: fix tests, add missing executable subnut
  2022-08-15 15:41 ` [PR PATCH] [Updated] " subnut
@ 2022-08-18  6:06 ` classabbyamp
  2022-08-18  6:07 ` classabbyamp
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-08-18  6:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38688#discussion_r948687475

Comment:
does it need the `-f`?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] pigz: fix tests, add missing executable
  2022-08-15 15:35 [PR PATCH] pigz: fix tests, add missing executable subnut
  2022-08-15 15:41 ` [PR PATCH] [Updated] " subnut
  2022-08-18  6:06 ` [PR REVIEW] " classabbyamp
@ 2022-08-18  6:07 ` classabbyamp
  2022-08-18  6:11 ` classabbyamp
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-08-18  6:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38688#discussion_r948687475

Comment:
does it need the `-f`?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] pigz: fix tests, add missing executable
  2022-08-15 15:35 [PR PATCH] pigz: fix tests, add missing executable subnut
                   ` (2 preceding siblings ...)
  2022-08-18  6:07 ` classabbyamp
@ 2022-08-18  6:11 ` classabbyamp
  2022-08-18 13:01 ` leahneukirchen
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-08-18  6:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38688#discussion_r948690465

Comment:
is `-f` needed?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: pigz: fix tests, add missing executable
  2022-08-15 15:35 [PR PATCH] pigz: fix tests, add missing executable subnut
                   ` (3 preceding siblings ...)
  2022-08-18  6:11 ` classabbyamp
@ 2022-08-18 13:01 ` leahneukirchen
  2022-08-19  4:36 ` [PR PATCH] [Updated] " subnut
  2022-08-19  4:38 ` [PR PATCH] [Merged]: " classabbyamp
  6 siblings, 0 replies; 8+ messages in thread
From: leahneukirchen @ 2022-08-18 13:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/38688#issuecomment-1219465552

Comment:
checkmakedepends="which" would be easier than patching i think

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] pigz: fix tests, add missing executable
  2022-08-15 15:35 [PR PATCH] pigz: fix tests, add missing executable subnut
                   ` (4 preceding siblings ...)
  2022-08-18 13:01 ` leahneukirchen
@ 2022-08-19  4:36 ` subnut
  2022-08-19  4:38 ` [PR PATCH] [Merged]: " classabbyamp
  6 siblings, 0 replies; 8+ messages in thread
From: subnut @ 2022-08-19  4:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

There is an updated pull request by subnut against master on the void-packages repository

https://github.com/subnut/void-packages pigz
https://github.com/void-linux/void-packages/pull/38688

pigz: fix tests, add missing executable
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38688.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pigz-38688.patch --]
[-- Type: text/x-diff, Size: 1093 bytes --]

From 0b67ba6001de752c1ad769ad8f8a7d216e43eea0 Mon Sep 17 00:00:00 2001
From: Subhaditya Nath <sn03.general@gmail.com>
Date: Mon, 15 Aug 2022 21:00:05 +0530
Subject: [PATCH] pigz: fix tests, add missing executable, adopt

---
 srcpkgs/pigz/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/pigz/template b/srcpkgs/pigz/template
index eee271a39c2c..a27806915305 100644
--- a/srcpkgs/pigz/template
+++ b/srcpkgs/pigz/template
@@ -1,12 +1,13 @@
 # Template file for 'pigz'
 pkgname=pigz
 version=2.7
-revision=1
+revision=2
 build_style=gnu-makefile
 make_check_target=test
 makedepends="zlib-devel"
+checkdepends="which"
 short_desc="Parallel implementation of gzip"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Subhaditya Nath <sn03.general@gmail.com>"
 license="Zlib"
 homepage="https://zlib.net/pigz/"
 distfiles="https://zlib.net/pigz/pigz-${version}.tar.gz"
@@ -15,4 +16,5 @@ checksum=b4c9e60344a08d5db37ca7ad00a5b2c76ccb9556354b722d56d55ca7e8b1c707
 do_install() {
 	vbin pigz
 	vman pigz.1
+	ln -s pigz "${DESTDIR}/usr/bin/unpigz"
 }

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Merged]: pigz: fix tests, add missing executable
  2022-08-15 15:35 [PR PATCH] pigz: fix tests, add missing executable subnut
                   ` (5 preceding siblings ...)
  2022-08-19  4:36 ` [PR PATCH] [Updated] " subnut
@ 2022-08-19  4:38 ` classabbyamp
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-08-19  4:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]

There's a merged pull request on the void-packages repository

pigz: fix tests, add missing executable
https://github.com/void-linux/void-packages/pull/38688

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-08-19  4:38 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-15 15:35 [PR PATCH] pigz: fix tests, add missing executable subnut
2022-08-15 15:41 ` [PR PATCH] [Updated] " subnut
2022-08-18  6:06 ` [PR REVIEW] " classabbyamp
2022-08-18  6:07 ` classabbyamp
2022-08-18  6:11 ` classabbyamp
2022-08-18 13:01 ` leahneukirchen
2022-08-19  4:36 ` [PR PATCH] [Updated] " subnut
2022-08-19  4:38 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).