Github messages for voidlinux
 help / color / mirror / Atom feed
From: icp1994 <icp1994@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] beancount: update to 2.3.5; fava: update to 1.22.3.
Date: Thu, 18 Aug 2022 18:34:24 +0200	[thread overview]
Message-ID: <20220818163424.LU5EZnmGy-OhAPNwZEUy9FkiqU0tFGZphzEAbM6slv8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38708@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/38708#discussion_r949368060

Comment:
It seems to be used in [this module](https://github.com/beancount/beancount/blob/2.3.5/beancount/ingest/regression_pytest.py). If you see the master branch [`setup.py`](https://github.com/beancount/beancount/blob/master/setup.py#L80-L96) pytest got removed because now there is no [ingest module](https://github.com/beancount/beancount/tree/master/beancount/ingest)! So I'm assuming that's related.

  parent reply	other threads:[~2022-08-18 16:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16 14:47 [PR PATCH] " icp1994
2022-08-18  3:24 ` [PR REVIEW] " classabbyamp
2022-08-18 13:12 ` icp1994
2022-08-18 16:16 ` classabbyamp
2022-08-18 16:34 ` icp1994 [this message]
2022-08-18 16:42 ` classabbyamp
2022-08-18 16:51 ` icp1994
2022-08-18 17:15 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220818163424.LU5EZnmGy-OhAPNwZEUy9FkiqU0tFGZphzEAbM6slv8@z \
    --to=icp1994@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).