Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] boost: fix build for glibc 2.34
@ 2022-08-19 18:14 oreo639
  2022-08-20 11:27 ` [PR PATCH] [Closed]: " sgn
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: oreo639 @ 2022-08-19 18:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

There is a new pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages boost
https://github.com/void-linux/void-packages/pull/38784

boost: fix build for glibc 2.34
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38784.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-boost-38784.patch --]
[-- Type: text/x-diff, Size: 3676 bytes --]

From b18f21763c9a9b379cd45c3fcfffb3706cfcc80b Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Fri, 19 Aug 2022 11:13:29 -0700
Subject: [PATCH] boost: fix build for glibc 2.34

---
 .../patches/0001-compat-glibc-2.34.patch      | 23 ++++++++++++++
 .../patches/0002-compat-glibc-2.34.patch      | 30 +++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 srcpkgs/boost/patches/0001-compat-glibc-2.34.patch
 create mode 100644 srcpkgs/boost/patches/0002-compat-glibc-2.34.patch

diff --git a/srcpkgs/boost/patches/0001-compat-glibc-2.34.patch b/srcpkgs/boost/patches/0001-compat-glibc-2.34.patch
new file mode 100644
index 000000000000..e1e5711e59f2
--- /dev/null
+++ b/srcpkgs/boost/patches/0001-compat-glibc-2.34.patch
@@ -0,0 +1,23 @@
+From 74fb0a26099bc51d717f5f154b37231ce7df3e98 Mon Sep 17 00:00:00 2001
+From: Rob Boehne <robb@datalogics.com>
+Date: Wed, 20 Nov 2019 11:25:20 -0600
+Subject: [PATCH] Revert change to elide a warning that caused Solaris builds
+ to fail.
+
+---
+ include/boost/thread/pthread/thread_data.hpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/include/boost/thread/pthread/thread_data.hpp b/include/boost/thread/pthread/thread_data.hpp
+index aefbeb43c..bc9b1367a 100644
+--- a/boost/thread/pthread/thread_data.hpp
++++ b/boost/thread/pthread/thread_data.hpp
+@@ -57,7 +57,7 @@ namespace boost
+ #else
+           std::size_t page_size = ::sysconf( _SC_PAGESIZE);
+ #endif
+-#if PTHREAD_STACK_MIN > 0
++#ifdef PTHREAD_STACK_MIN
+           if (size<PTHREAD_STACK_MIN) size=PTHREAD_STACK_MIN;
+ #endif
+           size = ((size+page_size-1)/page_size)*page_size;
diff --git a/srcpkgs/boost/patches/0002-compat-glibc-2.34.patch b/srcpkgs/boost/patches/0002-compat-glibc-2.34.patch
new file mode 100644
index 000000000000..baf7c517f8b4
--- /dev/null
+++ b/srcpkgs/boost/patches/0002-compat-glibc-2.34.patch
@@ -0,0 +1,30 @@
+From f9d0e594d43afcb4ab0043117249feb266ba4515 Mon Sep 17 00:00:00 2001
+From: Romain Geissler <romain.geissler@amadeus.com>
+Date: Tue, 10 Aug 2021 14:22:28 +0000
+Subject: [PATCH] Fix -Wsign-compare warning with glibc 2.34 on Linux
+ platforms.
+
+In file included from /data/mwrep/res/osp/Boost/21-0-0-0/include/boost/thread/thread_only.hpp:17,
+                 from /data/mwrep/res/osp/Boost/21-0-0-0/include/boost/thread/thread.hpp:12,
+                 from src/GetTest.cpp:12:
+/data/mwrep/res/osp/Boost/21-0-0-0/include/boost/thread/pthread/thread_data.hpp: In member function 'void boost::thread_attributes::set_stack_size(std::size_t)':
+/data/mwrep/res/osp/Boost/21-0-0-0/include/boost/thread/pthread/thread_data.hpp:61:19: error: comparison of integer expressions of different signedness: 'std::size_t' {aka 'long unsigned int'} and 'long int' [-Werror=sign-compare]
+   61 |           if (size<PTHREAD_STACK_MIN) size=PTHREAD_STACK_MIN;
+      |                   ^
+---
+ include/boost/thread/pthread/thread_data.hpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/include/boost/thread/pthread/thread_data.hpp b/include/boost/thread/pthread/thread_data.hpp
+index bc9b1367a..c43b276d1 100644
+--- a/boost/thread/pthread/thread_data.hpp
++++ b/boost/thread/pthread/thread_data.hpp
+@@ -58,7 +58,7 @@ namespace boost
+           std::size_t page_size = ::sysconf( _SC_PAGESIZE);
+ #endif
+ #ifdef PTHREAD_STACK_MIN
+-          if (size<PTHREAD_STACK_MIN) size=PTHREAD_STACK_MIN;
++          if (size<static_cast<std::size_t>(PTHREAD_STACK_MIN)) size=PTHREAD_STACK_MIN;
+ #endif
+           size = ((size+page_size-1)/page_size)*page_size;
+           int res = pthread_attr_setstacksize(&val_, size);

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: boost: fix build for glibc 2.34
  2022-08-19 18:14 [PR PATCH] boost: fix build for glibc 2.34 oreo639
@ 2022-08-20 11:27 ` sgn
  2022-08-20 11:27 ` sgn
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2022-08-20 11:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

There's a closed pull request on the void-packages repository

boost: fix build for glibc 2.34
https://github.com/void-linux/void-packages/pull/38784

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: boost: fix build for glibc 2.34
  2022-08-19 18:14 [PR PATCH] boost: fix build for glibc 2.34 oreo639
  2022-08-20 11:27 ` [PR PATCH] [Closed]: " sgn
@ 2022-08-20 11:27 ` sgn
  2022-08-20 13:22 ` classabbyamp
  2022-08-21  2:14 ` sgn
  3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2022-08-20 11:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38784#issuecomment-1221297318

Comment:
This change needs revision bump.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: boost: fix build for glibc 2.34
  2022-08-19 18:14 [PR PATCH] boost: fix build for glibc 2.34 oreo639
  2022-08-20 11:27 ` [PR PATCH] [Closed]: " sgn
  2022-08-20 11:27 ` sgn
@ 2022-08-20 13:22 ` classabbyamp
  2022-08-21  2:14 ` sgn
  3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2022-08-20 13:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38784#issuecomment-1221314258

Comment:
> This change needs revision bump.

wouldn't that make more sense after the glibc update happens? 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: boost: fix build for glibc 2.34
  2022-08-19 18:14 [PR PATCH] boost: fix build for glibc 2.34 oreo639
                   ` (2 preceding siblings ...)
  2022-08-20 13:22 ` classabbyamp
@ 2022-08-21  2:14 ` sgn
  3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2022-08-21  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38784#issuecomment-1221451538

Comment:
The header files were changed, someone may have glibc 2.34 build and installed already, as if someone here running musl 1.2.x already.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-08-21  2:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-19 18:14 [PR PATCH] boost: fix build for glibc 2.34 oreo639
2022-08-20 11:27 ` [PR PATCH] [Closed]: " sgn
2022-08-20 11:27 ` sgn
2022-08-20 13:22 ` classabbyamp
2022-08-21  2:14 ` sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).