From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: common/build-style/gnu-makefile.sh: define prefix, PREFIX for build
Date: Mon, 22 Aug 2022 14:09:27 +0200 [thread overview]
Message-ID: <20220822120927.TsnbWcAWDc7gn3Nb-m6ONmLVuq3clxXHSq3yWhjxOVg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38823@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 465 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/38823#issuecomment-1222266745
Comment:
Can you mention in the commit message that this allows us to remove the definition from other templates, and that it avoids having to catch every time something needs PREFIX defined there? That history won't always be obvious.
I would already go with an additional `srcpkgs/:` commit removing it from templates as well.
next prev parent reply other threads:[~2022-08-22 12:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 4:42 [PR PATCH] " classabbyamp
2022-08-22 5:22 ` [PR REVIEW] " sgn
2022-08-22 5:28 ` [PR PATCH] [Updated] " classabbyamp
2022-08-22 12:09 ` ericonr [this message]
2022-08-22 22:58 ` classabbyamp
2022-08-22 23:00 ` classabbyamp
2022-08-22 23:05 ` [PR PATCH] [Updated] " classabbyamp
2022-08-24 6:27 ` classabbyamp
2022-08-24 19:06 ` classabbyamp
2022-08-24 19:07 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822120927.TsnbWcAWDc7gn3Nb-m6ONmLVuq3clxXHSq3yWhjxOVg@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).