From: oreo639 <oreo639@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] {gmpc,libmpd}: remove package
Date: Wed, 24 Aug 2022 03:01:52 +0200 [thread overview]
Message-ID: <20220824010152.vYwheTsEzVvZ7MkK4rYugccTWEM0jd5ELdLgLEDIaLU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38866@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1552 bytes --]
There is an updated pull request by oreo639 against master on the void-packages repository
https://github.com/oreo639/void-packages gmpc
https://github.com/void-linux/void-packages/pull/38866
{gmpc,libmpd}: remove package
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
gmpc is unmaintained and hasn't seen a release since 2011 and the homepage is now a parked domain.
This is necessary to remove libunique1/libunique which have been deprecated for a long time and are erroneously included by a few packages (will be fixed in separate PRs).
It also depends on gtk2.
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38866.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gmpc-38866.patch --]
[-- Type: text/x-diff, Size: 7164 bytes --]
From 5dce71319e732698846b5481b8538748a66e64ad Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Tue, 23 Aug 2022 16:09:10 -0700
Subject: [PATCH 1/2] gmpc: remove package
Unmaintained, hasn't seen a release since 2011 and the homepage
is a parked domain.
Still depends on gtk2 and libunique1.
---
srcpkgs/gmpc-devel | 1 -
srcpkgs/gmpc/patches/locale-dir.patch | 20 -----------------
srcpkgs/gmpc/patches/no-mallard-check.patch | 22 ------------------
srcpkgs/gmpc/template | 25 ---------------------
srcpkgs/removed-packages/template | 2 ++
5 files changed, 2 insertions(+), 68 deletions(-)
delete mode 120000 srcpkgs/gmpc-devel
delete mode 100644 srcpkgs/gmpc/patches/locale-dir.patch
delete mode 100644 srcpkgs/gmpc/patches/no-mallard-check.patch
delete mode 100644 srcpkgs/gmpc/template
diff --git a/srcpkgs/gmpc-devel b/srcpkgs/gmpc-devel
deleted file mode 120000
index 6a1f09135ead..000000000000
--- a/srcpkgs/gmpc-devel
+++ /dev/null
@@ -1 +0,0 @@
-gmpc
\ No newline at end of file
diff --git a/srcpkgs/gmpc/patches/locale-dir.patch b/srcpkgs/gmpc/patches/locale-dir.patch
deleted file mode 100644
index 8398823dd765..000000000000
--- a/srcpkgs/gmpc/patches/locale-dir.patch
+++ /dev/null
@@ -1,20 +0,0 @@
---- a/configure
-+++ b/configure
-@@ -11347,7 +11347,7 @@ fi
-
- ;;
- *)
-- DATADIRNAME=lib
-+ DATADIRNAME=share
- ;;
- esac
- fi
-@@ -15026,7 +15026,7 @@ fi
- ;;
- *)
- CATOBJEXT=.mo
-- DATADIRNAME=lib
-+ DATADIRNAME=share
- ;;
- esac
- fi
diff --git a/srcpkgs/gmpc/patches/no-mallard-check.patch b/srcpkgs/gmpc/patches/no-mallard-check.patch
deleted file mode 100644
index f36891f28498..000000000000
--- a/srcpkgs/gmpc/patches/no-mallard-check.patch
+++ /dev/null
@@ -1,22 +0,0 @@
---- a/doc/Makefile.am
-+++ b/doc/Makefile.am
-@@ -1,7 +1,7 @@
- man_MANS = gmpc.1 gmpc-remote.1 gmpc-remote-stream.1
- EXTRA_DIST = $(man_MANS)
-
--SUBDIRS=Mallard
-+SUBDIRS=
-
- .PHONY: doc
- doc: Manual.txt
---- a/doc/Makefile.in
-+++ b/doc/Makefile.in
-@@ -311,7 +311,7 @@ unique_CFLAGS = @unique_CFLAGS@
- unique_LIBS = @unique_LIBS@
- man_MANS = gmpc.1 gmpc-remote.1 gmpc-remote-stream.1
- EXTRA_DIST = $(man_MANS)
--SUBDIRS = Mallard
-+SUBDIRS =
- all: all-recursive
-
- .SUFFIXES:
diff --git a/srcpkgs/gmpc/template b/srcpkgs/gmpc/template
deleted file mode 100644
index ec0c03ade913..000000000000
--- a/srcpkgs/gmpc/template
+++ /dev/null
@@ -1,25 +0,0 @@
-# Template file for 'gmpc'
-pkgname=gmpc
-version=11.8.16
-revision=3
-build_style=gnu-configure
-hostmakedepends="pkg-config gob2 intltool vala"
-makedepends="gtk+-devel libSM-devel libmpd-devel libunique1-devel libsoup-devel sqlite-devel"
-depends="xdg-utils hicolor-icon-theme"
-short_desc="Gnome Music Player Client - The true MPD client"
-maintainer="Dave Davenport <qball@gmpclient.org>"
-license="GPL-2.0-or-later"
-homepage="http://gmpclient.org/"
-distfiles="http://download.sarine.nl/Programs/gmpc/${version%.*}/gmpc-${version}.tar.gz"
-checksum=a69414f35396846733632ca9619921d7acda537ffd6d49bd84b444945cb76b2c
-
-LDFLAGS="-lm"
-
-gmpc-devel_package() {
- short_desc+=" - development files"
- depends="gtk+-devel libmpd-devel"
- pkg_install() {
- vmove usr/include
- vmove usr/lib/pkgconfig
- }
-}
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 67261247a6a4..de4f85e1345c 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -97,6 +97,8 @@ replaces="
giti<=1.0.0_1
gksu<=2.0.2_4
glibmm-doc<=2.64.2_2
+ gmpc-devel<=11.8.16_3
+ gmpc<=11.8.16_3
gnome-doc-utils<=0.20.10_9
gnome-documents<=3.34.0_2
gnome-games<=40.0_1
From 8ff13618f112e48dd1817d88725c9f0c3e7a35f0 Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Tue, 23 Aug 2022 16:13:39 -0700
Subject: [PATCH 2/2] libmpd: remove package
Unmaintained, hasn't seen a release since 2011 and the homepage
is a parked domain.
Still depends on libunique1.
---
common/shlibs | 1 -
srcpkgs/libmpd-devel | 1 -
srcpkgs/libmpd/patches/fix-build.patch | 13 -------------
srcpkgs/libmpd/template | 24 ------------------------
srcpkgs/removed-packages/template | 2 ++
5 files changed, 2 insertions(+), 39 deletions(-)
delete mode 120000 srcpkgs/libmpd-devel
delete mode 100644 srcpkgs/libmpd/patches/fix-build.patch
delete mode 100644 srcpkgs/libmpd/template
diff --git a/common/shlibs b/common/shlibs
index f829ee12e80f..18e4fc1d7ac7 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -2532,7 +2532,6 @@ libKF5Solid.so.5 libksolid-5.15.0_2
libfreeimage.so.3 freeimage-3.17.0_1
libfreeimageplus.so.3 freeimage-plus-3.17.0_1
libtoluapp.so toluapp-1.0.93_1
-libmpd.so.1 libmpd-11.8.17_1
libfa.so.1 augeas-1.4.0_1
libaugeas.so.0 augeas-1.4.0_1
libplot.so.2 plotutils-2.6_1
diff --git a/srcpkgs/libmpd-devel b/srcpkgs/libmpd-devel
deleted file mode 120000
index 385a94df2454..000000000000
--- a/srcpkgs/libmpd-devel
+++ /dev/null
@@ -1 +0,0 @@
-libmpd
\ No newline at end of file
diff --git a/srcpkgs/libmpd/patches/fix-build.patch b/srcpkgs/libmpd/patches/fix-build.patch
deleted file mode 100644
index 5f4d86644538..000000000000
--- a/srcpkgs/libmpd/patches/fix-build.patch
+++ /dev/null
@@ -1,13 +0,0 @@
---- a/src/libmpd-internal.h 2015-11-05 15:05:11.982772276 +0100
-+++ b/src/libmpd-internal.h 2015-11-05 15:05:32.845719672 +0100
-@@ -20,6 +20,10 @@
- #ifndef __MPD_INTERNAL_LIB_
- #define __MPD_INTERNAL_LIB_
-
-+#ifdef HAVE_CONFIG_H
-+#include "config.h"
-+#endif
-+
- #include "libmpdclient.h"
- struct _MpdData_real;
-
diff --git a/srcpkgs/libmpd/template b/srcpkgs/libmpd/template
deleted file mode 100644
index 608057b0232a..000000000000
--- a/srcpkgs/libmpd/template
+++ /dev/null
@@ -1,24 +0,0 @@
-# Template file for 'libmpd'
-pkgname=libmpd
-version=11.8.17
-revision=3
-build_style=gnu-configure
-hostmakedepends="pkg-config"
-makedepends="libglib-devel"
-short_desc="Signal based wrapper around libmpdclient"
-maintainer="Dave Davenport <qball@gmpclient.org>"
-license="GPL-2.0-or-later"
-homepage="http://gmpc.wikia.com/wiki/Gnome_Music_Player_Client"
-distfiles="http://download.sarine.nl/Programs/gmpc/${version%.*}/${pkgname}-${version}.tar.gz"
-checksum=fe20326b0d10641f71c4673fae637bf9222a96e1712f71f170fca2fc34bf7a83
-
-libmpd-devel_package() {
- short_desc+=" - development files"
- depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
- pkg_install() {
- vmove usr/include
- vmove usr/lib/pkgconfig
- vmove usr/lib/*.a
- vmove usr/lib/*.so
- }
-}
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index de4f85e1345c..e5d188141ea4 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -237,6 +237,8 @@ replaces="
libmagick6-devel<=6.9.12.12_2
libmagick6-perl<=6.9.12.12_2
libmagick6<=6.9.12.12_2
+ libmpd-devel<=11.8.17_3
+ libmpd<=11.8.17_3
libpyside-python3<=5.15.0_2
libqmatrixclient-devel<=0.5.3.2_1
libqmatrixclient<=0.5.3.2_1
next prev parent reply other threads:[~2022-08-24 1:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 23:14 [PR PATCH] Gmpc oreo639
2022-08-23 23:21 ` [PR PATCH] [Updated] {gmpc,libmpd}: remove package oreo639
2022-08-24 0:08 ` oreo639
2022-08-24 0:43 ` oreo639
2022-08-24 1:01 ` oreo639 [this message]
2022-08-24 3:30 ` classabbyamp
2022-08-24 3:30 ` [PR PATCH] [Closed]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220824010152.vYwheTsEzVvZ7MkK4rYugccTWEM0jd5ELdLgLEDIaLU@z \
--to=oreo639@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).