Github messages for voidlinux
 help / color / mirror / Atom feed
From: oreo639 <oreo639@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] ario: remove unused dependency on libunique1
Date: Wed, 24 Aug 2022 03:46:46 +0200	[thread overview]
Message-ID: <20220824014646.kDsgs-YQMjU9LWM7SrOVzRhCgnOu-6BKVU-5jo4Wzuo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38869@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages ario
https://github.com/void-linux/void-packages/pull/38869

ario: remove unused dependency on libunique1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

cc: @leahneukirchen 

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38869.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ario-38869.patch --]
[-- Type: text/x-diff, Size: 1393 bytes --]

From fd81469af7600c7d6b25307a15866077d30a89eb Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Tue, 23 Aug 2022 16:32:20 -0700
Subject: [PATCH] ario: remove unused dependency on libunique1

---
 srcpkgs/ario/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ario/template b/srcpkgs/ario/template
index c9fc6f3cd9b7..ce6c01e518ce 100644
--- a/srcpkgs/ario/template
+++ b/srcpkgs/ario/template
@@ -6,15 +6,16 @@ build_style=gnu-configure
 configure_args="--disable-static"
 hostmakedepends="pkg-config intltool"
 makedepends="avahi-glib-libs-devel dbus-glib-devel gnutls-devel gtk+3-devel
- libcurl-devel libmpdclient-devel libnotify-devel libunique1-devel taglib-devel"
+ libcurl-devel libmpdclient-devel libnotify-devel taglib-devel"
 short_desc="GTK client for MPD"
 maintainer="Leah Neukirchen <leah@vuxu.org>"
-license="GPL-2"
+license="GPL-2.0-or-later"
 homepage="http://ario-player.sourceforge.net/?en"
 distfiles="${SOURCEFORGE_SITE}/${pkgname}-player/${pkgname}-${version}.tar.gz"
 checksum=1442ede8eef994384489d72d028d7f7b1a1c81efe737f7147587dd02c772d09a
+make_check=no # Tests still depend on build files that have been removed by upstream
 
-post_extract() {
+post_patch() {
 	vsed -i 's,<glib/gi18n.h>,<glib.h>,g' src/ario-profiles.c
 	vsed -i -e 's/DATADIRNAME=lib/DATADIRNAME=share/' configure
 }

  parent reply	other threads:[~2022-08-24  1:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 23:32 [PR PATCH] " oreo639
2022-08-23 23:35 ` [PR PATCH] [Updated] " oreo639
2022-08-23 23:47 ` oreo639
2022-08-23 23:49 ` oreo639
2022-08-23 23:49 ` oreo639
2022-08-24  1:45 ` [PR PATCH] [Updated] " oreo639
2022-08-24  1:45 ` oreo639
2022-08-24  1:46 ` oreo639 [this message]
2022-08-24  2:11 ` oreo639
2022-08-24  3:29 ` classabbyamp
2022-08-24  3:29 ` [PR PATCH] [Closed]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220824014646.kDsgs-YQMjU9LWM7SrOVzRhCgnOu-6BKVU-5jo4Wzuo@z \
    --to=oreo639@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).