Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] recoll: update to 1.32.7.
@ 2022-08-25 11:52 dmarto
  2022-08-25 17:06 ` [PR REVIEW] " classabbyamp
                   ` (22 more replies)
  0 siblings, 23 replies; 24+ messages in thread
From: dmarto @ 2022-08-25 11:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

There is a new pull request by dmarto against master on the void-packages repository

https://github.com/dmarto/void-packages recoll
https://github.com/void-linux/void-packages/pull/38902

recoll: update to 1.32.7.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

---

- enable python module 
- update version check page
- explicit conf args
- proper (host)makedepends
- update musl patches

A patch file from https://github.com/void-linux/void-packages/pull/38902.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-recoll-38902.patch --]
[-- Type: text/x-diff, Size: 4280 bytes --]

From 1f27bc691138fe1c6ce217fc2b3358bba5b6dc59 Mon Sep 17 00:00:00 2001
From: Martin Dimov <martin@dmarto.com>
Date: Thu, 25 Aug 2022 03:30:03 +0300
Subject: [PATCH] recoll: update to 1.32.7.

- enable python module
- update version check page
- explicit conf args
- proper (host)makedepends
- update musl patches
---
 srcpkgs/recoll/patches/musl.patch | 39 ++++++++++++++++++++++---------
 srcpkgs/recoll/template           | 19 ++++++++-------
 srcpkgs/recoll/update             |  2 +-
 3 files changed, 40 insertions(+), 20 deletions(-)

diff --git a/srcpkgs/recoll/patches/musl.patch b/srcpkgs/recoll/patches/musl.patch
index c83d0f553c8a..d633e92b9df1 100644
--- a/srcpkgs/recoll/patches/musl.patch
+++ b/srcpkgs/recoll/patches/musl.patch
@@ -1,5 +1,5 @@
-Index: utils/fstreewalk.cpp
-===================================================================
+diff --git a/utils/fstreewalk.cpp b/utils/fstreewalk.cpp
+index fc43edc..5e28d6e 100644
 --- a/utils/fstreewalk.cpp
 +++ b/utils/fstreewalk.cpp
 @@ -17,6 +17,7 @@
@@ -10,16 +10,33 @@ Index: utils/fstreewalk.cpp
  #include <stdio.h>
  
  #include <errno.h>
-Index: utils/pxattr.cpp
-===================================================================
---- a/utils/pxattr.cpp	2017-07-03 14:14:46.000000000 +0200
-+++ b/utils/pxattr.cpp	2017-12-17 14:34:29.955674837 +0100
-@@ -44,7 +44,7 @@
- // just let the methods return errors (like they would on a non-xattr
- // fs on e.g. linux)
+diff --git a/utils/pxattr.cpp b/utils/pxattr.cpp
+index 3a1f8f5..dcb93fc 100644
+--- a/utils/pxattr.cpp
++++ b/utils/pxattr.cpp
+@@ -46,7 +46,7 @@
  
--#if defined(__DragonFly__) || defined(__OpenBSD__)
-+#if defined(__DragonFly__) || defined(__OpenBSD__) || !defined(__GLIBC__)
+ // Not exactly true for win32, but makes my life easier by avoiding ifdefs in recoll (the calls just
+ // fail, which is expected)
+-#if defined(__DragonFly__) || defined(__OpenBSD__) || defined(_WIN32)
++#if defined(__DragonFly__) || defined(__OpenBSD__) || defined(_WIN32) || !defined(__GLIBC__)
  #define HAS_NO_XATTR
  #endif
+
+diff --git a/common/conf_post.h b/common/conf_post.h
+index 7093ead..0ecd56b 100644
+--- a/common/conf_post.h
++++ b/common/conf_post.h
+@@ -73,12 +73,4 @@ typedef int ssize_t;
+ #define REAL_GCC   __GNUC__ // probably
+ #endif
  
+-#ifdef REAL_GCC
+-// Older gcc versions pretended to supply std::regex, but the resulting programs mostly crashed.
+-#include <features.h>
+-#if ! __GNUC_PREREQ(6,0)
+-#define NO_STD_REGEX 1
+-#endif
+-#endif
+-
+ #endif /* INCLUDED */
diff --git a/srcpkgs/recoll/template b/srcpkgs/recoll/template
index 8c5de6966a46..61cf006d7a0f 100644
--- a/srcpkgs/recoll/template
+++ b/srcpkgs/recoll/template
@@ -1,18 +1,21 @@
 # Template file for 'recoll'
 pkgname=recoll
-version=1.30.0
+version=1.32.7
 revision=1
 build_style=gnu-configure
 build_helper=qmake
-configure_args="--disable-python-module --disable-python-chm
- --enable-recollq --disable-x11mon"
-hostmakedepends="automake libtool gettext-devel qt5-qmake pkg-config
- qt5-host-tools"
-makedepends="xapian-core-devel zlib-devel libuuid-devel qt5-webkit-devel qt5-devel
- aspell-devel libxslt-devel libxml2-devel"
+configure_args="--enable-recollq --disable-python-chm --disable-x11mon
+ --disable-webkit --without-systemd"
+hostmakedepends="pkg-config gettext-devel qt5-qmake qt5-host-tools
+ which python3-setuptools python3-devel"
+makedepends="libxslt-devel xapian-core-devel zlib-devel qt5-devel"
 short_desc="Full text search tool based on Xapian backend"
 maintainer="Rui Abreu Ferreira <raf-ep@gmx.com>"
 license="GPL-2.0-or-later"
 homepage="https://www.lesbonscomptes.com/recoll/"
 distfiles="https://www.lesbonscomptes.com/${pkgname}/${pkgname}-${version}.tar.gz"
-checksum=17a8e684a8d5560dc7b44cd4b2962cb46476a75bdc107f622051235076d11885
+checksum=ca08a6f4bb0b519bf915a062a9b7aadc4f343473cc1f07895708208d66337dba
+
+if [ "$XBPS_WORDSIZE" != "$XBPS_TARGET_WORDSIZE" ]; then
+	nocross="setup.py can not configure proper cross"
+fi
diff --git a/srcpkgs/recoll/update b/srcpkgs/recoll/update
index dcc285e571f0..afe7c791114e 100644
--- a/srcpkgs/recoll/update
+++ b/srcpkgs/recoll/update
@@ -1 +1 @@
-site="https://www.lesbonscomptes.com/recoll/download.html"
+site="https://www.lesbonscomptes.com/recoll/pages/download.html"

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
@ 2022-08-25 17:06 ` classabbyamp
  2022-08-25 17:09 ` classabbyamp
                   ` (21 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2022-08-25 17:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955223759

Comment:
does `--without-systemd` change anything in the program logic other than just not installing systemd unit files? If it's just unit files, let's leave them there because this package doesn't have a runit service already

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
  2022-08-25 17:06 ` [PR REVIEW] " classabbyamp
@ 2022-08-25 17:09 ` classabbyamp
  2022-08-25 17:11 ` classabbyamp
                   ` (20 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2022-08-25 17:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955225578

Comment:
does adding python3-devel to makedepends help with the nocross?

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
  2022-08-25 17:06 ` [PR REVIEW] " classabbyamp
  2022-08-25 17:09 ` classabbyamp
@ 2022-08-25 17:11 ` classabbyamp
  2022-08-25 17:33 ` dmarto
                   ` (19 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2022-08-25 17:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955228054

Comment:
expand $pkgname here

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (2 preceding siblings ...)
  2022-08-25 17:11 ` classabbyamp
@ 2022-08-25 17:33 ` dmarto
  2022-08-25 17:33 ` dmarto
                   ` (18 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-08-25 17:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New review comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955246033

Comment:
based on my tests, it breaks cross under arm8+

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (3 preceding siblings ...)
  2022-08-25 17:33 ` dmarto
@ 2022-08-25 17:33 ` dmarto
  2022-08-25 17:35 ` [PR PATCH] [Updated] " dmarto
                   ` (17 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-08-25 17:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

New review comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955246762

Comment:
it is implicitly enabled by the confs (they are looking for systemd paths/files); so I just added it explicitly (in case something changes) 

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (4 preceding siblings ...)
  2022-08-25 17:33 ` dmarto
@ 2022-08-25 17:35 ` dmarto
  2022-08-25 17:35 ` [PR REVIEW] " dmarto
                   ` (16 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-08-25 17:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

There is an updated pull request by dmarto against master on the void-packages repository

https://github.com/dmarto/void-packages recoll
https://github.com/void-linux/void-packages/pull/38902

recoll: update to 1.32.7.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

---

- enable python module 
- update version check page
- explicit conf args
- proper (host)makedepends
- update musl patches

A patch file from https://github.com/void-linux/void-packages/pull/38902.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-recoll-38902.patch --]
[-- Type: text/x-diff, Size: 4358 bytes --]

From 993ccf4d87b817257fe958666b6e2927d92a86d0 Mon Sep 17 00:00:00 2001
From: Martin Dimov <martin@dmarto.com>
Date: Thu, 25 Aug 2022 03:30:03 +0300
Subject: [PATCH] recoll: update to 1.32.7.

- enable python module
- update version check page
- explicit conf args
- proper (host)makedepends
- update musl patches
---
 srcpkgs/recoll/patches/musl.patch | 39 ++++++++++++++++++++++---------
 srcpkgs/recoll/template           | 21 ++++++++++-------
 srcpkgs/recoll/update             |  2 +-
 3 files changed, 41 insertions(+), 21 deletions(-)

diff --git a/srcpkgs/recoll/patches/musl.patch b/srcpkgs/recoll/patches/musl.patch
index c83d0f553c8a..d633e92b9df1 100644
--- a/srcpkgs/recoll/patches/musl.patch
+++ b/srcpkgs/recoll/patches/musl.patch
@@ -1,5 +1,5 @@
-Index: utils/fstreewalk.cpp
-===================================================================
+diff --git a/utils/fstreewalk.cpp b/utils/fstreewalk.cpp
+index fc43edc..5e28d6e 100644
 --- a/utils/fstreewalk.cpp
 +++ b/utils/fstreewalk.cpp
 @@ -17,6 +17,7 @@
@@ -10,16 +10,33 @@ Index: utils/fstreewalk.cpp
  #include <stdio.h>
  
  #include <errno.h>
-Index: utils/pxattr.cpp
-===================================================================
---- a/utils/pxattr.cpp	2017-07-03 14:14:46.000000000 +0200
-+++ b/utils/pxattr.cpp	2017-12-17 14:34:29.955674837 +0100
-@@ -44,7 +44,7 @@
- // just let the methods return errors (like they would on a non-xattr
- // fs on e.g. linux)
+diff --git a/utils/pxattr.cpp b/utils/pxattr.cpp
+index 3a1f8f5..dcb93fc 100644
+--- a/utils/pxattr.cpp
++++ b/utils/pxattr.cpp
+@@ -46,7 +46,7 @@
  
--#if defined(__DragonFly__) || defined(__OpenBSD__)
-+#if defined(__DragonFly__) || defined(__OpenBSD__) || !defined(__GLIBC__)
+ // Not exactly true for win32, but makes my life easier by avoiding ifdefs in recoll (the calls just
+ // fail, which is expected)
+-#if defined(__DragonFly__) || defined(__OpenBSD__) || defined(_WIN32)
++#if defined(__DragonFly__) || defined(__OpenBSD__) || defined(_WIN32) || !defined(__GLIBC__)
  #define HAS_NO_XATTR
  #endif
+
+diff --git a/common/conf_post.h b/common/conf_post.h
+index 7093ead..0ecd56b 100644
+--- a/common/conf_post.h
++++ b/common/conf_post.h
+@@ -73,12 +73,4 @@ typedef int ssize_t;
+ #define REAL_GCC   __GNUC__ // probably
+ #endif
  
+-#ifdef REAL_GCC
+-// Older gcc versions pretended to supply std::regex, but the resulting programs mostly crashed.
+-#include <features.h>
+-#if ! __GNUC_PREREQ(6,0)
+-#define NO_STD_REGEX 1
+-#endif
+-#endif
+-
+ #endif /* INCLUDED */
diff --git a/srcpkgs/recoll/template b/srcpkgs/recoll/template
index 8c5de6966a46..e006864fd82e 100644
--- a/srcpkgs/recoll/template
+++ b/srcpkgs/recoll/template
@@ -1,18 +1,21 @@
 # Template file for 'recoll'
 pkgname=recoll
-version=1.30.0
+version=1.32.7
 revision=1
 build_style=gnu-configure
 build_helper=qmake
-configure_args="--disable-python-module --disable-python-chm
- --enable-recollq --disable-x11mon"
-hostmakedepends="automake libtool gettext-devel qt5-qmake pkg-config
- qt5-host-tools"
-makedepends="xapian-core-devel zlib-devel libuuid-devel qt5-webkit-devel qt5-devel
- aspell-devel libxslt-devel libxml2-devel"
+configure_args="--enable-recollq --disable-python-chm --disable-x11mon
+ --disable-webkit --without-systemd"
+hostmakedepends="pkg-config gettext-devel qt5-qmake qt5-host-tools
+ which python3-setuptools python3-devel"
+makedepends="libxslt-devel xapian-core-devel zlib-devel qt5-devel"
 short_desc="Full text search tool based on Xapian backend"
 maintainer="Rui Abreu Ferreira <raf-ep@gmx.com>"
 license="GPL-2.0-or-later"
 homepage="https://www.lesbonscomptes.com/recoll/"
-distfiles="https://www.lesbonscomptes.com/${pkgname}/${pkgname}-${version}.tar.gz"
-checksum=17a8e684a8d5560dc7b44cd4b2962cb46476a75bdc107f622051235076d11885
+distfiles="https://www.lesbonscomptes.com/recoll/recoll-${version}.tar.gz"
+checksum=ca08a6f4bb0b519bf915a062a9b7aadc4f343473cc1f07895708208d66337dba
+
+if [ "$XBPS_WORDSIZE" != "$XBPS_TARGET_WORDSIZE" ]; then
+	nocross="setup.py can not configure proper cross"
+fi
diff --git a/srcpkgs/recoll/update b/srcpkgs/recoll/update
index dcc285e571f0..afe7c791114e 100644
--- a/srcpkgs/recoll/update
+++ b/srcpkgs/recoll/update
@@ -1 +1 @@
-site="https://www.lesbonscomptes.com/recoll/download.html"
+site="https://www.lesbonscomptes.com/recoll/pages/download.html"

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (5 preceding siblings ...)
  2022-08-25 17:35 ` [PR PATCH] [Updated] " dmarto
@ 2022-08-25 17:35 ` dmarto
  2022-08-25 17:37 ` dmarto
                   ` (15 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-08-25 17:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New review comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955248220

Comment:
done

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (6 preceding siblings ...)
  2022-08-25 17:35 ` [PR REVIEW] " dmarto
@ 2022-08-25 17:37 ` dmarto
  2022-08-25 17:38 ` dmarto
                   ` (14 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-08-25 17:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

New review comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955249551

Comment:
```
./pyrclextract.cpp:19:10: fatal error: Python.h: No such file or directory
   19 | #include <Python.h>
      |          ^~~~~~~~~~
```
is how aarch64 builds fail with `python3-devel` not in hostmake

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (7 preceding siblings ...)
  2022-08-25 17:37 ` dmarto
@ 2022-08-25 17:38 ` dmarto
  2022-08-25 17:38 ` classabbyamp
                   ` (13 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-08-25 17:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

New review comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955246762

Comment:
it is implicitly enabled by the confs (they are looking for systemd paths/files); so I just added it explicitly (in case something changes)

i.e either way it doesn't change the files, but this way it is explicitly mentioned

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (8 preceding siblings ...)
  2022-08-25 17:38 ` dmarto
@ 2022-08-25 17:38 ` classabbyamp
  2022-08-25 18:02 ` dmarto
                   ` (12 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2022-08-25 17:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 632 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955251089

Comment:
does it do anything other than just installing the systemd service when enabled, though?

from manual.md:

> If the package installs a systemd service file or other unit, leave it in place as a reference point so long as including it has no negative side effects.
> 
> Examples of when not to install systemd units:
> 
> 1. When doing so changes runtime behavior of the packaged software.
> 2. When it is done via a compile time flag that also changes build dependencies.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (9 preceding siblings ...)
  2022-08-25 17:38 ` classabbyamp
@ 2022-08-25 18:02 ` dmarto
  2022-08-25 18:03 ` classabbyamp
                   ` (11 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-08-25 18:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

New review comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955269877

Comment:
from the documentation 
```
--without-systemd 
   Disable the automatic installation of systemd unit files. 
   Normally unit files are installed if the install path can be detected.
```

It only installs services, BUT
even if removed, it won't install any extra files or services - thus adding the flag to make it explicit.

(As can be seen by the current in repo pkg (without flag), there aren't any systemd unit files installed) 


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (10 preceding siblings ...)
  2022-08-25 18:02 ` dmarto
@ 2022-08-25 18:03 ` classabbyamp
  2022-08-25 18:20 ` classabbyamp
                   ` (10 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2022-08-25 18:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955270938

Comment:
ok sounds good

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (11 preceding siblings ...)
  2022-08-25 18:03 ` classabbyamp
@ 2022-08-25 18:20 ` classabbyamp
  2022-08-25 18:20 ` classabbyamp
                   ` (9 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2022-08-25 18:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955284931

Comment:
```suggestion
if [ -n "$CROSS_BUILD" ]; then
	export PYPREFIX="$XBPS_CROSS_BASE"
	export CFLAGS+=" -I${XBPS_CROSS_BASE}/${py3_inc} -I${XBPS_CROSS_BASE}/usr/include"
	export LDFLAGS+=" -L${XBPS_CROSS_BASE}/${py3_lib} -L${XBPS_CROSS_BASE}/usr/lib"
	export CC="${XBPS_CROSS_TRIPLET}-gcc -pthread $CFLAGS $LDFLAGS"
	export LDSHARED="${CC} -shared $LDFLAGS"
	export PYTHONPATH="${XBPS_CROSS_BASE}/${py3_lib}"
	for f in ${XBPS_CROSS_BASE}/${py3_lib}/_sysconfigdata_*; do
		f=${f##*/}
		_PYTHON_SYSCONFIGDATA_NAME=${f%.py}
	done
	export _PYTHON_SYSCONFIGDATA_NAME
fi
```
and move python3-devel to makedepends

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (12 preceding siblings ...)
  2022-08-25 18:20 ` classabbyamp
@ 2022-08-25 18:20 ` classabbyamp
  2022-08-25 19:11 ` [PR PATCH] [Updated] " dmarto
                   ` (8 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2022-08-25 18:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955285105

Comment:
add `--disable-rpath`

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (13 preceding siblings ...)
  2022-08-25 18:20 ` classabbyamp
@ 2022-08-25 19:11 ` dmarto
  2022-08-25 19:12 ` [PR REVIEW] " dmarto
                   ` (7 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-08-25 19:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

There is an updated pull request by dmarto against master on the void-packages repository

https://github.com/dmarto/void-packages recoll
https://github.com/void-linux/void-packages/pull/38902

recoll: update to 1.32.7.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

---

- enable python module 
- update version check page
- explicit conf args
- proper (host)makedepends
- update musl patches

A patch file from https://github.com/void-linux/void-packages/pull/38902.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-recoll-38902.patch --]
[-- Type: text/x-diff, Size: 4896 bytes --]

From 6ec5acfe329af0a13aca10ba2dd6023a266f330c Mon Sep 17 00:00:00 2001
From: Martin Dimov <martin@dmarto.com>
Date: Thu, 25 Aug 2022 03:30:03 +0300
Subject: [PATCH] recoll: update to 1.32.7.

- enable python module
- update version check page
- explicit conf args
- proper (host)makedepends
- update musl patches
- fix cross

Co-authored-by: classabbyamp <void@placeviolette.net>
---
 srcpkgs/recoll/patches/musl.patch | 39 ++++++++++++++++++++++---------
 srcpkgs/recoll/template           | 32 ++++++++++++++++++-------
 srcpkgs/recoll/update             |  2 +-
 3 files changed, 52 insertions(+), 21 deletions(-)

diff --git a/srcpkgs/recoll/patches/musl.patch b/srcpkgs/recoll/patches/musl.patch
index c83d0f553c8a..d633e92b9df1 100644
--- a/srcpkgs/recoll/patches/musl.patch
+++ b/srcpkgs/recoll/patches/musl.patch
@@ -1,5 +1,5 @@
-Index: utils/fstreewalk.cpp
-===================================================================
+diff --git a/utils/fstreewalk.cpp b/utils/fstreewalk.cpp
+index fc43edc..5e28d6e 100644
 --- a/utils/fstreewalk.cpp
 +++ b/utils/fstreewalk.cpp
 @@ -17,6 +17,7 @@
@@ -10,16 +10,33 @@ Index: utils/fstreewalk.cpp
  #include <stdio.h>
  
  #include <errno.h>
-Index: utils/pxattr.cpp
-===================================================================
---- a/utils/pxattr.cpp	2017-07-03 14:14:46.000000000 +0200
-+++ b/utils/pxattr.cpp	2017-12-17 14:34:29.955674837 +0100
-@@ -44,7 +44,7 @@
- // just let the methods return errors (like they would on a non-xattr
- // fs on e.g. linux)
+diff --git a/utils/pxattr.cpp b/utils/pxattr.cpp
+index 3a1f8f5..dcb93fc 100644
+--- a/utils/pxattr.cpp
++++ b/utils/pxattr.cpp
+@@ -46,7 +46,7 @@
  
--#if defined(__DragonFly__) || defined(__OpenBSD__)
-+#if defined(__DragonFly__) || defined(__OpenBSD__) || !defined(__GLIBC__)
+ // Not exactly true for win32, but makes my life easier by avoiding ifdefs in recoll (the calls just
+ // fail, which is expected)
+-#if defined(__DragonFly__) || defined(__OpenBSD__) || defined(_WIN32)
++#if defined(__DragonFly__) || defined(__OpenBSD__) || defined(_WIN32) || !defined(__GLIBC__)
  #define HAS_NO_XATTR
  #endif
+
+diff --git a/common/conf_post.h b/common/conf_post.h
+index 7093ead..0ecd56b 100644
+--- a/common/conf_post.h
++++ b/common/conf_post.h
+@@ -73,12 +73,4 @@ typedef int ssize_t;
+ #define REAL_GCC   __GNUC__ // probably
+ #endif
  
+-#ifdef REAL_GCC
+-// Older gcc versions pretended to supply std::regex, but the resulting programs mostly crashed.
+-#include <features.h>
+-#if ! __GNUC_PREREQ(6,0)
+-#define NO_STD_REGEX 1
+-#endif
+-#endif
+-
+ #endif /* INCLUDED */
diff --git a/srcpkgs/recoll/template b/srcpkgs/recoll/template
index 8c5de6966a46..7a305b932f95 100644
--- a/srcpkgs/recoll/template
+++ b/srcpkgs/recoll/template
@@ -1,18 +1,32 @@
 # Template file for 'recoll'
 pkgname=recoll
-version=1.30.0
+version=1.32.7
 revision=1
 build_style=gnu-configure
 build_helper=qmake
-configure_args="--disable-python-module --disable-python-chm
- --enable-recollq --disable-x11mon"
-hostmakedepends="automake libtool gettext-devel qt5-qmake pkg-config
- qt5-host-tools"
-makedepends="xapian-core-devel zlib-devel libuuid-devel qt5-webkit-devel qt5-devel
- aspell-devel libxslt-devel libxml2-devel"
+configure_args="--enable-recollq --disable-python-chm --disable-x11mon
+ --disable-webkit --without-systemd --disable-rpath"
+hostmakedepends="pkg-config gettext-devel qt5-qmake qt5-host-tools
+ which python3-setuptools"
+makedepends="libxslt-devel xapian-core-devel zlib-devel qt5-devel
+ python3-devel"
 short_desc="Full text search tool based on Xapian backend"
 maintainer="Rui Abreu Ferreira <raf-ep@gmx.com>"
 license="GPL-2.0-or-later"
 homepage="https://www.lesbonscomptes.com/recoll/"
-distfiles="https://www.lesbonscomptes.com/${pkgname}/${pkgname}-${version}.tar.gz"
-checksum=17a8e684a8d5560dc7b44cd4b2962cb46476a75bdc107f622051235076d11885
+distfiles="https://www.lesbonscomptes.com/recoll/recoll-${version}.tar.gz"
+checksum=ca08a6f4bb0b519bf915a062a9b7aadc4f343473cc1f07895708208d66337dba
+
+if [ -n "$CROSS_BUILD" ]; then
+	export PYPREFIX="$XBPS_CROSS_BASE"
+	export CFLAGS+=" -I${XBPS_CROSS_BASE}/${py3_inc} -I${XBPS_CROSS_BASE}/usr/include"
+	export LDFLAGS+=" -L${XBPS_CROSS_BASE}/${py3_lib} -L${XBPS_CROSS_BASE}/usr/lib"
+	export CC="${XBPS_CROSS_TRIPLET}-gcc -pthread $CFLAGS $LDFLAGS"
+	export LDSHARED="${CC} -shared $LDFLAGS"
+	export PYTHONPATH="${XBPS_CROSS_BASE}/${py3_lib}"
+	for f in ${XBPS_CROSS_BASE}/${py3_lib}/_sysconfigdata_*; do
+		f=${f##*/}
+		_PYTHON_SYSCONFIGDATA_NAME=${f%.py}
+	done
+	export _PYTHON_SYSCONFIGDATA_NAME
+fi
diff --git a/srcpkgs/recoll/update b/srcpkgs/recoll/update
index dcc285e571f0..afe7c791114e 100644
--- a/srcpkgs/recoll/update
+++ b/srcpkgs/recoll/update
@@ -1 +1 @@
-site="https://www.lesbonscomptes.com/recoll/download.html"
+site="https://www.lesbonscomptes.com/recoll/pages/download.html"

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (14 preceding siblings ...)
  2022-08-25 19:11 ` [PR PATCH] [Updated] " dmarto
@ 2022-08-25 19:12 ` dmarto
  2022-08-25 19:12 ` dmarto
                   ` (6 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-08-25 19:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New review comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955328583

Comment:
done

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (15 preceding siblings ...)
  2022-08-25 19:12 ` [PR REVIEW] " dmarto
@ 2022-08-25 19:12 ` dmarto
  2022-08-25 19:15 ` dmarto
                   ` (5 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-08-25 19:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New review comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r955328688

Comment:
done

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (16 preceding siblings ...)
  2022-08-25 19:12 ` dmarto
@ 2022-08-25 19:15 ` dmarto
  2022-08-30  3:29 ` [PR REVIEW] " classabbyamp
                   ` (4 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-08-25 19:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#issuecomment-1227661546

Comment:
and I have retested my local usage and integrations

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (17 preceding siblings ...)
  2022-08-25 19:15 ` dmarto
@ 2022-08-30  3:29 ` classabbyamp
  2022-08-30  3:29 ` classabbyamp
                   ` (3 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2022-08-30  3:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r957970318

Comment:
(this big block) 

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (18 preceding siblings ...)
  2022-08-30  3:29 ` [PR REVIEW] " classabbyamp
@ 2022-08-30  3:29 ` classabbyamp
  2022-08-30 11:40 ` [PR PATCH] [Updated] " dmarto
                   ` (2 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2022-08-30  3:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r957970133

Comment:
```suggestion
 build_helper="qmake python3"
```

ok i just merged a build helper that does the big crossbuild block i suggested earlier. rebase and add the build helper and removing the big block should be possible 

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (19 preceding siblings ...)
  2022-08-30  3:29 ` classabbyamp
@ 2022-08-30 11:40 ` dmarto
  2022-08-30 11:48 ` [PR REVIEW] " dmarto
  2022-08-30 16:38 ` [PR PATCH] [Merged]: " classabbyamp
  22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-08-30 11:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

There is an updated pull request by dmarto against master on the void-packages repository

https://github.com/dmarto/void-packages recoll
https://github.com/void-linux/void-packages/pull/38902

recoll: update to 1.32.7.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

---

- enable python module 
- update version check page
- explicit conf args
- proper (host)makedepends
- update musl patches

A patch file from https://github.com/void-linux/void-packages/pull/38902.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-recoll-38902.patch --]
[-- Type: text/x-diff, Size: 4377 bytes --]

From b9b27233e69d4ce694fd6eb2aa0c8dbc59b39c09 Mon Sep 17 00:00:00 2001
From: Martin Dimov <martin@dmarto.com>
Date: Thu, 25 Aug 2022 03:30:03 +0300
Subject: [PATCH] recoll: update to 1.32.7.

- enable python module
- update version check page
- explicit conf args
- proper (host)makedepends
- update musl patches
- use helper to fix python cross

Co-authored-by: classabbyamp <void@placeviolette.net>
---
 srcpkgs/recoll/patches/musl.patch | 39 ++++++++++++++++++++++---------
 srcpkgs/recoll/template           | 20 ++++++++--------
 srcpkgs/recoll/update             |  2 +-
 3 files changed, 39 insertions(+), 22 deletions(-)

diff --git a/srcpkgs/recoll/patches/musl.patch b/srcpkgs/recoll/patches/musl.patch
index c83d0f553c8a..d633e92b9df1 100644
--- a/srcpkgs/recoll/patches/musl.patch
+++ b/srcpkgs/recoll/patches/musl.patch
@@ -1,5 +1,5 @@
-Index: utils/fstreewalk.cpp
-===================================================================
+diff --git a/utils/fstreewalk.cpp b/utils/fstreewalk.cpp
+index fc43edc..5e28d6e 100644
 --- a/utils/fstreewalk.cpp
 +++ b/utils/fstreewalk.cpp
 @@ -17,6 +17,7 @@
@@ -10,16 +10,33 @@ Index: utils/fstreewalk.cpp
  #include <stdio.h>
  
  #include <errno.h>
-Index: utils/pxattr.cpp
-===================================================================
---- a/utils/pxattr.cpp	2017-07-03 14:14:46.000000000 +0200
-+++ b/utils/pxattr.cpp	2017-12-17 14:34:29.955674837 +0100
-@@ -44,7 +44,7 @@
- // just let the methods return errors (like they would on a non-xattr
- // fs on e.g. linux)
+diff --git a/utils/pxattr.cpp b/utils/pxattr.cpp
+index 3a1f8f5..dcb93fc 100644
+--- a/utils/pxattr.cpp
++++ b/utils/pxattr.cpp
+@@ -46,7 +46,7 @@
  
--#if defined(__DragonFly__) || defined(__OpenBSD__)
-+#if defined(__DragonFly__) || defined(__OpenBSD__) || !defined(__GLIBC__)
+ // Not exactly true for win32, but makes my life easier by avoiding ifdefs in recoll (the calls just
+ // fail, which is expected)
+-#if defined(__DragonFly__) || defined(__OpenBSD__) || defined(_WIN32)
++#if defined(__DragonFly__) || defined(__OpenBSD__) || defined(_WIN32) || !defined(__GLIBC__)
  #define HAS_NO_XATTR
  #endif
+
+diff --git a/common/conf_post.h b/common/conf_post.h
+index 7093ead..0ecd56b 100644
+--- a/common/conf_post.h
++++ b/common/conf_post.h
+@@ -73,12 +73,4 @@ typedef int ssize_t;
+ #define REAL_GCC   __GNUC__ // probably
+ #endif
  
+-#ifdef REAL_GCC
+-// Older gcc versions pretended to supply std::regex, but the resulting programs mostly crashed.
+-#include <features.h>
+-#if ! __GNUC_PREREQ(6,0)
+-#define NO_STD_REGEX 1
+-#endif
+-#endif
+-
+ #endif /* INCLUDED */
diff --git a/srcpkgs/recoll/template b/srcpkgs/recoll/template
index 8c5de6966a46..8084f70a8e0e 100644
--- a/srcpkgs/recoll/template
+++ b/srcpkgs/recoll/template
@@ -1,18 +1,18 @@
 # Template file for 'recoll'
 pkgname=recoll
-version=1.30.0
+version=1.32.7
 revision=1
 build_style=gnu-configure
-build_helper=qmake
-configure_args="--disable-python-module --disable-python-chm
- --enable-recollq --disable-x11mon"
-hostmakedepends="automake libtool gettext-devel qt5-qmake pkg-config
- qt5-host-tools"
-makedepends="xapian-core-devel zlib-devel libuuid-devel qt5-webkit-devel qt5-devel
- aspell-devel libxslt-devel libxml2-devel"
+build_helper="qmake python3"
+configure_args="--enable-recollq --disable-python-chm --disable-x11mon
+ --disable-webkit --without-systemd --disable-rpath"
+hostmakedepends="pkg-config gettext-devel qt5-qmake qt5-host-tools
+ which python3-setuptools"
+makedepends="libxslt-devel xapian-core-devel zlib-devel qt5-devel
+ python3-devel"
 short_desc="Full text search tool based on Xapian backend"
 maintainer="Rui Abreu Ferreira <raf-ep@gmx.com>"
 license="GPL-2.0-or-later"
 homepage="https://www.lesbonscomptes.com/recoll/"
-distfiles="https://www.lesbonscomptes.com/${pkgname}/${pkgname}-${version}.tar.gz"
-checksum=17a8e684a8d5560dc7b44cd4b2962cb46476a75bdc107f622051235076d11885
+distfiles="https://www.lesbonscomptes.com/recoll/recoll-${version}.tar.gz"
+checksum=ca08a6f4bb0b519bf915a062a9b7aadc4f343473cc1f07895708208d66337dba
diff --git a/srcpkgs/recoll/update b/srcpkgs/recoll/update
index dcc285e571f0..afe7c791114e 100644
--- a/srcpkgs/recoll/update
+++ b/srcpkgs/recoll/update
@@ -1 +1 @@
-site="https://www.lesbonscomptes.com/recoll/download.html"
+site="https://www.lesbonscomptes.com/recoll/pages/download.html"

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (20 preceding siblings ...)
  2022-08-30 11:40 ` [PR PATCH] [Updated] " dmarto
@ 2022-08-30 11:48 ` dmarto
  2022-08-30 16:38 ` [PR PATCH] [Merged]: " classabbyamp
  22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-08-30 11:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New review comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/38902#discussion_r958376614

Comment:
done

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Merged]: recoll: update to 1.32.7.
  2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
                   ` (21 preceding siblings ...)
  2022-08-30 11:48 ` [PR REVIEW] " dmarto
@ 2022-08-30 16:38 ` classabbyamp
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2022-08-30 16:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

There's a merged pull request on the void-packages repository

recoll: update to 1.32.7.
https://github.com/void-linux/void-packages/pull/38902

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

---

- enable python module 
- update version check page
- explicit conf args
- proper (host)makedepends
- update musl patches

^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2022-08-30 16:38 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-25 11:52 [PR PATCH] recoll: update to 1.32.7 dmarto
2022-08-25 17:06 ` [PR REVIEW] " classabbyamp
2022-08-25 17:09 ` classabbyamp
2022-08-25 17:11 ` classabbyamp
2022-08-25 17:33 ` dmarto
2022-08-25 17:33 ` dmarto
2022-08-25 17:35 ` [PR PATCH] [Updated] " dmarto
2022-08-25 17:35 ` [PR REVIEW] " dmarto
2022-08-25 17:37 ` dmarto
2022-08-25 17:38 ` dmarto
2022-08-25 17:38 ` classabbyamp
2022-08-25 18:02 ` dmarto
2022-08-25 18:03 ` classabbyamp
2022-08-25 18:20 ` classabbyamp
2022-08-25 18:20 ` classabbyamp
2022-08-25 19:11 ` [PR PATCH] [Updated] " dmarto
2022-08-25 19:12 ` [PR REVIEW] " dmarto
2022-08-25 19:12 ` dmarto
2022-08-25 19:15 ` dmarto
2022-08-30  3:29 ` [PR REVIEW] " classabbyamp
2022-08-30  3:29 ` classabbyamp
2022-08-30 11:40 ` [PR PATCH] [Updated] " dmarto
2022-08-30 11:48 ` [PR REVIEW] " dmarto
2022-08-30 16:38 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).