Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] xbps-src: don't export CCACHE_COMPRESS=1
@ 2022-08-30 16:57 r-ricci
  2022-08-31 12:47 ` [PR REVIEW] " sgn
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: r-ricci @ 2022-08-30 16:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1957 bytes --]

There is a new pull request by r-ricci against master on the void-packages repository

https://github.com/r-ricci/void-packages ccache-compress
https://github.com/void-linux/void-packages/pull/38986

xbps-src: don't export CCACHE_COMPRESS=1
Compression is enabled by default since ccache 4.0 and this variable
prevents disabling it through a config file (useful e.g. on compressed
filesystems).


AFAIK there's no way to disable compression when `CCACHE_COMPRESS` is present, since the environment has the highest precedence, according to the manual:

```
The priorities of configuration options are as follows (where 1 is highest):

 1. Environment variables.

 2. The primary (cache-specific) configuration file (see below).

 3. The secondary (system-wide read-only) configuration file
     <sysconfdir>/ccache.conf (typically /etc/ccache.conf or
     /usr/local/etc/ccache.conf).

 5. Compile-time defaults.
```

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38986.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ccache-compress-38986.patch --]
[-- Type: text/x-diff, Size: 897 bytes --]

From 1e450f44702c4dbf10e90e863fbceb21fcdd6565 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Tue, 30 Aug 2022 18:26:31 +0200
Subject: [PATCH] xbps-src: don't export CCACHE_COMPRESS=1

Compression is enabled by default since ccache 4.0 and this variable
prevents disabling it through a config file (useful e.g. on compressed
filesystems).
---
 xbps-src | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xbps-src b/xbps-src
index f93f5c5827fd..ba8c92b15c4c 100755
--- a/xbps-src
+++ b/xbps-src
@@ -679,7 +679,7 @@ if [ "$XBPS_CCACHE" ]; then
     export CCACHE_DIR="$XBPS_HOSTDIR/ccache"
     # Avoid not using cached files just due to compiler mtime
     # changes when e.g. bootstrapping
-    export CCACHE_COMPILERCHECK=content CCACHE_COMPRESS=1
+    export CCACHE_COMPILERCHECK=content
     export PATH="$CCACHEPATH:$PATH"
     mkdir -p $CCACHE_DIR
 fi

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] xbps-src: don't export CCACHE_COMPRESS=1
  2022-08-30 16:57 [PR PATCH] xbps-src: don't export CCACHE_COMPRESS=1 r-ricci
@ 2022-08-31 12:47 ` sgn
  2022-08-31 13:30 ` r-ricci
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2022-08-31 12:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38986#discussion_r959541701

Comment:
Not sure but something like:
```
    if [ -z "${XBPS_CCACHE_NOCOMPRESS+set}" ]; then
        export CCACHE_COMPRESS=1
    fi
```

with `XBPS_CCACHE_NOCOMPRESS` from config file.

Disable ccache compression is NOT nice.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: xbps-src: don't export CCACHE_COMPRESS=1
  2022-08-30 16:57 [PR PATCH] xbps-src: don't export CCACHE_COMPRESS=1 r-ricci
  2022-08-31 12:47 ` [PR REVIEW] " sgn
@ 2022-08-31 13:30 ` r-ricci
  2022-08-31 14:03 ` [PR PATCH] [Updated] " r-ricci
  2022-11-20 17:58 ` [PR PATCH] [Closed]: " r-ricci
  3 siblings, 0 replies; 5+ messages in thread
From: r-ricci @ 2022-08-31 13:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

New comment by r-ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/38986#issuecomment-1232941831

Comment:
> Disable ccache compression is NOT nice.

This PR doesn't disable compression. As I said, ccache enables compression by default [since version 4.0](https://ccache.dev/releasenotes.html#_ccache_4_0).
Even if you want ccache to perform compression, this variable is redundant.
Removing it changes nothing unless you add `compression = false` to `hostdir/ccache/ccache.conf`.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] xbps-src: don't export CCACHE_COMPRESS=1
  2022-08-30 16:57 [PR PATCH] xbps-src: don't export CCACHE_COMPRESS=1 r-ricci
  2022-08-31 12:47 ` [PR REVIEW] " sgn
  2022-08-31 13:30 ` r-ricci
@ 2022-08-31 14:03 ` r-ricci
  2022-11-20 17:58 ` [PR PATCH] [Closed]: " r-ricci
  3 siblings, 0 replies; 5+ messages in thread
From: r-ricci @ 2022-08-31 14:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1962 bytes --]

There is an updated pull request by r-ricci against master on the void-packages repository

https://github.com/r-ricci/void-packages ccache-compress
https://github.com/void-linux/void-packages/pull/38986

xbps-src: don't export CCACHE_COMPRESS=1
Compression is enabled by default since ccache 4.0 and this variable
prevents disabling it through a config file (useful e.g. on compressed
filesystems).


AFAIK there's no way to disable compression when `CCACHE_COMPRESS` is present, since the environment has the highest precedence, according to the manual:

```
The priorities of configuration options are as follows (where 1 is highest):

 1. Environment variables.

 2. The primary (cache-specific) configuration file (see below).

 3. The secondary (system-wide read-only) configuration file
     <sysconfdir>/ccache.conf (typically /etc/ccache.conf or
     /usr/local/etc/ccache.conf).

 5. Compile-time defaults.
```

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38986.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ccache-compress-38986.patch --]
[-- Type: text/x-diff, Size: 925 bytes --]

From 17f39b898b6874113439ad9c5d713f7c7aea2c5e Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Tue, 30 Aug 2022 18:26:31 +0200
Subject: [PATCH] xbps-src: don't export CCACHE_COMPRESS=1

ccache enables compression by default since version 4.0.
This variable is redundant and prevents disabling compression through
a config file (useful e.g. on compressed filesystems).
---
 xbps-src | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xbps-src b/xbps-src
index f93f5c5827fd..ba8c92b15c4c 100755
--- a/xbps-src
+++ b/xbps-src
@@ -679,7 +679,7 @@ if [ "$XBPS_CCACHE" ]; then
     export CCACHE_DIR="$XBPS_HOSTDIR/ccache"
     # Avoid not using cached files just due to compiler mtime
     # changes when e.g. bootstrapping
-    export CCACHE_COMPILERCHECK=content CCACHE_COMPRESS=1
+    export CCACHE_COMPILERCHECK=content
     export PATH="$CCACHEPATH:$PATH"
     mkdir -p $CCACHE_DIR
 fi

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: xbps-src: don't export CCACHE_COMPRESS=1
  2022-08-30 16:57 [PR PATCH] xbps-src: don't export CCACHE_COMPRESS=1 r-ricci
                   ` (2 preceding siblings ...)
  2022-08-31 14:03 ` [PR PATCH] [Updated] " r-ricci
@ 2022-11-20 17:58 ` r-ricci
  3 siblings, 0 replies; 5+ messages in thread
From: r-ricci @ 2022-11-20 17:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]

There's a closed pull request on the void-packages repository

xbps-src: don't export CCACHE_COMPRESS=1
https://github.com/void-linux/void-packages/pull/38986

Description:
ccache enables compression by default since version 4.0.
This variable is redundant and prevents disabling compression through
a config file (useful e.g. on compressed filesystems).


AFAIK there's no way to disable compression when `CCACHE_COMPRESS` is present, since the environment has the highest precedence, according to the manual:

```
The priorities of configuration options are as follows (where 1 is highest):

 1. Environment variables.

 2. The primary (cache-specific) configuration file (see below).

 3. The secondary (system-wide read-only) configuration file
     <sysconfdir>/ccache.conf (typically /etc/ccache.conf or
     /usr/local/etc/ccache.conf).

 5. Compile-time defaults.
```

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-11-20 17:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-30 16:57 [PR PATCH] xbps-src: don't export CCACHE_COMPRESS=1 r-ricci
2022-08-31 12:47 ` [PR REVIEW] " sgn
2022-08-31 13:30 ` r-ricci
2022-08-31 14:03 ` [PR PATCH] [Updated] " r-ricci
2022-11-20 17:58 ` [PR PATCH] [Closed]: " r-ricci

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).