* [PR PATCH] mg: update to 20220614.
@ 2022-09-06 0:43 mtboehlke
2022-09-06 6:58 ` [PR REVIEW] " classabbyamp
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: mtboehlke @ 2022-09-06 0:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]
There is a new pull request by mtboehlke against master on the void-packages repository
https://github.com/mtboehlke/void-packages mg
https://github.com/void-linux/void-packages/pull/39124
mg: update to 20220614.
Also fix compilation issues
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/39124.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mg-39124.patch --]
[-- Type: text/x-diff, Size: 1557 bytes --]
From 46d8a2b32631d50abe59e7410291f3793ed25add Mon Sep 17 00:00:00 2001
From: Mat Boehlke <mtboehlke@gmail.com>
Date: Mon, 5 Sep 2022 18:37:00 -0500
Subject: [PATCH] mg: update to 20220614.
Fix compilation issues
---
srcpkgs/mg/template | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/srcpkgs/mg/template b/srcpkgs/mg/template
index 8bb7fd00185e..be17fc60fa31 100644
--- a/srcpkgs/mg/template
+++ b/srcpkgs/mg/template
@@ -1,29 +1,26 @@
# Template file for 'mg'
pkgname=mg
-version=20210314
+version=20220614
revision=1
hostmakedepends="pkg-config"
-makedepends="libbsd-devel ncurses-devel"
+makedepends="libbsd-devel libmd-devel ncurses-devel"
short_desc="Micro GNU/emacs"
maintainer="Orphaned <orphan@voidlinux.org>"
license="Public Domain"
homepage="https://github.com/hboetes/mg"
distfiles="https://github.com/hboetes/mg/archive/${version}.tar.gz"
-checksum=6820e76a0e27d9a744624d421b3b30b0030140c2a817df1310b25c3abe397106
+checksum=d3bc16baba82457c4f60ecd258762ee2ed848064f79729fe92e29bfd181af121
-CFLAGS="-DTCSASOFT=0"
+CFLAGS+=" -DTCSASOFT=0"
case "$XBPS_TARGET_MACHINE" in
*-musl) CFLAGS+=" -DREG_STARTEND=0";;
esac
-do_configure() {
- sed -i "s,\(BSD_CPPFLAGS:=\).*,\1 -isystem ${XBPS_CROSS_BASE}/usr/include/bsd -DLIBBSD_OVERLAY,g" GNUmakefile
- sed -i "s,\(BSD_LIBS:=\).*,\1 -lbsd,g" GNUmakefile
-}
do_build() {
make CC="$CC" CFLAGS="$CFLAGS" prefix=/usr ${makejobs}
}
+
do_install() {
vmkdir usr/bin
make install prefix=/usr bindir=/usr/bin mandir=/usr/share/man DESTDIR=${DESTDIR}
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] mg: update to 20220614.
2022-09-06 0:43 [PR PATCH] mg: update to 20220614 mtboehlke
@ 2022-09-06 6:58 ` classabbyamp
2022-09-06 14:02 ` [PR PATCH] [Updated] " mtboehlke
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2022-09-06 6:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39124#discussion_r963322415
Comment:
this change isn't necessary
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] mg: update to 20220614.
2022-09-06 0:43 [PR PATCH] mg: update to 20220614 mtboehlke
2022-09-06 6:58 ` [PR REVIEW] " classabbyamp
@ 2022-09-06 14:02 ` mtboehlke
2022-09-06 14:04 ` [PR REVIEW] " mtboehlke
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: mtboehlke @ 2022-09-06 14:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]
There is an updated pull request by mtboehlke against master on the void-packages repository
https://github.com/mtboehlke/void-packages mg
https://github.com/void-linux/void-packages/pull/39124
mg: update to 20220614.
Also fix compilation issues
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/39124.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mg-39124.patch --]
[-- Type: text/x-diff, Size: 1677 bytes --]
From 24f40a7aa72d2911a816c04fb11c8f76bf2de64f Mon Sep 17 00:00:00 2001
From: Mat Boehlke <mtboehlke@gmail.com>
Date: Mon, 5 Sep 2022 18:37:00 -0500
Subject: [PATCH] mg: update to 20220614.
Add missing libmd makedepend, fix compilation issue,
and use the appropriate build style.
---
srcpkgs/mg/template | 20 +++++---------------
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/srcpkgs/mg/template b/srcpkgs/mg/template
index 8bb7fd00185e..f05da33e9443 100644
--- a/srcpkgs/mg/template
+++ b/srcpkgs/mg/template
@@ -1,30 +1,20 @@
# Template file for 'mg'
pkgname=mg
-version=20210314
+version=20220614
revision=1
+build_style=gnu-makefile
+make_install_args="mandir=/usr/share/man"
hostmakedepends="pkg-config"
-makedepends="libbsd-devel ncurses-devel"
+makedepends="libbsd-devel libmd-devel ncurses-devel"
short_desc="Micro GNU/emacs"
maintainer="Orphaned <orphan@voidlinux.org>"
license="Public Domain"
homepage="https://github.com/hboetes/mg"
distfiles="https://github.com/hboetes/mg/archive/${version}.tar.gz"
-checksum=6820e76a0e27d9a744624d421b3b30b0030140c2a817df1310b25c3abe397106
+checksum=d3bc16baba82457c4f60ecd258762ee2ed848064f79729fe92e29bfd181af121
CFLAGS="-DTCSASOFT=0"
case "$XBPS_TARGET_MACHINE" in
*-musl) CFLAGS+=" -DREG_STARTEND=0";;
esac
-
-do_configure() {
- sed -i "s,\(BSD_CPPFLAGS:=\).*,\1 -isystem ${XBPS_CROSS_BASE}/usr/include/bsd -DLIBBSD_OVERLAY,g" GNUmakefile
- sed -i "s,\(BSD_LIBS:=\).*,\1 -lbsd,g" GNUmakefile
-}
-do_build() {
- make CC="$CC" CFLAGS="$CFLAGS" prefix=/usr ${makejobs}
-}
-do_install() {
- vmkdir usr/bin
- make install prefix=/usr bindir=/usr/bin mandir=/usr/share/man DESTDIR=${DESTDIR}
-}
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] mg: update to 20220614.
2022-09-06 0:43 [PR PATCH] mg: update to 20220614 mtboehlke
2022-09-06 6:58 ` [PR REVIEW] " classabbyamp
2022-09-06 14:02 ` [PR PATCH] [Updated] " mtboehlke
@ 2022-09-06 14:04 ` mtboehlke
2022-09-06 14:05 ` mtboehlke
2022-09-06 14:54 ` [PR PATCH] [Merged]: " classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: mtboehlke @ 2022-09-06 14:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 308 bytes --]
New review comment by mtboehlke on void-packages repository
https://github.com/void-linux/void-packages/pull/39124#discussion_r963752162
Comment:
Thanks, I reverted this change. After looking more closely, I think the build and install functions can be removed by just using the gnu-makefile build style.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] mg: update to 20220614.
2022-09-06 0:43 [PR PATCH] mg: update to 20220614 mtboehlke
` (2 preceding siblings ...)
2022-09-06 14:04 ` [PR REVIEW] " mtboehlke
@ 2022-09-06 14:05 ` mtboehlke
2022-09-06 14:54 ` [PR PATCH] [Merged]: " classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: mtboehlke @ 2022-09-06 14:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
New review comment by mtboehlke on void-packages repository
https://github.com/void-linux/void-packages/pull/39124#discussion_r963752162
Comment:
Thanks, I reverted this change. After looking more closely, I think the build and install functions can be replaced by just using the gnu-makefile style.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: mg: update to 20220614.
2022-09-06 0:43 [PR PATCH] mg: update to 20220614 mtboehlke
` (3 preceding siblings ...)
2022-09-06 14:05 ` mtboehlke
@ 2022-09-06 14:54 ` classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2022-09-06 14:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
There's a merged pull request on the void-packages repository
mg: update to 20220614.
https://github.com/void-linux/void-packages/pull/39124
Description:
Also fix compilation issues
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-06 14:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-06 0:43 [PR PATCH] mg: update to 20220614 mtboehlke
2022-09-06 6:58 ` [PR REVIEW] " classabbyamp
2022-09-06 14:02 ` [PR PATCH] [Updated] " mtboehlke
2022-09-06 14:04 ` [PR REVIEW] " mtboehlke
2022-09-06 14:05 ` mtboehlke
2022-09-06 14:54 ` [PR PATCH] [Merged]: " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).