Github messages for voidlinux
 help / color / mirror / Atom feed
From: emilio1625 <emilio1625@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] Add aptXand ldac support to gstreamer bad plugins
Date: Thu, 08 Sep 2022 00:33:27 +0200	[thread overview]
Message-ID: <20220907223327.B-J48GjS0aHXVZT9kjZ-XqsI7PZjMMN3nx3lKpu5zlg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39157@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 712 bytes --]

There is an updated pull request by emilio1625 against master on the void-packages repository

https://github.com/emilio1625/void-packages gst-plugins-bad1-aptx-support
https://github.com/void-linux/void-packages/pull/39157

Add aptXand ldac support to gstreamer bad plugins
Adds aptx support for gstreamer, if support for gstreamer codecs is added to pulseaudio, this allows the use of aptX or ldac when using bluetooth devices that support this codecs

#### Testing the changes
- I tested the changes in this PR: YES

#### Local build testing
- I built this PR locally for my native architecture, (x86-glibc)



A patch file from https://github.com/void-linux/void-packages/pull/39157.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gst-plugins-bad1-aptx-support-39157.patch --]
[-- Type: text/x-diff, Size: 2349 bytes --]

From c63fca06f7ba5c37ee9347147a026c3891348b92 Mon Sep 17 00:00:00 2001
From: Emilio Cabrera <emilio1625@gmail.com>
Date: Wed, 7 Sep 2022 16:14:08 -0500
Subject: [PATCH] gst-plugins-bad1: add aptX support

---
 srcpkgs/gst-plugins-bad1/template | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gst-plugins-bad1/template b/srcpkgs/gst-plugins-bad1/template
index 9b44958ec1ea..f3f9e77b98e3 100644
--- a/srcpkgs/gst-plugins-bad1/template
+++ b/srcpkgs/gst-plugins-bad1/template
@@ -1,7 +1,7 @@
 # Template file for 'gst-plugins-bad1'
 pkgname=gst-plugins-bad1
 version=1.20.3
-revision=2
+revision=3
 wrksrc="${pkgname/1/}-${version}"
 build_helper="gir"
 build_style=meson
@@ -13,6 +13,7 @@ configure_args="-Dpackage-origin=https://voidlinux.org -Ddoc=disabled
  -Dopenh264=disabled -Dopenmpt=disabled -Dopenni2=disabled -Dsctp=disabled
  -Dsrt=disabled -Dteletext=disabled -Dvoaacenc=disabled -Dvoamrwbenc=disabled
  -Dwildmidi=disabled -Dwpe=disabled -Ddirectfb=disabled
+ -Dldac=$(vopt_if ldac enabled disabled) -Dopenaptx=$(vopt_if aptx enabled disabled)
  -Dgme=$(vopt_if gme enabled disabled)
  -Dintrospection=$(vopt_if gir enabled disabled) -Dneon=disabled"
 hostmakedepends="automake gettext libtool pkg-config python3 glib-devel
@@ -29,7 +30,7 @@ makedepends="alsa-lib-devel celt-devel openssl-devel exempi-devel
  fdk-aac-devel flite-devel fluidsynth-devel liblrdf-devel ladspa-sdk
  lilv-devel lv2 libopenjpeg2-devel sbc-devel spandsp-devel vulkan-loader
  Vulkan-Headers webrtc-audio-processing-devel libzbar-devel ffmpeg-devel
- srt-devel
+ $(vopt_if ldac ldacBT-devel) $(vopt_if aptx libopenaptx-devel) srt-devel
  $(vopt_if gme libgme-devel)"
 depends="gst-plugins-base1>=${version}"
 short_desc="GStreamer plugins from the bad set (v1.x)"
@@ -39,9 +40,11 @@ homepage="https://gstreamer.freedesktop.org"
 distfiles="${homepage}/src/${pkgname/1/}/${pkgname/1/}-${version}.tar.xz"
 checksum=7a11c13b55dd1d2386dd902219e41cbfcdda8e1e0aa3e738186c95074b35da4f
 
-build_options="gir gme wayland"
-build_options_default="gir wayland"
+build_options="gir gme wayland aptx ldac"
+build_options_default="gir wayland aptx ldac"
 desc_option_gme="Build with Game Music Emulator support"
+desc_option_apx="Build with AptX codec support"
+desc_option_ldac="Build with ldac codec support"
 
 CFLAGS="-fcommon"
 

  reply	other threads:[~2022-09-07 22:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 22:28 [PR PATCH] " emilio1625
2022-09-07 22:33 ` emilio1625 [this message]
2022-09-07 22:46 ` emilio1625
2022-09-07 22:46 ` [PR PATCH] [Closed]: " emilio1625

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220907223327.B-J48GjS0aHXVZT9kjZ-XqsI7PZjMMN3nx3lKpu5zlg@z \
    --to=emilio1625@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).