From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Fix qbittorrent crash on musl
Date: Thu, 08 Sep 2022 07:50:21 +0200 [thread overview]
Message-ID: <20220908055021.iajybo5kNcL1n92W9_UYJg48Hi0LW2VZpsQjevBBqJs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39154@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/39154#discussion_r965524818
Comment:
We may need to:
```cpp
#ifndef _POSIX_C_SOURCE
#define _POSIX_C_SOURCE 200112L
#elif _POSIX_C_SOURCE < 200112L
#undef _POSIX_C_SOURCE
#define _POSIX_C_SOURCE 200112L
#endif
```
Just in case the `boost/align/detail/aligned_alloc_posix.hpp` needs something only available when that macro is defined?
Don't know if `_POSIX_C_SOURCE < 200112L` is a good idea, though.
next prev parent reply other threads:[~2022-09-08 5:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 20:36 [PR PATCH] " ericonr
2022-09-07 20:37 ` ericonr
2022-09-08 1:34 ` [PR REVIEW] " sgn
2022-09-08 1:34 ` sgn
2022-09-08 2:45 ` ericonr
2022-09-08 2:46 ` ericonr
2022-09-08 2:49 ` [PR PATCH] [Updated] " ericonr
2022-09-08 5:48 ` [PR REVIEW] " sgn
2022-09-08 5:50 ` sgn [this message]
2022-09-09 1:55 ` [PR PATCH] [Updated] " sgn
2022-09-09 1:56 ` sgn
2022-09-09 1:58 ` [PR REVIEW] " sgn
2022-09-09 6:34 ` [PR PATCH] [Updated] " sgn
2022-09-09 6:34 ` sgn
2022-09-11 16:31 ` sgn
2022-09-11 16:37 ` [PR PATCH] [Merged]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220908055021.iajybo5kNcL1n92W9_UYJg48Hi0LW2VZpsQjevBBqJs@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).