From: Barbaross93 <Barbaross93@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: keyd: add check to runit service
Date: Mon, 12 Sep 2022 19:57:17 +0200 [thread overview]
Message-ID: <20220912175717.hX7Kzo_MEOcv8qJVEzW_Bto8uQa3xnPgERHS8KYGFsE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38467@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
New comment by Barbaross93 on void-packages repository
https://github.com/void-linux/void-packages/pull/38467#issuecomment-1244099855
Comment:
> No there should be a comment to why this check exist.
OK, thank you, this makes much more sense.
> nobody will know why this check exists in the first place without having to track down the PR where it has been introduced.
The commit just says "add check to runit service" and the line alone makes not much sense without knowing the full context and specifics about how udevd is spawned twice without a comment that mentions that.
This also makes much more sense. Will it be sufficient to edit the commit message in addition to a comment?
next prev parent reply other threads:[~2022-09-12 17:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 13:33 [PR PATCH] " Barbaross93
2022-08-09 14:19 ` akhiljalagam
2022-08-09 14:24 ` akhiljalagam
2022-09-12 16:32 ` Barbaross93
2022-09-12 17:02 ` Duncaen
2022-09-12 17:08 ` Duncaen
2022-09-12 17:10 ` Barbaross93
2022-09-12 17:10 ` Barbaross93
2022-09-12 17:13 ` Duncaen
2022-09-12 17:14 ` Duncaen
2022-09-12 17:15 ` Duncaen
2022-09-12 17:25 ` Barbaross93
2022-09-12 17:30 ` Duncaen
2022-09-12 17:42 ` Barbaross93
2022-09-12 17:52 ` Duncaen
2022-09-12 17:53 ` Duncaen
2022-09-12 17:57 ` Barbaross93 [this message]
2022-09-12 18:08 ` Duncaen
2022-09-12 18:09 ` [PR PATCH] [Updated] " Barbaross93
2022-09-12 18:14 ` [PR PATCH] [Updated] keyd: Verify current udevd process is supervised by runit Barbaross93
2022-09-12 18:15 ` Barbaross93
2022-09-12 21:32 ` [PR PATCH] [Updated] " Barbaross93
2022-09-12 21:34 ` Barbaross93
2022-10-05 12:43 ` [PR PATCH] [Updated] " Barbaross93
2022-10-05 12:46 ` Barbaross93
2022-10-05 13:01 ` Barbaross93
2022-10-05 13:07 ` [PR PATCH] [Merged]: " Duncaen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220912175717.hX7Kzo_MEOcv8qJVEzW_Bto8uQa3xnPgERHS8KYGFsE@z \
--to=barbaross93@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).